Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/652432/?format=api
{ "id": 652432, "url": "http://patchwork.ozlabs.org/api/patches/652432/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1469488555-28187-7-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1469488555-28187-7-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-07-25T23:15:48", "name": "[next,S40,06/13] i40e: Fix static analysis tool warning", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "70bec6bed4205acd0cc653923bd7a66dcf8ac2d5", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1469488555-28187-7-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/652432/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/652432/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3ryxtr0T7Yz9t0p\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 26 Jul 2016 09:15:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 508F988861;\n\tMon, 25 Jul 2016 23:15:30 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RrJeJQ2LAeld; Mon, 25 Jul 2016 23:15:28 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0AE82889C2;\n\tMon, 25 Jul 2016 23:15:28 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id DE46C1C1511\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jul 2016 23:15:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D902E88BB1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jul 2016 23:15:25 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id GgAQESUQtRvr for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jul 2016 23:15:25 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7168B866E4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 25 Jul 2016 23:15:25 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 25 Jul 2016 16:15:23 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby orsmga003.jf.intel.com with ESMTP; 25 Jul 2016 16:15:23 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,421,1464678000\"; d=\"scan'208\";a=\"853301723\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 25 Jul 2016 16:15:48 -0700", "Message-Id": "<1469488555-28187-7-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1469488555-28187-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1469488555-28187-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S40 06/13] i40e: Fix static analysis\n\ttool warning", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Dave Ertman <david.m.ertman@intel.com>\n\nThis patch fixes a problem where a static analysis tool generates a warning \nfor \"INVARIANT_CONDITION: Expression 'enabled_tc' used in the condition \nalways yields the same result.\"\n\nWithout this patch, the driver will not pass the static analysis tool checks \nwithout generating warnings.\n\nThis patch fixes the problem by eliminating the irrelevant check and redundant \nassignment for the value of enabled_tc.\n\nSigned-off-by: Dave Ertman <david.m.ertman@intel.com>\nChange-ID: Ia7d44cb050f507df7de333e96369d322e08bf408\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex b6f9b11..c130149 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -4608,8 +4608,6 @@ static u8 i40e_pf_get_num_tc(struct i40e_pf *pf)\n \telse\n \t\treturn 1; /* Only TC0 */\n \n-\t/* At least have TC0 */\n-\tenabled_tc = (enabled_tc ? enabled_tc : 0x1);\n \tfor (i = 0; i < I40E_MAX_TRAFFIC_CLASS; i++) {\n \t\tif (enabled_tc & BIT(i))\n \t\t\tnum_tc++;\n", "prefixes": [ "next", "S40", "06/13" ] }