Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/650501/?format=api
{ "id": 650501, "url": "http://patchwork.ozlabs.org/api/patches/650501/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160719232331.31422-2-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160719232331.31422-2-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-07-19T23:23:29", "name": "[v1,1/3] i40e: move i40e_vsi_config_rss below i40e_get_rss_aq", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0abbffc6921b0ab394b764aee2e63f1f12eb132e", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160719232331.31422-2-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/650501/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/650501/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rvGM80sMfz9stY\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 20 Jul 2016 09:23:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id AE96C896DA;\n\tTue, 19 Jul 2016 23:23:46 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id DiUvHa_nFrI5; Tue, 19 Jul 2016 23:23:39 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 65ADC89710;\n\tTue, 19 Jul 2016 23:23:39 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id DC7CF1C0D7B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Jul 2016 23:23:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id CFABB8B63F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Jul 2016 23:23:36 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id cqh3sR+CjElX for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Jul 2016 23:23:34 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B57F68B64F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 19 Jul 2016 23:23:34 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 19 Jul 2016 16:23:34 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.116])\n\tby orsmga003.jf.intel.com with ESMTP; 19 Jul 2016 16:23:34 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,391,1464678000\"; d=\"scan'208\";a=\"849516167\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 19 Jul 2016 16:23:29 -0700", "Message-Id": "<20160719232331.31422-2-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.9.0.rc1.405.g81f467e", "In-Reply-To": "<20160719232331.31422-1-jacob.e.keller@intel.com>", "References": "<20160719232331.31422-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v1 1/3] i40e: move i40e_vsi_config_rss\n\tbelow i40e_get_rss_aq", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Move this function below the two functions related to configuring RSS\nvia the admin queue. This helps co-locate the two functions, and made it\neasier to spot a bug in the first i40e_config_rss_aq function as\ncompared to the i40e_get_rss_aq function.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 54 ++++++++++++++---------------\n 1 file changed, 27 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex a2340dbfe07e..d482443d01de 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -7995,33 +7995,6 @@ config_rss_aq_out:\n \treturn ret;\n }\n \n-/**\n- * i40e_vsi_config_rss - Prepare for VSI(VMDq) RSS if used\n- * @vsi: VSI structure\n- **/\n-static int i40e_vsi_config_rss(struct i40e_vsi *vsi)\n-{\n-\tu8 seed[I40E_HKEY_ARRAY_SIZE];\n-\tstruct i40e_pf *pf = vsi->back;\n-\tu8 *lut;\n-\tint ret;\n-\n-\tif (!(pf->flags & I40E_FLAG_RSS_AQ_CAPABLE))\n-\t\treturn 0;\n-\n-\tlut = kzalloc(vsi->rss_table_size, GFP_KERNEL);\n-\tif (!lut)\n-\t\treturn -ENOMEM;\n-\n-\ti40e_fill_rss_lut(pf, lut, vsi->rss_table_size, vsi->rss_size);\n-\tnetdev_rss_key_fill((void *)seed, I40E_HKEY_ARRAY_SIZE);\n-\tvsi->rss_size = min_t(int, pf->alloc_rss_size, vsi->num_queue_pairs);\n-\tret = i40e_config_rss_aq(vsi, seed, lut, vsi->rss_table_size);\n-\tkfree(lut);\n-\n-\treturn ret;\n-}\n-\n /**\n * i40e_get_rss_aq - Get RSS keys and lut by using AQ commands\n * @vsi: Pointer to vsi structure\n@@ -8068,6 +8041,33 @@ static int i40e_get_rss_aq(struct i40e_vsi *vsi, const u8 *seed,\n \treturn ret;\n }\n \n+/**\n+ * i40e_vsi_config_rss - Prepare for VSI(VMDq) RSS if used\n+ * @vsi: VSI structure\n+ **/\n+static int i40e_vsi_config_rss(struct i40e_vsi *vsi)\n+{\n+\tu8 seed[I40E_HKEY_ARRAY_SIZE];\n+\tstruct i40e_pf *pf = vsi->back;\n+\tu8 *lut;\n+\tint ret;\n+\n+\tif (!(pf->flags & I40E_FLAG_RSS_AQ_CAPABLE))\n+\t\treturn 0;\n+\n+\tlut = kzalloc(vsi->rss_table_size, GFP_KERNEL);\n+\tif (!lut)\n+\t\treturn -ENOMEM;\n+\n+\ti40e_fill_rss_lut(pf, lut, vsi->rss_table_size, vsi->rss_size);\n+\tnetdev_rss_key_fill((void *)seed, I40E_HKEY_ARRAY_SIZE);\n+\tvsi->rss_size = min_t(int, pf->alloc_rss_size, vsi->num_queue_pairs);\n+\tret = i40e_config_rss_aq(vsi, seed, lut, vsi->rss_table_size);\n+\tkfree(lut);\n+\n+\treturn ret;\n+}\n+\n /**\n * i40e_config_rss_reg - Configure RSS keys and lut by writing registers\n * @vsi: Pointer to vsi structure\n", "prefixes": [ "v1", "1/3" ] }