Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/648344/?format=api
{ "id": 648344, "url": "http://patchwork.ozlabs.org/api/patches/648344/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1468496829-18912-1-git-send-email-colin.king@canonical.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1468496829-18912-1-git-send-email-colin.king@canonical.com>", "list_archive_url": null, "date": "2016-07-14T11:47:09", "name": "ixgbe: remove redundant check on ret_val", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "08e00e0d820dc2f7a8d8ce5eaa7ed747c7b70d12", "submitter": { "id": 2900, "url": "http://patchwork.ozlabs.org/api/people/2900/?format=api", "name": "Colin Ian King", "email": "colin.king@canonical.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1468496829-18912-1-git-send-email-colin.king@canonical.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/648344/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/648344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rqv8d6PJjz9sRB\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Jul 2016 21:48:00 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 75ACD311BC;\n\tThu, 14 Jul 2016 11:47:58 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8Z6P82v6gthO; Thu, 14 Jul 2016 11:47:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5A956311A6;\n\tThu, 14 Jul 2016 11:47:56 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 5590A1C11A9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jul 2016 11:47:55 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4DC938A00C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jul 2016 11:47:55 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R9rSo66VEtbz for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jul 2016 11:47:54 +0000 (UTC)", "from youngberry.canonical.com (youngberry.canonical.com\n\t[91.189.89.112])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 0F79F859C4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Jul 2016 11:47:54 +0000 (UTC)", "from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost)\n\tby youngberry.canonical.com with esmtpsa\n\t(TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.76) (envelope-from <colin.king@canonical.com>)\n\tid 1bNf7O-00087j-3k; Thu, 14 Jul 2016 11:47:50 +0000" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Colin King <colin.king@canonical.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Date": "Thu, 14 Jul 2016 12:47:09 +0100", "Message-Id": "<1468496829-18912-1-git-send-email-colin.king@canonical.com>", "X-Mailer": "git-send-email 2.8.1", "Cc": "linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: remove redundant check on ret_val", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Colin Ian King <colin.king@canonical.com>\n\nThe last check on ret_val is redundant since ret_val has not changed\nsince the previous check, so remove it as it is extraneous.\n\nSigned-off-by: Colin Ian King <colin.king@canonical.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\nindex 47afed7..63b2500 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c\n@@ -1813,9 +1813,6 @@ static s32 ixgbe_start_hw_82599(struct ixgbe_hw *hw)\n \t/* We need to run link autotry after the driver loads */\n \thw->mac.autotry_restart = true;\n \n-\tif (ret_val)\n-\t\treturn ret_val;\n-\n \treturn ixgbe_verify_fw_version_82599(hw);\n }\n \n", "prefixes": [] }