Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/648018/?format=api
{ "id": 648018, "url": "http://patchwork.ozlabs.org/api/patches/648018/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1468431214-23969-1-git-send-email-anthony.l.nguyen@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1468431214-23969-1-git-send-email-anthony.l.nguyen@intel.com>", "list_archive_url": null, "date": "2016-07-13T17:33:34", "name": "[v2,2/2] ixgbevf: Commonize mailbox write/read", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c03af421c2b44f1eddea8f27fdc815325c32c58a", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1468431214-23969-1-git-send-email-anthony.l.nguyen@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/648018/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/648018/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rqSNZ1Fdnz9s9x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Jul 2016 04:41:50 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B73C286F87;\n\tWed, 13 Jul 2016 18:41:48 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dKn5-gxnc_X1; Wed, 13 Jul 2016 18:41:48 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1949F89660;\n\tWed, 13 Jul 2016 18:41:48 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 031E11C0D74\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Jul 2016 18:41:47 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F30DB8966C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Jul 2016 18:41:46 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LOdev1EwoeE6 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Jul 2016 18:41:46 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 591B189655\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 13 Jul 2016 18:41:46 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga104.fm.intel.com with ESMTP; 13 Jul 2016 11:41:45 -0700", "from unknown (HELO anguy11-desk2.localdomain.com) ([10.166.12.55])\n\tby FMSMGA003.fm.intel.com with ESMTP; 13 Jul 2016 11:41:43 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.28,358,1464678000\"; d=\"scan'208\";a=\"733745743\"", "From": "Tony Nguyen <anthony.l.nguyen@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Wed, 13 Jul 2016 10:33:34 -0700", "Message-Id": "<1468431214-23969-1-git-send-email-anthony.l.nguyen@intel.com>", "X-Mailer": "git-send-email 2.4.0", "Subject": "[Intel-wired-lan] [PATCH v2 2/2] ixgbevf: Commonize mailbox\n\twrite/read", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: \"Nguyen, Anthony L\" <anthony.l.nguyen@intel.com>\n\nWith changes to ixgbevf_write_msg_read_ack(), other functions are\nperforming the same operations done here; change those functions to\nutilize ixgbevf_write_msg_read_ack().\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/vf.c | 35 ++++++---------------------------\n 1 file changed, 6 insertions(+), 29 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex 4862bc2..a52f70e 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -267,7 +267,6 @@ static s32 ixgbevf_get_mac_addr_vf(struct ixgbe_hw *hw, u8 *mac_addr)\n \n static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)\n {\n-\tstruct ixgbe_mbx_info *mbx = &hw->mbx;\n \tu32 msgbuf[3], msgbuf_chk;\n \tu8 *msg_addr = (u8 *)(&msgbuf[1]);\n \ts32 ret_val;\n@@ -284,11 +283,8 @@ static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)\n \n \tif (addr)\n \t\tether_addr_copy(msg_addr, addr);\n-\tret_val = mbx->ops.write_posted(hw, msgbuf, 3);\n-\n-\tif (!ret_val)\n-\t\tret_val = mbx->ops.read_posted(hw, msgbuf, 3);\n \n+\tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 3);\n \tif (!ret_val) {\n \t\tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n@@ -437,7 +433,6 @@ int ixgbevf_get_rss_key_locked(struct ixgbe_hw *hw, u8 *rss_key)\n static s32 ixgbevf_set_rar_vf(struct ixgbe_hw *hw, u32 index, u8 *addr,\n \t\t\t u32 vmdq)\n {\n-\tstruct ixgbe_mbx_info *mbx = &hw->mbx;\n \tu32 msgbuf[3];\n \tu8 *msg_addr = (u8 *)(&msgbuf[1]);\n \ts32 ret_val;\n@@ -445,10 +440,8 @@ static s32 ixgbevf_set_rar_vf(struct ixgbe_hw *hw, u32 index, u8 *addr,\n \tmemset(msgbuf, 0, sizeof(msgbuf));\n \tmsgbuf[0] = IXGBE_VF_SET_MAC_ADDR;\n \tether_addr_copy(msg_addr, addr);\n-\tret_val = mbx->ops.write_posted(hw, msgbuf, 3);\n \n-\tif (!ret_val)\n-\t\tret_val = mbx->ops.read_posted(hw, msgbuf, 3);\n+\tret_val = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n \n \tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n@@ -545,7 +538,6 @@ static s32 ixgbevf_hv_update_mc_addr_list_vf(struct ixgbe_hw *hw,\n **/\n static s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode)\n {\n-\tstruct ixgbe_mbx_info *mbx = &hw->mbx;\n \tu32 msgbuf[2];\n \ts32 err;\n \n@@ -559,11 +551,7 @@ static s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode)\n \tmsgbuf[0] = IXGBE_VF_UPDATE_XCAST_MODE;\n \tmsgbuf[1] = xcast_mode;\n \n-\terr = mbx->ops.write_posted(hw, msgbuf, 2);\n-\tif (err)\n-\t\treturn err;\n-\n-\terr = mbx->ops.read_posted(hw, msgbuf, 2);\n+\terr = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n \tif (err)\n \t\treturn err;\n \n@@ -592,7 +580,6 @@ static s32 ixgbevf_hv_update_xcast_mode(struct ixgbe_hw *hw, int xcast_mode)\n static s32 ixgbevf_set_vfta_vf(struct ixgbe_hw *hw, u32 vlan, u32 vind,\n \t\t\t bool vlan_on)\n {\n-\tstruct ixgbe_mbx_info *mbx = &hw->mbx;\n \tu32 msgbuf[2];\n \ts32 err;\n \n@@ -601,11 +588,7 @@ static s32 ixgbevf_set_vfta_vf(struct ixgbe_hw *hw, u32 vlan, u32 vind,\n \t/* Setting the 8 bit field MSG INFO to TRUE indicates \"add\" */\n \tmsgbuf[0] |= vlan_on << IXGBE_VT_MSGINFO_SHIFT;\n \n-\terr = mbx->ops.write_posted(hw, msgbuf, 2);\n-\tif (err)\n-\t\tgoto mbx_err;\n-\n-\terr = mbx->ops.read_posted(hw, msgbuf, 2);\n+\terr = ixgbevf_write_msg_read_ack(hw, msgbuf, msgbuf, 2);\n \tif (err)\n \t\tgoto mbx_err;\n \n@@ -853,11 +836,8 @@ static int ixgbevf_negotiate_api_version_vf(struct ixgbe_hw *hw, int api)\n \tmsg[0] = IXGBE_VF_API_NEGOTIATE;\n \tmsg[1] = api;\n \tmsg[2] = 0;\n-\terr = hw->mbx.ops.write_posted(hw, msg, 3);\n-\n-\tif (!err)\n-\t\terr = hw->mbx.ops.read_posted(hw, msg, 3);\n \n+\terr = ixgbevf_write_msg_read_ack(hw, msg, msg, 3);\n \tif (!err) {\n \t\tmsg[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n@@ -906,11 +886,8 @@ int ixgbevf_get_queues(struct ixgbe_hw *hw, unsigned int *num_tcs,\n \t/* Fetch queue configuration from the PF */\n \tmsg[0] = IXGBE_VF_GET_QUEUE;\n \tmsg[1] = msg[2] = msg[3] = msg[4] = 0;\n-\terr = hw->mbx.ops.write_posted(hw, msg, 5);\n-\n-\tif (!err)\n-\t\terr = hw->mbx.ops.read_posted(hw, msg, 5);\n \n+\terr = ixgbevf_write_msg_read_ack(hw, msg, msg, 5);\n \tif (!err) {\n \t\tmsg[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n", "prefixes": [ "v2", "2/2" ] }