Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/639899/?format=api
{ "id": 639899, "url": "http://patchwork.ozlabs.org/api/patches/639899/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1466716126-9971-1-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1466716126-9971-1-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-06-23T21:08:46", "name": "[next,S39,3/3] i40e: Move the mutex lock in i40e_client_unregister", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2241f84cf4f39d5f1f486ca0e34ac6e8967c6737", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1466716126-9971-1-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/639899/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/639899/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rbDZv2p7bz9s9n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 24 Jun 2016 07:08:23 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id F20A7C091A;\n\tThu, 23 Jun 2016 21:08:21 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dV6d3dNr8A11; Thu, 23 Jun 2016 21:08:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EC71BC0784;\n\tThu, 23 Jun 2016 21:08:19 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E8AF31C2D29\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jun 2016 21:08:18 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E436186692\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jun 2016 21:08:18 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id W1RxGgbzp5wH for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jun 2016 21:08:15 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B9BB286BD4\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jun 2016 21:08:14 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 23 Jun 2016 14:08:14 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby orsmga002.jf.intel.com with ESMTP; 23 Jun 2016 14:08:15 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.26,518,1459839600\"; d=\"scan'208\";\n\ta=\"1004052778\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 23 Jun 2016 14:08:46 -0700", "Message-Id": "<1466716126-9971-1-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "Subject": "[Intel-wired-lan] [next PATCH S39 3/3] i40e: Move the mutex lock in\n\ti40e_client_unregister", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Catherine Sullivan <catherine.sullivan@intel.com>\n\nWe need to lock the client list around the i40e_client_release call to\nprevent the release from interrupting the client instances while they are\nbeing added.\n\nSigned-off-by: Catherine Sullivan <catherine.sullivan@intel.com>\nChange-Id: I99993f20179aaf8730207833e7d0869d2ccffa1d\n---\nTesting Hints: Do a insmod/rmmod of i40iw quickly and see if there is a\nkernel paging failure.\n\nHSD-number: 7661337\n\n drivers/net/ethernet/intel/i40e/i40e_client.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/intel/i40e/i40e_client.c\nindex c6557d4..0d15f7e 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_client.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_client.c\n@@ -1007,13 +1007,13 @@ int i40e_unregister_client(struct i40e_client *client)\n \t * a close for each of the client instances that were opened.\n \t * client_release function is called to handle this.\n \t */\n+\tmutex_lock(&i40e_client_mutex);\n \tif (!client || i40e_client_release(client)) {\n \t\tret = -EIO;\n \t\tgoto out;\n \t}\n \n \t/* TODO: check if device is in reset, or if that matters? */\n-\tmutex_lock(&i40e_client_mutex);\n \tif (!i40e_client_is_registered(client)) {\n \t\tpr_info(\"i40e: Client %s has not been registered\\n\",\n \t\t\tclient->name);\n@@ -1032,8 +1032,8 @@ int i40e_unregister_client(struct i40e_client *client)\n \t\t client->name);\n \t}\n \n-\tmutex_unlock(&i40e_client_mutex);\n out:\n+\tmutex_unlock(&i40e_client_mutex);\n \treturn ret;\n }\n EXPORT_SYMBOL(i40e_unregister_client);\n", "prefixes": [ "next", "S39", "3/3" ] }