Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/639889/?format=api
{ "id": 639889, "url": "http://patchwork.ozlabs.org/api/patches/639889/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160623203103.30528-2-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160623203103.30528-2-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-06-23T20:31:01", "name": "[v2] fm10k: don't continue probe if PCI device not in normal IO state", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6af2034ff45802f3d0ea91fda9f428ed290c97db", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160623203103.30528-2-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/639889/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/639889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rbCm12VMvz9s9Y\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 24 Jun 2016 06:31:13 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 75E7692188;\n\tThu, 23 Jun 2016 20:31:11 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id FzPu7-Xo3U7q; Thu, 23 Jun 2016 20:31:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6E5E491EE6;\n\tThu, 23 Jun 2016 20:31:10 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 63DB81CF6DB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jun 2016 20:31:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5773733925\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jun 2016 20:31:09 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eR5NAHZ8X6XN for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jun 2016 20:31:07 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5957E33A00\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 23 Jun 2016 20:31:07 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga103.fm.intel.com with ESMTP; 23 Jun 2016 13:31:07 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.116])\n\tby fmsmga002.fm.intel.com with ESMTP; 23 Jun 2016 13:31:07 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.26,518,1459839600\"; d=\"scan'208\";\n\ta=\"1008435910\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 23 Jun 2016 13:31:01 -0700", "Message-Id": "<20160623203103.30528-2-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.9.0.rc1.405.g81f467e", "In-Reply-To": "<20160623203103.30528-1-jacob.e.keller@intel.com>", "References": "<20160623203103.30528-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v2] fm10k: don't continue probe if PCI\n\tdevice not in normal IO state", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "In the event of an uncorrectable AER error occuring when the driver has\nnot loaded, the recovery routines are not done. This is done because\nfuture loads of the driver may not be aware of the IO state and may not\nbe able to recover at all. In this case, when we next load the driver it\nfails due to what appears to be a surprise remove event. Instead, add\na check to ensure that the device is in the normal IO state before\ncontinuing to probe. This allows us to give a more descriptive message\nof what is wrong.\n\nWithout this change, the driver will attempt to probe up to our first\ncall of .reset_hw() which will be unable to read registers and act as if\na surprise remove event occurred.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 552268292ac8..0293eed5005b 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1950,6 +1950,12 @@ static int fm10k_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tstruct fm10k_intfc *interface;\n \tint err;\n \n+\tif (pdev->error_state != pci_channel_io_normal) {\n+\t\tdev_err(&pdev->dev,\n+\t\t\t\"PCI device still in an error state. Unable to load...\\n\");\n+\t\treturn -EIO;\n+\t}\n+\n \terr = pci_enable_device_mem(pdev);\n \tif (err) {\n \t\tdev_err(&pdev->dev,\n", "prefixes": [ "v2" ] }