Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/638513/?format=api
{ "id": 638513, "url": "http://patchwork.ozlabs.org/api/patches/638513/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-5-git-send-email-andrew.smirnov@gmail.com/", "project": { "id": 9, "url": "http://patchwork.ozlabs.org/api/projects/9/?format=api", "name": "Linux RTC development", "link_name": "rtc-linux", "list_id": "linux-rtc.vger.kernel.org", "list_email": "linux-rtc@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1466493770-11895-5-git-send-email-andrew.smirnov@gmail.com>", "list_archive_url": null, "date": "2016-06-21T07:22:39", "name": "[v2,06/17] RTC: ds1307: Convert want_irq into a predicate", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "c07d8d5a75f60a1cb5fda34f1b73107a8d023404", "submitter": { "id": 67013, "url": "http://patchwork.ozlabs.org/api/people/67013/?format=api", "name": "Andrey Smirnov", "email": "andrew.smirnov@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-5-git-send-email-andrew.smirnov@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/638513/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/638513/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<rtc-linux+bncBDKOBWPM5ABRBWGWUO5QKGQETQLV2YI@googlegroups.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from mail-qk0-x23c.google.com (mail-qk0-x23c.google.com\n\t[IPv6:2607:f8b0:400d:c09::23c])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYfMZ26TFz9t0S\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 17:23:06 +1000 (AEST)", "by mail-qk0-x23c.google.com with SMTP id r68sf3112737qka.1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 00:23:06 -0700 (PDT)", "by 10.36.141.193 with SMTP id w184ls147029itd.2.gmail; Tue, 21 Jun\n\t2016 00:23:04 -0700 (PDT)", "from mail-pf0-x243.google.com (mail-pf0-x243.google.com.\n\t[2607:f8b0:400e:c00::243]) by gmr-mx.google.com with ESMTPS id\n\t62si7279324pfx.1.2016.06.21.00.23.04\n\tfor <rtc-linux@googlegroups.com>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:04 -0700 (PDT)", "by mail-pf0-x243.google.com with SMTP id i123so755736pfg.3\n\tfor <rtc-linux@googlegroups.com>;\n\tTue, 21 Jun 2016 00:23:04 -0700 (PDT)", "from squirtle.localdomain.localdomain\n\t(c-73-225-163-254.hsd1.wa.comcast.net. [73.225.163.254])\n\tby smtp.gmail.com with ESMTPSA id\n\tp187sm19452396pfg.67.2016.06.21.00.23.03\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:03 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=P9CGGXoj; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=CRy4CSDE;\n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=xyruHVub7n2SchNZARHfBXErjfGS6OA7hyQREe8jr/o=;\n\tb=P9CGGXojaG59kJgIqo/pS2UbbaOnhLhiukKdspaiBLJX53SkdDfOo/PKCNNodDA2dz\n\tPNf9oRiNSA04oF0MG78nqlyt/ar9kmZGLuxJoyN6GOeHkBZ/fET+MnOnA46wEOp/qSGd\n\tBbTzCORDNMz+UiquWacUsyMesZMI67JcOoJbdGd7fRRtIxT+VDJOhTp6+Xt0dr1RySBL\n\tQ0p+d+uYG6okvq6fSb7RCMP/vK8Aq/Ys3U4GXMIaB+PW2B/nL+Aw4SeLe4vjomGqkzy5\n\t7NhL3bRWnLALsERRk5WuymqcL4rYR2xFoPynYgpwI66Lrq7km5+FFisfFjCjt1EX4lrW\n\tBFDQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20120113;\n\th=mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=xyruHVub7n2SchNZARHfBXErjfGS6OA7hyQREe8jr/o=;\n\tb=CRy4CSDE05suuplLPAqvPWWSD/T1Cp+ZzNS9xkxS54vbQ62HBlRN+ZSiZyDxjrY8Qo\n\tfm1CD8jqLxNG9zQZ/tNnIWeB+WGt0HDwIm9yon92LNZB67V+cYmpQk5AVnZajgzpxcwL\n\tFuP74IkEabS2Oww0eNXqLFuiKT8X3BYtEpSAX7Ws8Lq+J41v2ZP1Z7wjnRbwz6fmoa2x\n\tVRUY2Ktvx2D0VEEv4dAJDIJfuQEB491SJ5gvn8590XrEcYEn2bIM9m42VJFnxDn+Ujts\n\t9XiSbwIZgvLeKxExQK7zjI6tl0bxv9pe9r9mSoqtiRwVZdfbs5IbSJ00glh62SXypusY\n\tMvOQ==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:in-reply-to:references:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=xyruHVub7n2SchNZARHfBXErjfGS6OA7hyQREe8jr/o=;\n\tb=WyjWXSMmF0nndVuPIJHQbIoehBcSfu8mF8Tsnu2vPslPH3Sptkqgeqg+RE+fC1Fq8u\n\t2c/VEGs7exdkCFjUDEcr7GOyEw5fyy8LTU03G4knk5953+Onvc7rOVnffC4dDXA965tS\n\tLtwpHzE3j0YNOieTSjWSe//OH6Fm/U7WlF3tM1EOMT9tgrvTetd1uDrJoQHPH7i/DF6A\n\tvCAPMUF/2m0W47ekqV9G5Xvh0Ug/MX2qdmq3Tl6fcpQIBG1wtWELeWjvI6G1/50MgWj3\n\tYb7E9jNfLcdIzGR2QDCFeqsFGlIVvGX+G5pNxCw3ZtdUv9CoXGhZKhJHFCHcvkItw8cE\n\t//Dg==", "Sender": "rtc-linux@googlegroups.com", "X-Gm-Message-State": "ALyK8tJzuT3g5RTJOwg4+QEBJI2tExgbFjjNRJToFzVrkNjFxpo5sszeXI/N5aJFxYaA+w==", "X-Received": [ "by 10.36.105.74 with SMTP id e71mr31511itc.5.1466493784400;\n\tTue, 21 Jun 2016 00:23:04 -0700 (PDT)", "by 10.36.239.196 with SMTP id i187mr1901600ith.6.1466493784136; \n\tTue, 21 Jun 2016 00:23:04 -0700 (PDT)", "by 10.98.5.2 with SMTP id 2mr13228796pff.58.1466493783875;\n\tTue, 21 Jun 2016 00:23:03 -0700 (PDT)" ], "MIME-Version": "1.0", "X-BeenThere": "rtc-linux@googlegroups.com", "Received-SPF": "pass (google.com: domain of andrew.smirnov@gmail.com\n\tdesignates 2607:f8b0:400e:c00::243 as permitted sender)\n\tclient-ip=2607:f8b0:400e:c00::243; ", "From": "Andrey Smirnov <andrew.smirnov@gmail.com>", "To": "rtc-linux@googlegroups.com", "Cc": "Andrey Smirnov <andrew.smirnov@gmail.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tlinux-kernel@vger.kernel.org, cphealy@gmail.com", "Subject": "[rtc-linux] [PATCH v2 06/17] RTC: ds1307: Convert want_irq into a\n\tpredicate", "Date": "Tue, 21 Jun 2016 00:22:39 -0700", "Message-Id": "<1466493770-11895-5-git-send-email-andrew.smirnov@gmail.com>", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>", "References": "<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>", "X-Original-Sender": "andrew.smirnov@gmail.com", "X-Original-Authentication-Results": "gmr-mx.google.com; dkim=pass\n\theader.i=@gmail.com; spf=pass (google.com: domain of\n\tandrew.smirnov@gmail.com designates 2607:f8b0:400e:c00::243 as\n\tpermitted\n\tsender) smtp.mailfrom=andrew.smirnov@gmail.com; dmarc=pass (p=NONE\n\tdis=NONE) header.from=gmail.com", "Reply-To": "rtc-linux@googlegroups.com", "Content-Type": "text/plain; charset=UTF-8", "Precedence": "list", "Mailing-list": "list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com", "List-ID": "<rtc-linux.googlegroups.com>", "X-Spam-Checked-In-Group": "rtc-linux@googlegroups.com", "X-Google-Group-Id": "712029733259", "List-Post": "<https://groups.google.com/group/rtc-linux/post>,\n\t<mailto:rtc-linux@googlegroups.com>", "List-Help": "<https://groups.google.com/support/>,\n\t<mailto:rtc-linux+help@googlegroups.com>", "List-Archive": "<https://groups.google.com/group/rtc-linux", "List-Subscribe": "<https://groups.google.com/group/rtc-linux/subscribe>,\n\t<mailto:rtc-linux+subscribe@googlegroups.com>", "List-Unsubscribe": "<mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com>,\n\t<https://groups.google.com/group/rtc-linux/subscribe>" }, "content": "Convert want_irq variable into a predicate in order to detangle various\nindependent chunks of ds1307_probe().\n\nSigned-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>\n---\n drivers/rtc/rtc-ds1307.c | 44 +++++++++++++++++++++++++++++---------------\n 1 file changed, 29 insertions(+), 15 deletions(-)", "diff": "diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\nindex 98e1f81..ccfaba4 100644\n--- a/drivers/rtc/rtc-ds1307.c\n+++ b/drivers/rtc/rtc-ds1307.c\n@@ -1247,6 +1247,30 @@ static bool ds1307_can_wakeup_device(const struct ds1307 *ds1307)\n \t\t\t\t \"wakeup-source\");\n }\n \n+static bool ds1307_want_irq(const struct ds1307 *ds1307,\n+\t\t\t const struct chip_desc *chip)\n+{\n+\n+\n+\tif (chip->alarm) {\n+\t\tswitch (ds1307->type) {\n+\t\tcase ds_1337:\n+\t\tcase ds_1339:\n+\t\tcase ds_3231:\n+\t\tcase ds_1341:\n+\t\t\treturn (ds1307->client->irq > 0 ||\n+\t\t\t\tds1307_can_wakeup_device(ds1307));\n+\n+\t\tcase mcp794xx:\n+\t\t\treturn (ds1307->client->irq > 0);\n+\t\tdefault:\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\treturn false;\n+}\n+\n static int ds1307_probe(struct i2c_client *client,\n \t\t\tconst struct i2c_device_id *id)\n {\n@@ -1255,7 +1279,6 @@ static int ds1307_probe(struct i2c_client *client,\n \tint\t\t\ttmp;\n \tstruct chip_desc\t*chip = &chips[id->driver_data];\n \tstruct i2c_adapter\t*adapter = to_i2c_adapter(client->dev.parent);\n-\tbool\t\t\twant_irq = false;\n \tunsigned char\t\t*buf;\n \tstruct ds1307_platform_data *pdata = dev_get_platdata(&client->dev);\n \tirq_handler_t\tirq_handler = ds1307_irq;\n@@ -1356,10 +1379,6 @@ static int ds1307_probe(struct i2c_client *client,\n \t\t\t| bbsqi_bitpos[ds1307->type];\n \t\tds1307->regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);\n \n-\t\tif (chip->alarm && (ds1307->client->irq > 0 ||\n-\t\t\t\t ds1307_can_wakeup_device(ds1307)))\n-\t\t\twant_irq = true;\n-\n \t\ti2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,\n \t\t\t\t\t\t\tds1307->regs[0]);\n \n@@ -1441,10 +1460,7 @@ static int ds1307_probe(struct i2c_client *client,\n \t\tbreak;\n \tcase mcp794xx:\n \t\trtc_ops = &mcp794xx_rtc_ops;\n-\t\tif (ds1307->client->irq > 0 && chip->alarm) {\n-\t\t\tirq_handler = mcp794xx_irq;\n-\t\t\twant_irq = true;\n-\t\t}\n+\t\tirq_handler = mcp794xx_irq;\n \t\tbreak;\n \tdefault:\n \t\tbreak;\n@@ -1557,7 +1573,7 @@ read_rtc:\n \t\t\t\tbin2bcd(tmp));\n \t}\n \n-\tif (want_irq) {\n+\tif (ds1307_want_irq(ds1307, chip)) {\n \t\tdevice_set_wakeup_capable(&client->dev, true);\n \t\tset_bit(HAS_ALARM, &ds1307->flags);\n \t}\n@@ -1570,13 +1586,11 @@ read_rtc:\n \tif (ds1307_can_wakeup_device(ds1307) &&\n \t ds1307->client->irq <= 0) {\n \t\t/* Disable request for an IRQ */\n-\t\twant_irq = false;\n-\t\tdev_info(&client->dev, \"'wakeup-source' is set, request for an IRQ is disabled!\\n\");\n+\t\tdev_info(&client->dev,\n+\t\t\t \"'wakeup-source' is set, request for an IRQ is disabled!\\n\");\n \t\t/* We cannot support UIE mode if we do not have an IRQ line */\n \t\tds1307->rtc->uie_unsupported = 1;\n-\t}\n-\n-\tif (want_irq) {\n+\t} else if (ds1307_want_irq(ds1307, chip)) {\n \t\terr = devm_request_threaded_irq(&client->dev,\n \t\t\t\t\t\tclient->irq, NULL, irq_handler,\n \t\t\t\t\t\tIRQF_SHARED | IRQF_ONESHOT,\n", "prefixes": [ "v2", "06/17" ] }