Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/638512/?format=api
{ "id": 638512, "url": "http://patchwork.ozlabs.org/api/patches/638512/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-3-git-send-email-andrew.smirnov@gmail.com/", "project": { "id": 9, "url": "http://patchwork.ozlabs.org/api/projects/9/?format=api", "name": "Linux RTC development", "link_name": "rtc-linux", "list_id": "linux-rtc.vger.kernel.org", "list_email": "linux-rtc@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1466493770-11895-3-git-send-email-andrew.smirnov@gmail.com>", "list_archive_url": null, "date": "2016-06-21T07:22:37", "name": "[v2,04/17] RTC: ds1307: Add DS1341 specific power-saving options", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "0c0605f7210e72d130594aca29211f909271c3fa", "submitter": { "id": 67013, "url": "http://patchwork.ozlabs.org/api/people/67013/?format=api", "name": "Andrey Smirnov", "email": "andrew.smirnov@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-3-git-send-email-andrew.smirnov@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/638512/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/638512/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<rtc-linux+bncBDKOBWPM5ABRBVWWUO5QKGQE3S7YQGI@googlegroups.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from mail-vk0-x23c.google.com (mail-vk0-x23c.google.com\n\t[IPv6:2607:f8b0:400c:c05::23c])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYfMY1Zhvz9t0S\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 17:23:05 +1000 (AEST)", "by mail-vk0-x23c.google.com with SMTP id c127sf2927678vkb.0\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 00:23:05 -0700 (PDT)", "by 10.107.13.129 with SMTP id 123ls1786103ion.105.gmail;\n\tTue, 21 Jun 2016 00:23:02 -0700 (PDT)", "from mail-pf0-x243.google.com (mail-pf0-x243.google.com.\n\t[2607:f8b0:400e:c00::243]) by gmr-mx.google.com with ESMTPS id\n\t62si7279324pfx.1.2016.06.21.00.23.02\n\tfor <rtc-linux@googlegroups.com>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:02 -0700 (PDT)", "by mail-pf0-x243.google.com with SMTP id i123so755736pfg.3\n\tfor <rtc-linux@googlegroups.com>;\n\tTue, 21 Jun 2016 00:23:02 -0700 (PDT)", "from squirtle.localdomain.localdomain\n\t(c-73-225-163-254.hsd1.wa.comcast.net. [73.225.163.254])\n\tby smtp.gmail.com with ESMTPSA id\n\tp187sm19452396pfg.67.2016.06.21.00.23.01\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:01 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=sTEV3Abp; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=LMm5/HHX;\n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=DfFMkvr0mAZapM+aPtLgXSxVPSUqjVQgcRLWatXwaSs=;\n\tb=sTEV3AbpJ+ppMyoxKqLEWNtXYqEzci9/uzTj7FdM36+8LtvtkTkE7bmpO6RJkhNcnG\n\tN+hWOwPwK3nPtQEbAUh356kraI/QK1UuBgnJZZKFptO83HOkMFGVTKKvXt6a5ZDvJKV1\n\tR5TQhwqSPryZDct/nPMl5r4gsrZ6JdcxXmdJqmXWrbkn/N/hHmaPk/DskJdLUj2A2H2d\n\tQZ9xRZEK1EdhUccQ91WSSgiUwMip82qcM8bk5IGTqHxsIiWnOScW8sd4J1I7P5yvk7hu\n\tF3hCYnI7xxm2o1+Fc7Fzde+z/k2v6vts2bt33jcsoSZh7OHA78XvX0W0+xqpmzn72ght\n\t45Jg==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20120113;\n\th=mime-version:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=DfFMkvr0mAZapM+aPtLgXSxVPSUqjVQgcRLWatXwaSs=;\n\tb=LMm5/HHXtsnhAj7N30GA4lIN7fRtiIG0gs/GmJ80Suw9P5qVul9g2ogWoaZdcn8TqR\n\twPEWsGcfBkDvIEPeFvtPMyVPOhkpA3eKAl2fgArezlQN6KMLqDmpZjTYNnWnW0/3FcSg\n\twtVfHTfuNbDCU2Uzpx84yBRy2U7Pw4UBdNQnzhAyUTxxACReby4/YsKl79UxgSovqvrV\n\tGqsnTqNjgmBYOJJw0yTpKooVFef5ZhGZBUPmsvNc0nhnDDNBCOHwJ3QVmDoaXXMyaD8N\n\tRy3+M/p9xwxc1RdYzDAWYHawI16odNKqvzm95wWKrGkiFlMLmwTXnDF20kmQV0uuMpG0\n\tb6Dw==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:in-reply-to:references:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=DfFMkvr0mAZapM+aPtLgXSxVPSUqjVQgcRLWatXwaSs=;\n\tb=ArQZe9UcB3RAibFrbn0dJrnHLsC/V0ST+PyGui9Ndc1knlJ1tqd4vJVVdyQNVc//Y7\n\tdp8/L6nbEI7nkx1dndRFW4QUAsND3bweufAnqGwROGY8QYynBiCnboFmjl/7byuCteNs\n\tuNRPYUZPYGpXDkeEPA/ws50TaUNqYWpFMGWooJq85l2s5xE18ofzV7RYbS7z2QBwtNMF\n\tAtRn7t4wiI427DxclvVUrT9aUlb6Zf0u24JNk8JACbZVga6rWyNCnWqSfY+xwPGRCxRm\n\t/uB4xQ21iDCs5hIHH/TzuwF/EQmTUhpBBIwsRXvBSgchrbcStn0sLGGCqBcuhjp6k9P5\n\t0N7g==", "Sender": "rtc-linux@googlegroups.com", "X-Gm-Message-State": "ALyK8tKU/aQ0Chic0OqCpLwrPXOiJXn1VHWqU/yzqMT6Z7y+ArLNEpEcTwUvFOiFm2r7Tw==", "X-Received": [ "by 10.36.230.69 with SMTP id e66mr33486ith.0.1466493782841;\n\tTue, 21 Jun 2016 00:23:02 -0700 (PDT)", "by 10.107.182.139 with SMTP id g133mr6674535iof.28.1466493782573;\n\tTue, 21 Jun 2016 00:23:02 -0700 (PDT)", "by 10.98.18.131 with SMTP id 3mr26752480pfs.102.1466493782335;\n\tTue, 21 Jun 2016 00:23:02 -0700 (PDT)" ], "MIME-Version": "1.0", "X-BeenThere": "rtc-linux@googlegroups.com", "Received-SPF": "pass (google.com: domain of andrew.smirnov@gmail.com\n\tdesignates 2607:f8b0:400e:c00::243 as permitted sender)\n\tclient-ip=2607:f8b0:400e:c00::243; ", "From": "Andrey Smirnov <andrew.smirnov@gmail.com>", "To": "rtc-linux@googlegroups.com", "Cc": "Andrey Smirnov <andrew.smirnov@gmail.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tlinux-kernel@vger.kernel.org, cphealy@gmail.com", "Subject": "[rtc-linux] [PATCH v2 04/17] RTC: ds1307: Add DS1341 specific\n\tpower-saving options", "Date": "Tue, 21 Jun 2016 00:22:37 -0700", "Message-Id": "<1466493770-11895-3-git-send-email-andrew.smirnov@gmail.com>", "X-Mailer": "git-send-email 2.5.5", "In-Reply-To": "<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>", "References": "<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>", "X-Original-Sender": "andrew.smirnov@gmail.com", "X-Original-Authentication-Results": "gmr-mx.google.com; dkim=pass\n\theader.i=@gmail.com; spf=pass (google.com: domain of\n\tandrew.smirnov@gmail.com designates 2607:f8b0:400e:c00::243 as\n\tpermitted\n\tsender) smtp.mailfrom=andrew.smirnov@gmail.com; dmarc=pass (p=NONE\n\tdis=NONE) header.from=gmail.com", "Reply-To": "rtc-linux@googlegroups.com", "Content-Type": "text/plain; charset=UTF-8", "Precedence": "list", "Mailing-list": "list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com", "List-ID": "<rtc-linux.googlegroups.com>", "X-Spam-Checked-In-Group": "rtc-linux@googlegroups.com", "X-Google-Group-Id": "712029733259", "List-Post": "<https://groups.google.com/group/rtc-linux/post>,\n\t<mailto:rtc-linux@googlegroups.com>", "List-Help": "<https://groups.google.com/support/>,\n\t<mailto:rtc-linux+help@googlegroups.com>", "List-Archive": "<https://groups.google.com/group/rtc-linux", "List-Subscribe": "<https://groups.google.com/group/rtc-linux/subscribe>,\n\t<mailto:rtc-linux+subscribe@googlegroups.com>", "List-Unsubscribe": "<mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com>,\n\t<https://groups.google.com/group/rtc-linux/subscribe>" }, "content": "Add DS1341 specific power-saving options that allow to disable certain\nfunctional aspects of the chip in order to minimize its power\nconsumption.\n\nSigned-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>\n---\n drivers/rtc/rtc-ds1307.c | 28 ++++++++++++++++++++++++++++\n 1 file changed, 28 insertions(+)", "diff": "diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\nindex c618c22..b21ea5d 100644\n--- a/drivers/rtc/rtc-ds1307.c\n+++ b/drivers/rtc/rtc-ds1307.c\n@@ -78,6 +78,7 @@ enum ds_type {\n #define DS1337_REG_CONTROL\t0x0e\n #\tdefine DS1337_BIT_nEOSC\t\t0x80\n #\tdefine DS1339_BIT_BBSQI\t\t0x20\n+#\tdefine DS1341_BIT_EGFIL\t\t0x20\n #\tdefine DS3231_BIT_BBSQW\t\t0x40 /* same as BBSQI */\n #\tdefine DS1337_BIT_RS2\t\t0x10\n #\tdefine DS1337_BIT_RS1\t\t0x08\n@@ -93,7 +94,9 @@ enum ds_type {\n #\tdefine DS1340_BIT_OSF\t\t0x80\n #define DS1337_REG_STATUS\t0x0f\n #\tdefine DS1337_BIT_OSF\t\t0x80\n+#\tdefine DS1341_BIT_DOSF\t\t0x40\n #\tdefine DS3231_BIT_EN32KHZ\t0x08\n+#\tdefine DS1341_BIT_ECLK\t\t0x04\n #\tdefine DS1337_BIT_A2I\t\t0x02\n #\tdefine DS1337_BIT_A1I\t\t0x01\n #define DS1339_REG_ALARM1_SECS\t0x07\n@@ -1319,6 +1322,31 @@ static int ds1307_probe(struct i2c_client *client,\n \t\tif (ds1307->regs[0] & DS1337_BIT_nEOSC)\n \t\t\tds1307->regs[0] &= ~DS1337_BIT_nEOSC;\n \n+\t\tif (ds1307->type == ds_1341) {\n+\t\t\t/* Make sure we are not generating square wave\n+\t\t\t * output */\n+\t\t\tds1307->regs[1] &= ~DS1341_BIT_ECLK;\n+\n+\t\t\tif (of_property_read_bool(client->dev.of_node,\n+\t\t\t\t\t\t \"dallas,disable-oscillator-stop-flag\"))\n+\t\t\t\tds1307->regs[1] |= DS1341_BIT_DOSF;\n+\t\t\telse\n+\t\t\t\tds1307->regs[1] &= ~DS1341_BIT_DOSF;\n+\n+\t\t\tif (of_property_read_bool(client->dev.of_node,\n+\t\t\t\t\t\t \"dallas,enable-glitch-filter\"))\n+\t\t\t\tds1307->regs[0] |= DS1341_BIT_EGFIL;\n+\t\t\telse\n+\t\t\t\tds1307->regs[0] &= ~DS1341_BIT_EGFIL;\n+\n+\t\t\t/*\n+\t\t\t * Write status register. Control register\n+\t\t\t * would be set by the code below\n+\t\t\t */\n+\t\t\ti2c_smbus_write_byte_data(client, DS1337_REG_STATUS,\n+\t\t\t\t\t\t ds1307->regs[1]);\n+\t\t}\n+\n \t\t/*\n \t\t * Disable the square wave and both alarms.\n \t\t * For some variants, be sure alarms can trigger when we're\n", "prefixes": [ "v2", "04/17" ] }