Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/638509/?format=api
{ "id": 638509, "url": "http://patchwork.ozlabs.org/api/patches/638509/?format=api", "web_url": "http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com/", "project": { "id": 9, "url": "http://patchwork.ozlabs.org/api/projects/9/?format=api", "name": "Linux RTC development", "link_name": "rtc-linux", "list_id": "linux-rtc.vger.kernel.org", "list_email": "linux-rtc@vger.kernel.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>", "list_archive_url": null, "date": "2016-06-21T07:22:35", "name": "[v2,02/17] RTC: ds1307: Disable square wave and timers as default", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "9669fd5f820104f3f32f2a0934d1db08b26daf49", "submitter": { "id": 67013, "url": "http://patchwork.ozlabs.org/api/people/67013/?format=api", "name": "Andrey Smirnov", "email": "andrew.smirnov@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/rtc-linux/patch/1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/638509/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/638509/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<rtc-linux+bncBDKOBWPM5ABRBVGWUO5QKGQEZVTCF6Q@googlegroups.com>", "X-Original-To": "incoming@patchwork.ozlabs.org", "Delivered-To": "patchwork-incoming@bilbo.ozlabs.org", "Received": [ "from mail-qk0-x23b.google.com (mail-qk0-x23b.google.com\n\t[IPv6:2607:f8b0:400d:c09::23b])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYfMV2xkTz9t0S\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 17:23:02 +1000 (AEST)", "by mail-qk0-x23b.google.com with SMTP id r68sf3112201qka.1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 00:23:02 -0700 (PDT)", "by 10.157.12.39 with SMTP id 36ls3906888otr.75.gmail; Tue, 21 Jun\n\t2016 00:23:00 -0700 (PDT)", "from mail-pf0-x241.google.com (mail-pf0-x241.google.com.\n\t[2607:f8b0:400e:c00::241]) by gmr-mx.google.com with ESMTPS id\n\tpo17si907962pab.2.2016.06.21.00.23.00\n\tfor <rtc-linux@googlegroups.com>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:23:00 -0700 (PDT)", "by mail-pf0-x241.google.com with SMTP id t190so762020pfb.2\n\tfor <rtc-linux@googlegroups.com>;\n\tTue, 21 Jun 2016 00:23:00 -0700 (PDT)", "from squirtle.localdomain.localdomain\n\t(c-73-225-163-254.hsd1.wa.comcast.net. [73.225.163.254])\n\tby smtp.gmail.com with ESMTPSA id\n\tp187sm19452396pfg.67.2016.06.21.00.22.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 21 Jun 2016 00:22:59 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=cmtKWJre; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=r/up1te/;\n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20120806;\n\th=sender:mime-version:from:to:cc:subject:date:message-id\n\t:x-original-sender:x-original-authentication-results:reply-to\n\t:precedence:mailing-list:list-id:x-spam-checked-in-group:list-post\n\t:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=dI9xQmTTYjFtOMonqlAGIaWSyz+44P4/FJjZkTLV7d4=;\n\tb=cmtKWJreS104tgg1dafsPQlqjopd9aPSbJNx/ivTur1SyTqGQfbq1LiOuWHsB+KQ5X\n\ttRq3FGTTwAgnMJILgx6E5BDQ2v/v8tkl4LMtM6QMWLyzAHOAdB0hLy9mujXt+2tHKC9X\n\tA/Wg3qflV8OZszS6+kXEeGpPUlbcpudeGFF2/p3q8WVhfuFobZj8DSgAQo0dJNUuccuI\n\ti1qXwdWOIadpSGQDmMeWAypbSspxbAlsziK6JILNexh+5Ib1F3sEinSAiwrx+yzw/UV2\n\tcwA4wQ6aIPKQMHWUhnKNqmKBfinheXElz3QESGvmFg0DNt+Na7q7v4Sh9W3azY7/FATg\n\tPiRQ==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20120113;\n\th=mime-version:from:to:cc:subject:date:message-id:x-original-sender\n\t:x-original-authentication-results:reply-to:precedence:mailing-list\n\t:list-id:x-spam-checked-in-group:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=dI9xQmTTYjFtOMonqlAGIaWSyz+44P4/FJjZkTLV7d4=;\n\tb=r/up1te/dJODcpghS+FpnNFP6sanaZzdpyPvx3L0+s+jqX6s2CNRZQ9KQ7DRpKz5r3\n\ty1e30rj5RE2ycSL4Gw7SJS1IrekodvWiL/ELSDbo/uvgV4PSdvJKmHGRH6cKBeT5Iz8c\n\tZbPME17fZo9zYQlRfyQB7m4U0MSQvrLWIryL3cwATKy43kNEQ0FmazFvbxOSyu/uMXls\n\tD9tmYD7WcxyCLCmS5SpLEOmi3VXZY5x1XiQxkeOCqmIkYYdmJTTMq3SLAOB0aM+AU+Js\n\tBl3ohH53kBKQazzEPZV3FJSieGoFqIQZV9zl2Hhv2Qg/kl7BlN0hEsm3AJUGlF0dD4k+\n\tH3cQ==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:x-original-sender:x-original-authentication-results\n\t:reply-to:precedence:mailing-list:list-id:x-spam-checked-in-group\n\t:list-post:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=dI9xQmTTYjFtOMonqlAGIaWSyz+44P4/FJjZkTLV7d4=;\n\tb=Eiw81koQttSvcGZtHubhenr+QARv0KrA/rxKIMSucBu+uTvCp0BmJre4MjqmfNMbpG\n\toO+d/4ib4X/EnlVQKsb7gkIdtLg4cNOi6ZTx8NcwWQb4lFAuDsuym3twLQqmniQoHFyB\n\t22IScDGG43R14SiPV48QuCyAhJiEuXEzIaGKlClCFOYeLdauJT6TWbdia3jZPx+TsmO5\n\tpHfp2qPc7O2ozfe35Evt1K9NoJ21T3CJzCc9VVVAzhkrO0rZHFmLD/Bm3Y2Wo7fyTXdE\n\tgHchdfsJG2mYmrKnAmp6NrIN3MEntKGfRrHYauxVB433Lgyny76KOGx5M8w1P9gwxpH/\n\t8j6A==", "Sender": "rtc-linux@googlegroups.com", "X-Gm-Message-State": "ALyK8tJt8uZYtoFAXyrjVloe/FjA8ohUAhe6D9Xam9ySLdwWfFkAWQ8EXjcjqxo8B9ZuGA==", "X-Received": [ "by 10.157.39.133 with SMTP id c5mr605207otb.6.1466493780496;\n\tTue, 21 Jun 2016 00:23:00 -0700 (PDT)", "by 10.157.33.27 with SMTP id i27mr22134335otb.11.1466493780253; \n\tTue, 21 Jun 2016 00:23:00 -0700 (PDT)", "by 10.98.75.146 with SMTP id d18mr26292060pfj.19.1466493779997; \n\tTue, 21 Jun 2016 00:22:59 -0700 (PDT)" ], "MIME-Version": "1.0", "X-BeenThere": "rtc-linux@googlegroups.com", "Received-SPF": "pass (google.com: domain of andrew.smirnov@gmail.com\n\tdesignates 2607:f8b0:400e:c00::241 as permitted sender)\n\tclient-ip=2607:f8b0:400e:c00::241; ", "From": "Andrey Smirnov <andrew.smirnov@gmail.com>", "To": "rtc-linux@googlegroups.com", "Cc": "Andrey Smirnov <andrew.smirnov@gmail.com>,\n\tAlessandro Zummo <a.zummo@towertech.it>,\n\tAlexandre Belloni <alexandre.belloni@free-electrons.com>,\n\tlinux-kernel@vger.kernel.org, cphealy@gmail.com", "Subject": "[rtc-linux] [PATCH v2 02/17] RTC: ds1307: Disable square wave and\n\ttimers as default", "Date": "Tue, 21 Jun 2016 00:22:35 -0700", "Message-Id": "<1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>", "X-Mailer": "git-send-email 2.5.5", "X-Original-Sender": "andrew.smirnov@gmail.com", "X-Original-Authentication-Results": "gmr-mx.google.com; dkim=pass\n\theader.i=@gmail.com; spf=pass (google.com: domain of\n\tandrew.smirnov@gmail.com designates 2607:f8b0:400e:c00::241 as\n\tpermitted\n\tsender) smtp.mailfrom=andrew.smirnov@gmail.com; dmarc=pass (p=NONE\n\tdis=NONE) header.from=gmail.com", "Reply-To": "rtc-linux@googlegroups.com", "Content-Type": "text/plain; charset=UTF-8", "Precedence": "list", "Mailing-list": "list rtc-linux@googlegroups.com;\n\tcontact rtc-linux+owners@googlegroups.com", "List-ID": "<rtc-linux.googlegroups.com>", "X-Spam-Checked-In-Group": "rtc-linux@googlegroups.com", "X-Google-Group-Id": "712029733259", "List-Post": "<https://groups.google.com/group/rtc-linux/post>,\n\t<mailto:rtc-linux@googlegroups.com>", "List-Help": "<https://groups.google.com/support/>,\n\t<mailto:rtc-linux+help@googlegroups.com>", "List-Archive": "<https://groups.google.com/group/rtc-linux", "List-Subscribe": "<https://groups.google.com/group/rtc-linux/subscribe>,\n\t<mailto:rtc-linux+subscribe@googlegroups.com>", "List-Unsubscribe": "<mailto:googlegroups-manage+712029733259+unsubscribe@googlegroups.com>,\n\t<https://groups.google.com/group/rtc-linux/subscribe>" }, "content": "Disable square wave and timers as default for DS1337/39/41 and\nDS3231. The rationale being that configuring a chip this way puts it\ninto a known state with lower power consumption. While it is not very\nlikely it is still possible that the code controlling RTCs that ran\nbefore this driver configured it to produce square wave and left it in\nsuch a state.\n\nSigned-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>\n---\n drivers/rtc/rtc-ds1307.c | 12 +++++-------\n 1 file changed, 5 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c\nindex 7e65e2e..c618c22 100644\n--- a/drivers/rtc/rtc-ds1307.c\n+++ b/drivers/rtc/rtc-ds1307.c\n@@ -1320,19 +1320,17 @@ static int ds1307_probe(struct i2c_client *client,\n \t\t\tds1307->regs[0] &= ~DS1337_BIT_nEOSC;\n \n \t\t/*\n-\t\t * Using IRQ or defined as wakeup-source?\n \t\t * Disable the square wave and both alarms.\n \t\t * For some variants, be sure alarms can trigger when we're\n \t\t * running on Vbackup (BBSQI/BBSQW)\n \t\t */\n-\t\tif (chip->alarm && (ds1307->client->irq > 0 ||\n-\t\t\t\t\t\tds1307_can_wakeup_device)) {\n-\t\t\tds1307->regs[0] |= DS1337_BIT_INTCN\n-\t\t\t\t\t| bbsqi_bitpos[ds1307->type];\n-\t\t\tds1307->regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);\n+\t\tds1307->regs[0] |= DS1337_BIT_INTCN\n+\t\t\t| bbsqi_bitpos[ds1307->type];\n+\t\tds1307->regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);\n \n+\t\tif (chip->alarm && (ds1307->client->irq > 0 ||\n+\t\t\t\t ds1307_can_wakeup_device))\n \t\t\twant_irq = true;\n-\t\t}\n \n \t\ti2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,\n \t\t\t\t\t\t\tds1307->regs[0]);\n", "prefixes": [ "v2", "02/17" ] }