Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/638180/?format=api
{ "id": 638180, "url": "http://patchwork.ozlabs.org/api/patches/638180/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160620173933.5638-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160620173933.5638-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-06-20T17:39:32", "name": "[1/2] fm10k: napi polling routine must return actual work done", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0f2b4d9d98985c25eaa1d6677a54c56e17a14ee0", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160620173933.5638-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/638180/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/638180/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYJ5W5RDRz9t18\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 03:39:43 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id EE75287741;\n\tMon, 20 Jun 2016 17:39:41 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id EH8EhYDGVCeq; Mon, 20 Jun 2016 17:39:41 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 4FF898868E;\n\tMon, 20 Jun 2016 17:39:41 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 535051C0E4E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 17:39:39 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 49FF98B1F1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 17:39:39 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id LMuQZc1Eri0n for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 17:39:38 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6998F87F8A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 17:39:38 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga103.jf.intel.com with ESMTP; 20 Jun 2016 10:39:37 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.116])\n\tby fmsmga002.fm.intel.com with ESMTP; 20 Jun 2016 10:39:37 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos; i=\"5.26,499,1459839600\"; d=\"scan'208\";\n\ta=\"1006059784\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Mon, 20 Jun 2016 10:39:32 -0700", "Message-Id": "<20160620173933.5638-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.9.0.rc1.405.g81f467e", "Cc": "Paolo Abeni <pabeni@redhat.com>, Alexander Duyck <aduyck@mirantis.com>, \n\tVenkatesh Srinivas <venkateshs@google.com>", "Subject": "[Intel-wired-lan] [PATCH 1/2] fm10k: napi polling routine must\n\treturn actual work done", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When fm10k_poll fully cleans rings it returns 0. This is incorrect as it\nmesses up the budget accounting in the core napi code. Fix this by\nreturning actual work done, capped at budget - 1 since the core doesn't\nexpect a return of the full budget when the driver modifies the napi\nstatus.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\nCc: Paolo Abeni <pabeni@redhat.com>\nCc: Venkatesh Srinivas <venkateshs@google.com>\nCc: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 682a372bdb20..79d5093d83d1 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -1484,7 +1484,7 @@ static int fm10k_poll(struct napi_struct *napi, int budget)\n \t/* re-enable the q_vector */\n \tfm10k_qv_enable(q_vector);\n \n-\treturn 0;\n+\treturn min(work_done, budget - 1);\n }\n \n /**\n", "prefixes": [ "1/2" ] }