Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/638104/?format=api
{ "id": 638104, "url": "http://patchwork.ozlabs.org/api/patches/638104/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1466439039-16378-3-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1466439039-16378-3-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-06-20T16:10:34", "name": "[next,PTACH,S38-v2,2/7] i40e: enable VSI broadcast promiscuous mode instead of adding broadcast filter", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "752e373d902cda660af884e5e41250c0dd8c6532", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1466439039-16378-3-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/638104/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/638104/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYG6b5yyLz9s9r\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 02:10:31 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 6A58B8669A;\n\tMon, 20 Jun 2016 16:10:30 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id zOWUN71JWl1h; Mon, 20 Jun 2016 16:10:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 335F7887FB;\n\tMon, 20 Jun 2016 16:10:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id C24121C09EB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5BA748AF69\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:10 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4+fLlwAX6QY5 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:08 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4C7408AFF0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:08 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 20 Jun 2016 09:10:07 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby fmsmga001.fm.intel.com with ESMTP; 20 Jun 2016 09:10:07 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,499,1459839600\"; d=\"scan'208\";a=\"991493101\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 20 Jun 2016 09:10:34 -0700", "Message-Id": "<1466439039-16378-3-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1466439039-16378-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1466439039-16378-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PTACH S38-v2 2/7] i40e: enable VSI\n\tbroadcast promiscuous mode instead of adding broadcast filter", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Kiran Patil <kiran.patil@intel.com>\n\nThis patch sets VSI brodcast promiscuous mode during VSI add sequence\nand prevents adding MAC filter if specified MAC address is broadcast.\n\nSigned-off-by: Kiran Patil <kiran.patil@intel.com>\nChange-ID: Ia62251fca095bc449d0497fc44bec3a5a0136773\n---\nTesting Hints :\n1. Bring up network interface, assign IP address.\n2. Make sure it can ping to link partner.\nThis proves that ARP request are processed correctly due to VSI\nbroadcast promiscuous mode even though MAC filter for broadcast\naddress is not programmed.\n\nLikewise tried the test case mentioned in HSD where source MAC is\nbroadcast and those packets are getting forwarded to one of the\nrx-queue.\n\nHSD-number: 7661069\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 32 ++++++++++++++++++-----------\n 1 file changed, 20 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 6817275..3b8d079 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1344,6 +1344,13 @@ struct i40e_mac_filter *i40e_add_filter(struct i40e_vsi *vsi,\n \tif (!vsi || !macaddr)\n \t\treturn NULL;\n \n+\t/* Do not allow broadcast filter to be added since broadcast filter\n+\t * is added as part of add vsi for any newly created VSI except\n+\t * FDIR VSI\n+\t */\n+\tif (is_broadcast_ether_addr(macaddr))\n+\t\treturn NULL;\n+\n \tf = i40e_find_filter(vsi, macaddr, vlan, is_vf, is_netdev);\n \tif (!f) {\n \t\tf = kzalloc(sizeof(*f), GFP_ATOMIC);\n@@ -2179,18 +2186,6 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\t\t\t hw->aq.asq_last_status));\n \t\t\t}\n \t\t}\n-\t\taq_ret = i40e_aq_set_vsi_broadcast(&vsi->back->hw,\n-\t\t\t\t\t\t vsi->seid,\n-\t\t\t\t\t\t cur_promisc, NULL);\n-\t\tif (aq_ret) {\n-\t\t\tretval = i40e_aq_rc_to_posix(aq_ret,\n-\t\t\t\t\t\t pf->hw.aq.asq_last_status);\n-\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t \"set brdcast promisc failed, err %s, aq_err %s\\n\",\n-\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n-\t\t\t\t\t i40e_aq_str(hw,\n-\t\t\t\t\t\t hw->aq.asq_last_status));\n-\t\t}\n \t}\n out:\n \t/* if something went wrong then set the changed flag so we try again */\n@@ -9254,6 +9249,7 @@ int i40e_is_vsi_uplink_mode_veb(struct i40e_vsi *vsi)\n static int i40e_add_vsi(struct i40e_vsi *vsi)\n {\n \tint ret = -ENODEV;\n+\ti40e_status aq_ret = 0;\n \tu8 laa_macaddr[ETH_ALEN];\n \tbool found_laa_mac_filter = false;\n \tstruct i40e_pf *pf = vsi->back;\n@@ -9443,6 +9439,18 @@ static int i40e_add_vsi(struct i40e_vsi *vsi)\n \t\tvsi->seid = ctxt.seid;\n \t\tvsi->id = ctxt.vsi_number;\n \t}\n+\t/* Except FDIR VSI, for all othet VSI set the broadcast filter */\n+\tif (vsi->type != I40E_VSI_FDIR) {\n+\t\taq_ret = i40e_aq_set_vsi_broadcast(hw, vsi->seid, true, NULL);\n+\t\tif (aq_ret) {\n+\t\t\tret = i40e_aq_rc_to_posix(aq_ret,\n+\t\t\t\t\t\t hw->aq.asq_last_status);\n+\t\t\tdev_info(&pf->pdev->dev,\n+\t\t\t\t \"set brdcast promisc failed, err %s, aq_err %s\\n\",\n+\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t i40e_aq_str(hw, hw->aq.asq_last_status));\n+\t\t}\n+\t}\n \n \tspin_lock_bh(&vsi->mac_filter_list_lock);\n \t/* If macvlan filters already exist, force them to get loaded */\n", "prefixes": [ "next", "PTACH", "S38-v2", "2/7" ] }