Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/638102/?format=api
{ "id": 638102, "url": "http://patchwork.ozlabs.org/api/patches/638102/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1466439039-16378-4-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1466439039-16378-4-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-06-20T16:10:35", "name": "[next,PTACH,S38-v2,3/7] i40e/i40evf: remove useless initializer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6f742132318b6f14016b7caff058c07b0855d7a1", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1466439039-16378-4-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/638102/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/638102/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYG6Q3Qdpz9rxl\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 02:10:22 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 0E77288B2D;\n\tMon, 20 Jun 2016 16:10:21 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 4DOre125sY10; Mon, 20 Jun 2016 16:10:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8C5BE8890D;\n\tMon, 20 Jun 2016 16:10:16 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id AA7411C09EB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 648528AFF0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:11 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xvXAHyrtWPeR for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:08 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6BCBF8B015\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:08 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 20 Jun 2016 09:10:08 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby fmsmga001.fm.intel.com with ESMTP; 20 Jun 2016 09:10:08 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,499,1459839600\"; d=\"scan'208\";a=\"991493106\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 20 Jun 2016 09:10:35 -0700", "Message-Id": "<1466439039-16378-4-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1466439039-16378-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1466439039-16378-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PTACH S38-v2 3/7] i40e/i40evf: remove\n\tuseless initializer", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nThis initializer isn't needed because the variable is assigned right\naway.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I6ce3edb3f4e0364db248a7a0bcc62ca95c01d941\n---\nTesting Hints : No functionality changes.\n\n drivers/net/ethernet/intel/i40e/i40e_txrx.c | 4 +---\n drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 3 +--\n 2 files changed, 2 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\nindex 55f151f..2def562 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c\n@@ -740,14 +740,12 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,\n \ttx_ring->q_vector->tx.total_packets += total_packets;\n \n \tif (tx_ring->flags & I40E_TXR_FLAGS_WB_ON_ITR) {\n-\t\tunsigned int j = 0;\n-\n \t\t/* check to see if there are < 4 descriptors\n \t\t * waiting to be written back, then kick the hardware to force\n \t\t * them to be written back in case we stay in NAPI.\n \t\t * In this mode on X722 we do not enable Interrupt.\n \t\t */\n-\t\tj = i40e_get_tx_pending(tx_ring, false);\n+\t\tunsigned int j = i40e_get_tx_pending(tx_ring, false);\n \n \t\tif (budget &&\n \t\t ((j / (WB_STRIDE + 1)) == 0) && (j != 0) &&\ndiff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\nindex be99189..40f224f 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c\n@@ -259,13 +259,12 @@ static bool i40e_clean_tx_irq(struct i40e_vsi *vsi,\n \ttx_ring->q_vector->tx.total_packets += total_packets;\n \n \tif (tx_ring->flags & I40E_TXR_FLAGS_WB_ON_ITR) {\n-\t\tunsigned int j = 0;\n \t\t/* check to see if there are < 4 descriptors\n \t\t * waiting to be written back, then kick the hardware to force\n \t\t * them to be written back in case we stay in NAPI.\n \t\t * In this mode on X722 we do not enable Interrupt.\n \t\t */\n-\t\tj = i40evf_get_tx_pending(tx_ring, false);\n+\t\tunsigned int j = i40evf_get_tx_pending(tx_ring, false);\n \n \t\tif (budget &&\n \t\t ((j / (WB_STRIDE + 1)) == 0) && (j > 0) &&\n", "prefixes": [ "next", "PTACH", "S38-v2", "3/7" ] }