Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/638099/?format=api
{ "id": 638099, "url": "http://patchwork.ozlabs.org/api/patches/638099/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1466439039-16378-2-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1466439039-16378-2-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-06-20T16:10:33", "name": "[next,PTACH,S38-v2,1/7] i40e: Fix to show correct Advertised Link Modes when link is down", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "51d0a230109fbb83607e565760a99dc03af5b792", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1466439039-16378-2-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/638099/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/638099/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rYG6M21Mcz9s9x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 21 Jun 2016 02:10:19 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B9DFF88A38;\n\tMon, 20 Jun 2016 16:10:17 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id uZ9QpFWUhrsS; Mon, 20 Jun 2016 16:10:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 7EA86861F7;\n\tMon, 20 Jun 2016 16:10:15 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 012571C09EB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id F1E4B8B1F1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:08 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 0BpLIfHXRC3i for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:08 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 312458B002\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 20 Jun 2016 16:10:08 +0000 (UTC)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga101.fm.intel.com with ESMTP; 20 Jun 2016 09:10:07 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.177])\n\tby fmsmga001.fm.intel.com with ESMTP; 20 Jun 2016 09:10:07 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,499,1459839600\"; d=\"scan'208\";a=\"991493098\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 20 Jun 2016 09:10:33 -0700", "Message-Id": "<1466439039-16378-2-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1466439039-16378-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1466439039-16378-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PTACH S38-v2 1/7] i40e: Fix to show correct\n\tAdvertised Link Modes when link is down", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Avinash Dayanand <avinash.dayanand@intel.com>\n\nWhen link is down, Advertised Link Modes was wrongly displaying full\nsupported link modes instead of Advertised link mode. Added conditional\nchecks in order to make sure correct Advertised link modes are\ndisplayed when the link is down.\n\nSigned-off-by: Avinash Dayanand <avinash.dayanand@intel.com>\nChange-ID: I8a61413f9ee174149c7a33157b5f0b0a8da9842d\n---\nTesting Hints: See HSD\nHSD-number: 7660092\n\n drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 47 +++++++++++++++-----------\n 1 file changed, 28 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\nindex 4962e85..0cfde30 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_ethtool.c\n@@ -272,15 +272,16 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf, u32 *supported,\n \t\t\t\t u32 *advertising)\n {\n \tenum i40e_aq_capabilities_phy_type phy_types = pf->hw.phy.phy_types;\n-\n+\tstruct i40e_link_status *hw_link_info = &pf->hw.phy.link_info;\n \t*supported = 0x0;\n \t*advertising = 0x0;\n \n \tif (phy_types & I40E_CAP_PHY_TYPE_SGMII) {\n \t\t*supported |= SUPPORTED_Autoneg |\n \t\t\t SUPPORTED_1000baseT_Full;\n-\t\t*advertising |= ADVERTISED_Autoneg |\n-\t\t\t\tADVERTISED_1000baseT_Full;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_1GB)\n+\t\t\t*advertising |= ADVERTISED_1000baseT_Full;\n \t\tif (pf->flags & I40E_FLAG_100M_SGMII_CAPABLE) {\n \t\t\t*supported |= SUPPORTED_100baseT_Full;\n \t\t\t*advertising |= ADVERTISED_100baseT_Full;\n@@ -299,8 +300,9 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf, u32 *supported,\n \t phy_types & I40E_CAP_PHY_TYPE_10GBASE_LR) {\n \t\t*supported |= SUPPORTED_Autoneg |\n \t\t\t SUPPORTED_10000baseT_Full;\n-\t\t*advertising |= ADVERTISED_Autoneg |\n-\t\t\t\tADVERTISED_10000baseT_Full;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_10GB)\n+\t\t\t*advertising |= ADVERTISED_10000baseT_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_XLAUI ||\n \t phy_types & I40E_CAP_PHY_TYPE_XLPPI ||\n@@ -310,14 +312,16 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf, u32 *supported,\n \t phy_types & I40E_CAP_PHY_TYPE_40GBASE_CR4) {\n \t\t*supported |= SUPPORTED_Autoneg |\n \t\t\t SUPPORTED_40000baseCR4_Full;\n-\t\t*advertising |= ADVERTISED_Autoneg |\n-\t\t\t\tADVERTISED_40000baseCR4_Full;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_40GB)\n+\t\t\t*advertising |= ADVERTISED_40000baseCR4_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_100BASE_TX) {\n \t\t*supported |= SUPPORTED_Autoneg |\n \t\t\t SUPPORTED_100baseT_Full;\n-\t\t*advertising |= ADVERTISED_Autoneg |\n-\t\t\t\tADVERTISED_100baseT_Full;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_100MB)\n+\t\t\t*advertising |= ADVERTISED_100baseT_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_1000BASE_T ||\n \t phy_types & I40E_CAP_PHY_TYPE_1000BASE_SX ||\n@@ -325,8 +329,9 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf, u32 *supported,\n \t phy_types & I40E_CAP_PHY_TYPE_1000BASE_T_OPTICAL) {\n \t\t*supported |= SUPPORTED_Autoneg |\n \t\t\t SUPPORTED_1000baseT_Full;\n-\t\t*advertising |= ADVERTISED_Autoneg |\n-\t\t\t\tADVERTISED_1000baseT_Full;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_1GB)\n+\t\t\t*advertising |= ADVERTISED_1000baseT_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_40GBASE_SR4)\n \t\t*supported |= SUPPORTED_40000baseSR4_Full;\n@@ -341,26 +346,30 @@ static void i40e_phy_type_to_ethtool(struct i40e_pf *pf, u32 *supported,\n \tif (phy_types & I40E_CAP_PHY_TYPE_20GBASE_KR2) {\n \t\t*supported |= SUPPORTED_20000baseKR2_Full |\n \t\t\t SUPPORTED_Autoneg;\n-\t\t*advertising |= ADVERTISED_20000baseKR2_Full |\n-\t\t\t\tADVERTISED_Autoneg;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_20GB)\n+\t\t\t*advertising |= ADVERTISED_20000baseKR2_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_10GBASE_KR) {\n \t\t*supported |= SUPPORTED_10000baseKR_Full |\n \t\t\t SUPPORTED_Autoneg;\n-\t\t*advertising |= ADVERTISED_10000baseKR_Full |\n-\t\t\t\tADVERTISED_Autoneg;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_10GB)\n+\t\t\t*advertising |= ADVERTISED_10000baseKR_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_10GBASE_KX4) {\n \t\t*supported |= SUPPORTED_10000baseKX4_Full |\n \t\t\t SUPPORTED_Autoneg;\n-\t\t*advertising |= ADVERTISED_10000baseKX4_Full |\n-\t\t\t\tADVERTISED_Autoneg;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_10GB)\n+\t\t\t*advertising |= ADVERTISED_10000baseKX4_Full;\n \t}\n \tif (phy_types & I40E_CAP_PHY_TYPE_1000BASE_KX) {\n \t\t*supported |= SUPPORTED_1000baseKX_Full |\n \t\t\t SUPPORTED_Autoneg;\n-\t\t*advertising |= ADVERTISED_1000baseKX_Full |\n-\t\t\t\tADVERTISED_Autoneg;\n+\t\t*advertising |= ADVERTISED_Autoneg;\n+\t\tif (hw_link_info->requested_speeds & I40E_LINK_SPEED_1GB)\n+\t\t\t*advertising |= ADVERTISED_1000baseKX_Full;\n \t}\n }\n \n", "prefixes": [ "next", "PTACH", "S38-v2", "1/7" ] }