Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/637322/?format=api
{ "id": 637322, "url": "http://patchwork.ozlabs.org/api/patches/637322/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160617232111.27182-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160617232111.27182-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-06-17T23:21:11", "name": "fm10k: prefer READ_ONCE instead of ACCESS_ONCE", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "22ca1c20529b5c075f5d828015c9c463d1fca719", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160617232111.27182-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/637322/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/637322/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rWbq373f6z9t0d\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 18 Jun 2016 09:21:19 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4AC222C8AB;\n\tFri, 17 Jun 2016 23:21:17 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id B3bvTeDxUf5Q; Fri, 17 Jun 2016 23:21:15 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id B27AF2DB26;\n\tFri, 17 Jun 2016 23:21:15 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id BF3F61C11B9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Jun 2016 23:21:14 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id B4DA72DB26\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Jun 2016 23:21:14 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bIK4VQWbLmFp for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Jun 2016 23:21:13 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTP id BD4D1255A5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 17 Jun 2016 23:21:13 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga103.fm.intel.com with ESMTP; 17 Jun 2016 16:21:13 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.116])\n\tby orsmga003.jf.intel.com with ESMTP; 17 Jun 2016 16:21:14 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,485,1459839600\"; d=\"scan'208\";a=\"830520683\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Fri, 17 Jun 2016 16:21:11 -0700", "Message-Id": "<20160617232111.27182-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.9.0.rc1.405.g81f467e", "Subject": "[Intel-wired-lan] [PATCH] fm10k: prefer READ_ONCE instead of\n\tACCESS_ONCE", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "While technically not needed, as all our uses of ACCESS_ONCE are scalar\ntypes, we already use READ_ONCE in a few places, and for code\nreadability we can swap all the uses of the older ACCESS_ONCE into\nREAD_ONCE.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_common.h | 4 ++--\n drivers/net/ethernet/intel/fm10k/fm10k_iov.c | 4 ++--\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +-\n drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 6 +++---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +-\n 5 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_common.h b/drivers/net/ethernet/intel/fm10k/fm10k_common.h\nindex 50f71e997448..d51f9c7a47ff 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_common.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_common.h\n@@ -34,7 +34,7 @@ u32 fm10k_read_reg(struct fm10k_hw *hw, int reg);\n /* write operations, indexed using DWORDS */\n #define fm10k_write_reg(hw, reg, val) \\\n do { \\\n-\tu32 __iomem *hw_addr = ACCESS_ONCE((hw)->hw_addr); \\\n+\tu32 __iomem *hw_addr = READ_ONCE((hw)->hw_addr); \\\n \tif (!FM10K_REMOVED(hw_addr)) \\\n \t\twritel((val), &hw_addr[(reg)]); \\\n } while (0)\n@@ -42,7 +42,7 @@ do { \\\n /* Switch register write operations, index using DWORDS */\n #define fm10k_write_sw_reg(hw, reg, val) \\\n do { \\\n-\tu32 __iomem *sw_addr = ACCESS_ONCE((hw)->sw_addr); \\\n+\tu32 __iomem *sw_addr = READ_ONCE((hw)->sw_addr); \\\n \tif (!FM10K_REMOVED(sw_addr)) \\\n \t\twritel((val), &sw_addr[(reg)]); \\\n } while (0)\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\nindex 47f0743ec03b..d9dec81f6b6d 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c\n@@ -51,7 +51,7 @@ s32 fm10k_iov_event(struct fm10k_intfc *interface)\n \tint i;\n \n \t/* if there is no iov_data then there is no mailbox to process */\n-\tif (!ACCESS_ONCE(interface->iov_data))\n+\tif (!READ_ONCE(interface->iov_data))\n \t\treturn 0;\n \n \trcu_read_lock();\n@@ -99,7 +99,7 @@ s32 fm10k_iov_mbx(struct fm10k_intfc *interface)\n \tint i;\n \n \t/* if there is no iov_data then there is no mailbox to process */\n-\tif (!ACCESS_ONCE(interface->iov_data))\n+\tif (!READ_ONCE(interface->iov_data))\n \t\treturn 0;\n \n \trcu_read_lock();\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 6805f6fd0843..682a372bdb20 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -1408,7 +1408,7 @@ static void fm10k_update_itr(struct fm10k_ring_container *ring_container)\n \t * that the calculation will never get below a 1. The bit shift\n \t * accounts for changes in the ITR due to PCIe link speed.\n \t */\n-\titr_round = ACCESS_ONCE(ring_container->itr_scale) + 8;\n+\titr_round = READ_ONCE(ring_container->itr_scale) + 8;\n \tavg_wire_size += BIT(itr_round) - 1;\n \tavg_wire_size >>= itr_round;\n \ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\nindex 2a08d3f5b6df..e2ba8a31ab16 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_netdev.c\n@@ -1098,7 +1098,7 @@ static struct rtnl_link_stats64 *fm10k_get_stats64(struct net_device *netdev,\n \trcu_read_lock();\n \n \tfor (i = 0; i < interface->num_rx_queues; i++) {\n-\t\tring = ACCESS_ONCE(interface->rx_ring[i]);\n+\t\tring = READ_ONCE(interface->rx_ring[i]);\n \n \t\tif (!ring)\n \t\t\tcontinue;\n@@ -1114,7 +1114,7 @@ static struct rtnl_link_stats64 *fm10k_get_stats64(struct net_device *netdev,\n \t}\n \n \tfor (i = 0; i < interface->num_tx_queues; i++) {\n-\t\tring = ACCESS_ONCE(interface->tx_ring[i]);\n+\t\tring = READ_ONCE(interface->tx_ring[i]);\n \n \t\tif (!ring)\n \t\t\tcontinue;\n@@ -1299,7 +1299,7 @@ static void *fm10k_dfwd_add_station(struct net_device *dev,\n static void fm10k_dfwd_del_station(struct net_device *dev, void *priv)\n {\n \tstruct fm10k_intfc *interface = netdev_priv(dev);\n-\tstruct fm10k_l2_accel *l2_accel = ACCESS_ONCE(interface->l2_accel);\n+\tstruct fm10k_l2_accel *l2_accel = READ_ONCE(interface->l2_accel);\n \tstruct fm10k_dglort_cfg dglort = { 0 };\n \tstruct fm10k_hw *hw = &interface->hw;\n \tstruct net_device *sdev = priv;\ndiff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex e23923729541..0293eed5005b 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -62,7 +62,7 @@ u16 fm10k_read_pci_cfg_word(struct fm10k_hw *hw, u32 reg)\n \n u32 fm10k_read_reg(struct fm10k_hw *hw, int reg)\n {\n-\tu32 __iomem *hw_addr = ACCESS_ONCE(hw->hw_addr);\n+\tu32 __iomem *hw_addr = READ_ONCE(hw->hw_addr);\n \tu32 value = 0;\n \n \tif (FM10K_REMOVED(hw_addr))\n", "prefixes": [] }