Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/635642/?format=api
{ "id": 635642, "url": "http://patchwork.ozlabs.org/api/patches/635642/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160614232616.27686-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160614232616.27686-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-06-14T23:26:16", "name": "fm10k: don't continue probe if PCI device not in normal IO state", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "6af2034ff45802f3d0ea91fda9f428ed290c97db", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160614232616.27686-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/635642/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/635642/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rTm4K136bz9t0t\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 15 Jun 2016 09:26:25 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 890B589532;\n\tTue, 14 Jun 2016 23:26:23 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id KWcTHTDd3mBN; Tue, 14 Jun 2016 23:26:22 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 30FD689377;\n\tTue, 14 Jun 2016 23:26:22 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3FBE51C0F8A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 14 Jun 2016 23:26:21 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3856D8B62D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 14 Jun 2016 23:26:21 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id R8O03MrZjwQl for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 14 Jun 2016 23:26:20 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6B11D8B5E6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 14 Jun 2016 23:26:20 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 14 Jun 2016 16:26:20 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.116])\n\tby orsmga003.jf.intel.com with ESMTP; 14 Jun 2016 16:26:20 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,473,1459839600\"; d=\"scan'208\";a=\"828167056\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 14 Jun 2016 16:26:16 -0700", "Message-Id": "<20160614232616.27686-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.9.0.rc1.405.g81f467e", "Subject": "[Intel-wired-lan] [PATCH] fm10k: don't continue probe if PCI device\n\tnot in normal IO state", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "In the event of an uncorrectable AER error occuring when the driver has\nnot loaded, the recovery routines are not done. This is done because\nfuture loads of the driver may not be aware of the IO state and may not\nbe able to recover at all. In this case, when we next load the driver it\nfails due to what appears to be a surprise remove event. Instead, add\na check to ensure that the device is in the normal IO state before\ncontinuing to probe. This allows us to give a more descriptive message\nof what is wrong.\n\nWithout this change, the driver will attempt to probe up to our first\ncall of .reset_hw() which will be unable to read registers and act as if\na surprise remove event occurred.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex b0c3d7b3a34c..e23923729541 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -1950,6 +1950,12 @@ static int fm10k_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n \tstruct fm10k_intfc *interface;\n \tint err;\n \n+\tif (pdev->error_state != pci_channel_io_normal) {\n+\t\tdev_err(&pdev->dev,\n+\t\t\t\"PCI device still in an error state. Unable to load...\\n\");\n+\t\treturn -EIO;\n+\t}\n+\n \terr = pci_enable_device_mem(pdev);\n \tif (err) {\n \t\tdev_err(&pdev->dev,\n", "prefixes": [] }