Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/633522/?format=api
{ "id": 633522, "url": "http://patchwork.ozlabs.org/api/patches/633522/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1465535032-26749-3-git-send-email-gwshan@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1465535032-26749-3-git-send-email-gwshan@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2016-06-10T05:03:31", "name": "[v12,02/23] core/fdt: Improve debugging functionality", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c7ab9974cf231ab99cf0a792305f7e01a84f40da", "submitter": { "id": 63923, "url": "http://patchwork.ozlabs.org/api/people/63923/?format=api", "name": "Gavin Shan", "email": "gwshan@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1465535032-26749-3-git-send-email-gwshan@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/633522/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/633522/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rQqv256yNz9sR8\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jun 2016 15:08:14 +1000 (AEST)", "from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3rQqv24C1SzDqfc\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jun 2016 15:08:14 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3rQqrj70DZzDqJL\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:06:13 +1000 (AEST)", "from pps.filterd (m0075771.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id\n\tu5A53rbm028216\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 01:06:12 -0400", "from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 23fbn94xyq-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 01:06:12 -0400", "from localhost\n\tby e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <gwshan@linux.vnet.ibm.com>;\n\tFri, 10 Jun 2016 15:06:09 +1000", "from d23dlp01.au.ibm.com (202.81.31.203)\n\tby e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 10 Jun 2016 15:06:07 +1000", "from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33])\n\tby d23dlp01.au.ibm.com (Postfix) with ESMTP id B8C3A2CE805C\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:51 +1000 (EST)", "from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])\n\tby d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tu5A55kCI46268466\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:46 +1000", "from d23av01.au.ibm.com (localhost [127.0.0.1])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tu5A55Pjh010167\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:26 +1000", "from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tu5A55Oqk010006; Fri, 10 Jun 2016 15:05:25 +1000", "from bran.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\tby ozlabs.au.ibm.com (Postfix) with ESMTP id ADD66A039F;\n\tFri, 10 Jun 2016 15:04:00 +1000 (AEST)", "from gwshan (shangw.ozlabs.ibm.com [10.61.2.199])\n\tby bran.ozlabs.ibm.com (Postfix) with ESMTP id 72A63E3B18;\n\tFri, 10 Jun 2016 15:03:55 +1000 (AEST)", "by gwshan (Postfix, from userid 1000)\n\tid 58BB6942CA3; Fri, 10 Jun 2016 15:03:55 +1000 (AEST)" ], "X-IBM-Helo": "d23dlp01.au.ibm.com", "X-IBM-MailFrom": "gwshan@linux.vnet.ibm.com", "X-IBM-RcptTo": "skiboot@lists.ozlabs.org", "From": "Gavin Shan <gwshan@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Fri, 10 Jun 2016 15:03:31 +1000", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1465535032-26749-1-git-send-email-gwshan@linux.vnet.ibm.com>", "References": "<1465535032-26749-1-git-send-email-gwshan@linux.vnet.ibm.com>", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "16061005-1617-0000-0000-0000012AC842", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "16061005-1618-0000-0000-0000460A8C98", "Message-Id": "<1465535032-26749-3-git-send-email-gwshan@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2016-06-10_04:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000\n\tdefinitions=main-1606100058", "Subject": "[Skiboot] [PATCH v12 02/23] core/fdt: Improve debugging\n\tfunctionality", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.22", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "alistair@popple.id.au", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "This improves the debugging functionality in fdt.c. No functional\nchanges introduced:\n\n * Replace printf() with prlog().\n * Introduce FDT_DBG() which is enabled on DEBUG_FDT.\n * Move #ifdef before dump_fdt() for better extendability.\n\nSigned-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>\nReviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>\n---\n core/fdt.c | 39 ++++++++++++++++++++-------------------\n 1 file changed, 20 insertions(+), 19 deletions(-)", "diff": "diff --git a/core/fdt.c b/core/fdt.c\nindex a301f1f..4ef470d 100644\n--- a/core/fdt.c\n+++ b/core/fdt.c\n@@ -30,12 +30,15 @@ static int fdt_error;\n static void *fdt;\n \n #undef DEBUG_FDT\n+#ifdef DEBUG_FDT\n+#define FDT_DBG(fmt, a...)\tprlog(PR_DEBUG, \"FDT: \" fmt, ##a)\n+#else\n+#define FDT_DBG(fmt, a...)\n+#endif\n \n static void __save_err(int err, const char *str)\n {\n-#ifdef DEBUG_FDT\n-\tprintf(\"FDT: rc: %d from \\\"%s\\\"\\n\", err, str);\n-#endif\n+\tFDT_DBG(\"rc: %d from \\\"%s\\\"\\n\", err, str);\n \tif (err && !fdt_error) {\n \t\tprerror(\"FDT: Error %d from \\\"%s\\\"\\n\", err, str);\n \t\tfdt_error = err;\n@@ -71,30 +74,30 @@ static void dt_end_node(void)\n \tsave_err(fdt_end_node(fdt));\n }\n \n+#ifdef DEBUG_FDT\n static void dump_fdt(void)\n {\n-#ifdef DEBUG_FDT\n \tint i, off, depth, err;\n \n-\tprintf(\"Device tree %u@%p\\n\", fdt_totalsize(fdt), fdt);\n-\n+\tprlog(PR_INFO, \"Device tree %u@%p\\n\", fdt_totalsize(fdt), fdt);\n \terr = fdt_check_header(fdt);\n \tif (err) {\n \t\tprerror(\"fdt_check_header: %s\\n\", fdt_strerror(err));\n \t\treturn;\n \t}\n-\tprintf(\"fdt_check_header passed\\n\");\n+\tprlog(PR_INFO, \"fdt_check_header passed\\n\");\n \n-\tprintf(\"fdt_num_mem_rsv = %u\\n\", fdt_num_mem_rsv(fdt));\n+\tprlog(PR_INFO, \"fdt_num_mem_rsv = %u\\n\", fdt_num_mem_rsv(fdt));\n \tfor (i = 0; i < fdt_num_mem_rsv(fdt); i++) {\n \t\tu64 addr, size;\n \n \t\terr = fdt_get_mem_rsv(fdt, i, &addr, &size);\n \t\tif (err) {\n-\t\t\tprintf(\" ERR %s\\n\", fdt_strerror(err));\n+\t\t\tprlog(PR_INFO, \" ERR %s\\n\", fdt_strerror(err));\n \t\t\treturn;\n \t\t}\n-\t\tprintf(\" mem_rsv[%i] = %lu@%#lx\\n\", i, (long)addr, (long)size);\n+\t\tprlog(PR_INFO, \" mem_rsv[%i] = %lu@%#lx\\n\",\n+\t\t i, (long)addr, (long)size);\n \t}\n \n \tfor (off = fdt_next_node(fdt, 0, &depth);\n@@ -108,26 +111,24 @@ static void dump_fdt(void)\n \t\t\tprerror(\"fdt: offset %i no name!\\n\", off);\n \t\t\treturn;\n \t\t}\n-\t\tprintf(\"name: %s [%u]\\n\", name, off);\n+\t\tprlog(PR_INFO, \"name: %s [%u]\\n\", name, off);\n \t}\n-#endif\n }\n+#else\n+static inline void dump_fdt(void) { }\n+#endif\n \n static void flatten_dt_node(const struct dt_node *root)\n {\n \tconst struct dt_node *i;\n \tconst struct dt_property *p;\n \n-#ifdef DEBUG_FDT\n-\tprintf(\"FDT: node: %s\\n\", root->name);\n-#endif\n-\n+\tFDT_DBG(\"node: %s\\n\", root->name);\n \tlist_for_each(&root->properties, p, list) {\n \t\tif (strstarts(p->name, DT_PRIVATE))\n \t\t\tcontinue;\n-#ifdef DEBUG_FDT\n-\t\tprintf(\"FDT: prop: %s size: %ld\\n\", p->name, p->len);\n-#endif\n+\n+\t\tFDT_DBG(\" prop: %s size: %ld\\n\", p->name, p->len);\n \t\tdt_property(p);\n \t}\n \n", "prefixes": [ "v12", "02/23" ] }