Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/633521/?format=api
{ "id": 633521, "url": "http://patchwork.ozlabs.org/api/patches/633521/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1465535032-26749-4-git-send-email-gwshan@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1465535032-26749-4-git-send-email-gwshan@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2016-06-10T05:03:32", "name": "[v12,03/23] core/fdt: Introduce flatten_dt_properties()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0defe1c36f3a185696e25d66778174c35a846641", "submitter": { "id": 63923, "url": "http://patchwork.ozlabs.org/api/people/63923/?format=api", "name": "Gavin Shan", "email": "gwshan@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1465535032-26749-4-git-send-email-gwshan@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/633521/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/633521/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rQqtg38wmz9sD3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jun 2016 15:07:55 +1000 (AEST)", "from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3rQqtg20WtzDqQW\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jun 2016 15:07:55 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n\t[148.163.156.1])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3rQqrP604XzDqNj\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:57 +1000 (AEST)", "from pps.filterd (m0098394.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id\n\tu5A53oZp034281\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 01:05:55 -0400", "from e23smtp06.au.ibm.com (e23smtp06.au.ibm.com [202.81.31.148])\n\tby mx0a-001b2d01.pphosted.com with ESMTP id 23fm5y30hs-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 01:05:55 -0400", "from localhost\n\tby e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <gwshan@linux.vnet.ibm.com>;\n\tFri, 10 Jun 2016 15:05:53 +1000", "from d23dlp02.au.ibm.com (202.81.31.213)\n\tby e23smtp06.au.ibm.com (202.81.31.212) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 10 Jun 2016 15:05:52 +1000", "from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33])\n\tby d23dlp02.au.ibm.com (Postfix) with ESMTP id 7AC762BB0059\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:46 +1000 (EST)", "from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119])\n\tby d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tu5A55fte7406032\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:41 +1000", "from d23av05.au.ibm.com (localhost [127.0.0.1])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tu5A55eMk026131\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:41 +1000", "from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tu5A55e1D026025; Fri, 10 Jun 2016 15:05:40 +1000", "from bran.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\tby ozlabs.au.ibm.com (Postfix) with ESMTP id 002CFA03A0;\n\tFri, 10 Jun 2016 15:04:01 +1000 (AEST)", "from gwshan (shangw.ozlabs.ibm.com [10.61.2.199])\n\tby bran.ozlabs.ibm.com (Postfix) with ESMTP id BAA0FE3B19;\n\tFri, 10 Jun 2016 15:03:55 +1000 (AEST)", "by gwshan (Postfix, from userid 1000)\n\tid 9EB62942CA3; Fri, 10 Jun 2016 15:03:55 +1000 (AEST)" ], "X-IBM-Helo": "d23dlp02.au.ibm.com", "X-IBM-MailFrom": "gwshan@linux.vnet.ibm.com", "X-IBM-RcptTo": "skiboot@lists.ozlabs.org", "From": "Gavin Shan <gwshan@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Fri, 10 Jun 2016 15:03:32 +1000", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1465535032-26749-1-git-send-email-gwshan@linux.vnet.ibm.com>", "References": "<1465535032-26749-1-git-send-email-gwshan@linux.vnet.ibm.com>", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "16061005-0040-0000-0000-000001B049F2", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "16061005-0041-0000-0000-000009D76D3C", "Message-Id": "<1465535032-26749-4-git-send-email-gwshan@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2016-06-10_04:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000\n\tdefinitions=main-1606100058", "Subject": "[Skiboot] [PATCH v12 03/23] core/fdt: Introduce\n\tflatten_dt_properties()", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.22", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "alistair@popple.id.au", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "We need unflatten the child nodes of the specified one during PCI\nhot add time. After it, the FDT blob is transferred to kernel and\nunflattened there. A device sub-tree is represented by the FDT blob\nand it excludes the specified (root) node.\n\nThis introduces helper function flatten_dt_properties() to flatten\nthe properties of the specified node. In the path to create the\ndevice sub-tree, the root's properties is skipped in subsequent\npatch. In the mean time, the node tag is created in flatten_dt_node()\nso that the function is self-contained. No functional changes introduced.\n\nSigned-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>\n---\n core/fdt.c | 27 +++++++++++++--------------\n 1 file changed, 13 insertions(+), 14 deletions(-)", "diff": "diff --git a/core/fdt.c b/core/fdt.c\nindex 4ef470d..a934e08 100644\n--- a/core/fdt.c\n+++ b/core/fdt.c\n@@ -118,25 +118,30 @@ static void dump_fdt(void)\n static inline void dump_fdt(void) { }\n #endif\n \n-static void flatten_dt_node(const struct dt_node *root)\n+static void flatten_dt_properties(const struct dt_node *dn)\n {\n-\tconst struct dt_node *i;\n \tconst struct dt_property *p;\n \n-\tFDT_DBG(\"node: %s\\n\", root->name);\n-\tlist_for_each(&root->properties, p, list) {\n+\tlist_for_each(&dn->properties, p, list) {\n \t\tif (strstarts(p->name, DT_PRIVATE))\n \t\t\tcontinue;\n \n \t\tFDT_DBG(\" prop: %s size: %ld\\n\", p->name, p->len);\n \t\tdt_property(p);\n \t}\n+}\n \n-\tlist_for_each(&root->children, i, list) {\n-\t\tdt_begin_node(i);\n+static void flatten_dt_node(const struct dt_node *root)\n+{\n+\tconst struct dt_node *i;\n+\n+\tFDT_DBG(\"node: %s\\n\", root->name);\n+\tdt_begin_node(root);\n+\tflatten_dt_properties(root);\n+\tlist_for_each(&root->children, i, list)\n \t\tflatten_dt_node(i);\n-\t\tdt_end_node();\n-\t}\n+\n+\tdt_end_node();\n }\n \n static void create_dtb_reservemap(const struct dt_node *root)\n@@ -181,15 +186,9 @@ void *create_dtb(const struct dt_node *root)\n \n \t\tcreate_dtb_reservemap(root);\n \n-\t\t/* Open root node */\n-\t\tdt_begin_node(root);\n-\n \t\t/* Unflatten our live tree */\n \t\tflatten_dt_node(root);\n \n-\t\t/* Close root node */\n-\t\tdt_end_node();\n-\n \t\tsave_err(fdt_finish(fdt));\n \n \t\tif (!fdt_error)\n", "prefixes": [ "v12", "03/23" ] }