Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/633514/?format=api
{ "id": 633514, "url": "http://patchwork.ozlabs.org/api/patches/633514/?format=api", "web_url": "http://patchwork.ozlabs.org/project/skiboot/patch/1465535032-26749-20-git-send-email-gwshan@linux.vnet.ibm.com/", "project": { "id": 44, "url": "http://patchwork.ozlabs.org/api/projects/44/?format=api", "name": "skiboot firmware development", "link_name": "skiboot", "list_id": "skiboot.lists.ozlabs.org", "list_email": "skiboot@lists.ozlabs.org", "web_url": "http://github.com/open-power/skiboot", "scm_url": "http://github.com/open-power/skiboot", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1465535032-26749-20-git-send-email-gwshan@linux.vnet.ibm.com>", "list_archive_url": null, "date": "2016-06-10T05:03:48", "name": "[v12,19/23] platforms/astbmc: Support PCI slot", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "bb86e45996bee110547ad47228fad91e0b45db8d", "submitter": { "id": 63923, "url": "http://patchwork.ozlabs.org/api/people/63923/?format=api", "name": "Gavin Shan", "email": "gwshan@linux.vnet.ibm.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/skiboot/patch/1465535032-26749-20-git-send-email-gwshan@linux.vnet.ibm.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/633514/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/633514/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "skiboot@lists.ozlabs.org" ], "Received": [ "from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rQqsh23FHz9sD3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jun 2016 15:07:04 +1000 (AEST)", "from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3rQqsh14YQzDqZv\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jun 2016 15:07:04 +1000 (AEST)", "from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com\n\t[148.163.158.5])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3rQqr03bhwzDqJ2\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:36 +1000 (AEST)", "from pps.filterd (m0098413.ppops.net [127.0.0.1])\n\tby mx0b-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id\n\tu5A53sOT031117\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 01:05:34 -0400", "from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143])\n\tby mx0b-001b2d01.pphosted.com with ESMTP id 23fm6eawxt-1\n\t(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 01:05:34 -0400", "from localhost\n\tby e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use\n\tOnly! Violators will be prosecuted\n\tfor <skiboot@lists.ozlabs.org> from <gwshan@linux.vnet.ibm.com>;\n\tFri, 10 Jun 2016 15:05:30 +1000", "from d23dlp02.au.ibm.com (202.81.31.213)\n\tby e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway:\n\tAuthorized Use Only! Violators will be prosecuted; \n\tFri, 10 Jun 2016 15:05:29 +1000", "from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37])\n\tby d23dlp02.au.ibm.com (Postfix) with ESMTP id B34B82BB006C\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:21 +1000 (EST)", "from d23av05.au.ibm.com (d23av05.au.ibm.com [9.190.234.119])\n\tby d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n\tu5A55GeM10355198\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:16 +1000", "from d23av05.au.ibm.com (localhost [127.0.0.1])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id\n\tu5A55FxC025451\n\tfor <skiboot@lists.ozlabs.org>; Fri, 10 Jun 2016 15:05:16 +1000", "from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14])\n\tby d23av05.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id\n\tu5A55F8F025413; Fri, 10 Jun 2016 15:05:15 +1000", "from bran.ozlabs.ibm.com (haven.au.ibm.com [9.192.254.114])\n\tby ozlabs.au.ibm.com (Postfix) with ESMTP id 72A85A0217;\n\tFri, 10 Jun 2016 15:03:59 +1000 (AEST)", "from gwshan (shangw.ozlabs.ibm.com [10.61.2.199])\n\tby bran.ozlabs.ibm.com (Postfix) with ESMTP id 71644E3B1A;\n\tFri, 10 Jun 2016 15:03:59 +1000 (AEST)", "by gwshan (Postfix, from userid 1000)\n\tid 575E5942CA3; Fri, 10 Jun 2016 15:03:59 +1000 (AEST)" ], "X-IBM-Helo": "d23dlp02.au.ibm.com", "X-IBM-MailFrom": "gwshan@linux.vnet.ibm.com", "X-IBM-RcptTo": "skiboot@lists.ozlabs.org", "From": "Gavin Shan <gwshan@linux.vnet.ibm.com>", "To": "skiboot@lists.ozlabs.org", "Date": "Fri, 10 Jun 2016 15:03:48 +1000", "X-Mailer": "git-send-email 2.1.0", "In-Reply-To": "<1465535032-26749-1-git-send-email-gwshan@linux.vnet.ibm.com>", "References": "<1465535032-26749-1-git-send-email-gwshan@linux.vnet.ibm.com>", "X-TM-AS-MML": "disable", "X-Content-Scanned": "Fidelis XPS MAILER", "x-cbid": "16061005-1617-0000-0000-0000012AC82B", "X-IBM-AV-DETECTION": "SAVI=unused REMOTE=unused XFE=unused", "x-cbparentid": "16061005-1618-0000-0000-0000460A8C48", "Message-Id": "<1465535032-26749-20-git-send-email-gwshan@linux.vnet.ibm.com>", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10432:, ,\n\tdefinitions=2016-06-10_04:, , signatures=0", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tspamscore=0 suspectscore=1\n\tmalwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam\n\tadjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000\n\tdefinitions=main-1606100058", "Subject": "[Skiboot] [PATCH v12 19/23] platforms/astbmc: Support PCI slot", "X-BeenThere": "skiboot@lists.ozlabs.org", "X-Mailman-Version": "2.1.22", "Precedence": "list", "List-Id": "Mailing list for skiboot development <skiboot.lists.ozlabs.org>", "List-Unsubscribe": "<https://lists.ozlabs.org/options/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe>", "List-Archive": "<http://lists.ozlabs.org/pipermail/skiboot/>", "List-Post": "<mailto:skiboot@lists.ozlabs.org>", "List-Help": "<mailto:skiboot-request@lists.ozlabs.org?subject=help>", "List-Subscribe": "<https://lists.ozlabs.org/listinfo/skiboot>,\n\t<mailto:skiboot-request@lists.ozlabs.org?subject=subscribe>", "Cc": "alistair@popple.id.au", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org", "Sender": "\"Skiboot\"\n\t<skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org>" }, "content": "This reworks PCI stuff for astbmc platform to support PCI slot:\n\n * The PCI slot is created in slot_table_get_slot_info().\n * There are no platform dependent operations provided to PCI\n slots at current stage.\n * The slot location code is populated accordingly.\n\nSigned-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>\nReviewed-by: Russell Currey <ruscur@russell.cc>\n---\n platforms/astbmc/slots.c | 58 +++++++++++++++++++++++++++++++++++-------------\n 1 file changed, 43 insertions(+), 15 deletions(-)", "diff": "diff --git a/platforms/astbmc/slots.c b/platforms/astbmc/slots.c\nindex 2144112..7ece836 100644\n--- a/platforms/astbmc/slots.c\n+++ b/platforms/astbmc/slots.c\n@@ -18,6 +18,7 @@\n #include <console.h>\n #include <chip.h>\n #include <pci.h>\n+#include <pci-slot.h>\n \n #include \"astbmc.h\"\n \n@@ -50,7 +51,7 @@ static const struct slot_table_entry *match_slot_phb_entry(struct phb *phb)\n }\n \n static const struct slot_table_entry *match_slot_dev_entry(struct phb *phb,\n-\t\t\t\t\t\t\t struct pci_device *pd)\n+\t\t\t\t\t\t\t struct pci_device *pd)\n {\n \tconst struct slot_table_entry *parent, *ent;\n \n@@ -75,26 +76,53 @@ static const struct slot_table_entry *match_slot_dev_entry(struct phb *phb,\n \treturn NULL;\n }\n \n+static void add_slot_properties(struct pci_slot *slot,\n+\t\t\t\tstruct dt_node *np)\n+{\n+\tstruct phb *phb = slot->phb;\n+\tstruct slot_table_entry *ent = slot->data;\n+\tsize_t base_loc_code_len, slot_label_len;\n+\tchar loc_code[LOC_CODE_SIZE];\n+\n+\tif (!np || !ent || !phb->base_loc_code)\n+\t\treturn;\n+\n+\tbase_loc_code_len = strlen(phb->base_loc_code);\n+\tslot_label_len = strlen(ent->name);\n+\tif ((base_loc_code_len + slot_label_len + 1) >= LOC_CODE_SIZE)\n+\t\treturn;\n+\n+\t/* Location code */\n+\tstrcpy(loc_code, phb->base_loc_code);\n+\tstrcat(loc_code, \"-\");\n+\tstrcat(loc_code, ent->name);\n+\tdt_add_property(np, \"ibm,slot-location-code\",\n+\t\t\tloc_code, strlen(loc_code) + 1);\n+\tdt_add_property_string(np, \"ibm,slot-label\", ent->name);\n+}\n+\n void slot_table_get_slot_info(struct phb *phb, struct pci_device * pd)\n {\n \tconst struct slot_table_entry *ent;\n-\tstruct pci_slot_info *si;\n+\tstruct pci_slot *slot;\n \n-\tif (!pd || pd->slot_info)\n+\tif (!pd || pd->slot)\n \t\treturn;\n \tent = match_slot_dev_entry(phb, pd);\n \tif (!ent || !ent->name)\n \t\treturn;\n-\tpd->slot_info = si = zalloc(sizeof(struct pci_slot_info));\n-\tassert(pd->slot_info);\n-\tstrncpy(si->label, ent->name, sizeof(si->label) - 1);\n-\tsi->pluggable = ent->etype == st_pluggable_slot;\n-\tsi->power_ctl = false;\n-\tsi->wired_lanes = -1;\n-\tsi->bus_clock = -1;\n-\tsi->connector_type = -1;\n-\tsi->card_desc = -1;\n-\tsi->card_mech = -1;\n-\tsi->pwr_led_ctl = -1;\n-\tsi->attn_led_ctl = -1;\n+\n+\tslot = pcie_slot_create(phb, pd);\n+\tassert(slot);\n+\tslot->ops.add_properties = add_slot_properties;\n+\tslot->data = (void *)ent;\n+\n+\tslot->pluggable = ent->etype == st_pluggable_slot;\n+\tslot->power_ctl = false;\n+\tslot->wired_lanes = PCI_SLOT_WIRED_LANES_UNKNOWN;\n+\tslot->connector_type = PCI_SLOT_CONNECTOR_PCIE_NS;\n+\tslot->card_desc = PCI_SLOT_DESC_NON_STANDARD;\n+\tslot->card_mech = PCI_SLOT_MECH_NONE;\n+\tslot->power_led_ctl = PCI_SLOT_PWR_LED_CTL_NONE;\n+\tslot->attn_led_ctl = PCI_SLOT_ATTN_LED_CTL_NONE;\n }\n", "prefixes": [ "v12", "19/23" ] }