Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/633139/?format=api
{ "id": 633139, "url": "http://patchwork.ozlabs.org/api/patches/633139/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160609190203.19082-1-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160609190203.19082-1-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-06-09T19:02:03", "name": "fm10k: fix PCI device enable_cnt leak in .io_slot_reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "4b88615436a699892196916e82154e76a19bfb2e", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160609190203.19082-1-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/633139/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/633139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rQZRq4PpTz9sC3\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jun 2016 05:02:15 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CD492955FD;\n\tThu, 9 Jun 2016 19:02:13 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xFMlpoW5jzWT; Thu, 9 Jun 2016 19:02:12 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 72A1D955CF;\n\tThu, 9 Jun 2016 19:02:12 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2F0731C09D6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Jun 2016 19:02:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 2AF97955CF\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Jun 2016 19:02:11 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id a9a2gzUiMtPN for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Jun 2016 19:02:10 +0000 (UTC)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 90EF8955BB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Jun 2016 19:02:10 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga101.fm.intel.com with ESMTP; 09 Jun 2016 12:02:10 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.116])\n\tby orsmga003.jf.intel.com with ESMTP; 09 Jun 2016 12:02:08 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,446,1459839600\"; d=\"scan'208\";a=\"825043081\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 9 Jun 2016 12:02:03 -0700", "Message-Id": "<20160609190203.19082-1-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.9.0.rc1.405.g81f467e", "Subject": "[Intel-wired-lan] [PATCH] fm10k: fix PCI device enable_cnt leak in\n\t.io_slot_reset", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "A previous patch removed the pci_disable_device() call in\n.io_error_detected. This call corresponded to a pci_enable_device_mem()\ncall within .io_slot_reset handler. Change the call here to\na pci_reenable_device() so that it does not increment and leak the\nenable_cnt reference count for the device. Without this change, VF\ndevices may fail during an unbind/bind, and we'll never zero the\nreference counter for the pci_dev structure.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex b8245c734c96..8a47953d928d 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -2280,7 +2280,7 @@ static pci_ers_result_t fm10k_io_slot_reset(struct pci_dev *pdev)\n {\n \tpci_ers_result_t result;\n \n-\tif (pci_enable_device_mem(pdev)) {\n+\tif (pci_reenable_device(pdev)) {\n \t\tdev_err(&pdev->dev,\n \t\t\t\"Cannot re-enable PCI device after reset.\\n\");\n \t\tresult = PCI_ERS_RESULT_DISCONNECT;\n", "prefixes": [] }