Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/633080/?format=api
{ "id": 633080, "url": "http://patchwork.ozlabs.org/api/patches/633080/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160609174534.25671.50164.stgit@localhost6.localdomain6/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160609174534.25671.50164.stgit@localhost6.localdomain6>", "list_archive_url": null, "date": "2016-06-09T17:45:34", "name": "ixgbevf: fix NACK check in ixgbevf_set_uc_addr_vf()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "669f6ec15423b53788b15855f3468ebf802ab7ab", "submitter": { "id": 1670, "url": "http://patchwork.ozlabs.org/api/people/1670/?format=api", "name": "Tantilov, Emil S", "email": "emil.s.tantilov@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160609174534.25671.50164.stgit@localhost6.localdomain6/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/633080/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/633080/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rQXlk6jbQz9sBf\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 10 Jun 2016 03:45:54 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 37852954F5;\n\tThu, 9 Jun 2016 17:45:53 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id xRvYuagBwjYw; Thu, 9 Jun 2016 17:45:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A23D694F1A;\n\tThu, 9 Jun 2016 17:45:52 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 57FE81C09D6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Jun 2016 17:45:51 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 52A658A3A0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Jun 2016 17:45:51 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id N9QdAYbfgr8D for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Jun 2016 17:45:50 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 954A587247\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 9 Jun 2016 17:45:50 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 09 Jun 2016 10:45:50 -0700", "from estantil-desk3.jf.intel.com (HELO localhost6.localdomain6)\n\t([134.134.3.186])\n\tby fmsmga004.fm.intel.com with ESMTP; 09 Jun 2016 10:45:50 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,446,1459839600\"; d=\"scan'208\";a=\"119093071\"", "From": "Emil Tantilov <emil.s.tantilov@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 09 Jun 2016 10:45:34 -0700", "Message-ID": "<20160609174534.25671.50164.stgit@localhost6.localdomain6>", "User-Agent": "StGit/0.17.1-17-ge4e0", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbevf: fix NACK check in\n\tixgbevf_set_uc_addr_vf()", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Fix the NACK check in ixgbevf_set_uc_addr_vf() for instances where\nindex != 0.\n\nSigned-off-by: Emil Tantilov <emil.s.tantilov@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/vf.c | 14 ++++++++------\n 1 file changed, 8 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex e670d3b..aa2b1e8 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -256,7 +256,7 @@ static s32 ixgbevf_get_mac_addr_vf(struct ixgbe_hw *hw, u8 *mac_addr)\n static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)\n {\n \tstruct ixgbe_mbx_info *mbx = &hw->mbx;\n-\tu32 msgbuf[3];\n+\tu32 msgbuf[3], msgbuf_chk;\n \tu8 *msg_addr = (u8 *)(&msgbuf[1]);\n \ts32 ret_val;\n \n@@ -268,6 +268,8 @@ static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)\n \t */\n \tmsgbuf[0] |= index << IXGBE_VT_MSGINFO_SHIFT;\n \tmsgbuf[0] |= IXGBE_VF_SET_MACVLAN;\n+\tmsgbuf_chk = msgbuf[0];\n+\n \tif (addr)\n \t\tether_addr_copy(msg_addr, addr);\n \tret_val = mbx->ops.write_posted(hw, msgbuf, 3);\n@@ -275,12 +277,12 @@ static s32 ixgbevf_set_uc_addr_vf(struct ixgbe_hw *hw, u32 index, u8 *addr)\n \tif (!ret_val)\n \t\tret_val = mbx->ops.read_posted(hw, msgbuf, 3);\n \n-\tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n+\tif (!ret_val) {\n+\t\tmsgbuf[0] &= ~IXGBE_VT_MSGTYPE_CTS;\n \n-\tif (!ret_val)\n-\t\tif (msgbuf[0] ==\n-\t\t (IXGBE_VF_SET_MACVLAN | IXGBE_VT_MSGTYPE_NACK))\n-\t\t\tret_val = -ENOMEM;\n+\t\tif (msgbuf[0] == (msgbuf_chk | IXGBE_VT_MSGTYPE_NACK))\n+\t\t\treturn -ENOMEM;\n+\t}\n \n \treturn ret_val;\n }\n", "prefixes": [] }