Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/631859/?format=api
{ "id": 631859, "url": "http://patchwork.ozlabs.org/api/patches/631859/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160607230902.5457-12-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160607230902.5457-12-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-06-07T23:08:55", "name": "[v2,11/18] fm10k: implement reset_notify handler for PCIe FLR events", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "784ff2c8b357315ccbe56db03472b32621d741ca", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160607230902.5457-12-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/631859/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/631859/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rPS1w4Kfrz9ssP\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Jun 2016 09:09:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 034188A8C3;\n\tTue, 7 Jun 2016 23:09:23 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CsmoHpp-q05Y; Tue, 7 Jun 2016 23:09:18 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 3035D8A91A;\n\tTue, 7 Jun 2016 23:09:13 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 407F11C127A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Jun 2016 23:09:10 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3D50F856E3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Jun 2016 23:09:10 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id sAGsuBfvAYL4 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Jun 2016 23:09:06 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 69A5285C78\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Jun 2016 23:09:06 +0000 (UTC)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga104.fm.intel.com with ESMTP; 07 Jun 2016 16:09:05 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.116])\n\tby FMSMGA003.fm.intel.com with ESMTP; 07 Jun 2016 16:09:06 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,436,1459839600\"; d=\"scan'208\";a=\"715507174\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Tue, 7 Jun 2016 16:08:55 -0700", "Message-Id": "<20160607230902.5457-12-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.9.0.rc1.405.g81f467e", "In-Reply-To": "<20160607230902.5457-1-jacob.e.keller@intel.com>", "References": "<20160607230902.5457-1-jacob.e.keller@intel.com>", "Subject": "[Intel-wired-lan] [PATCH v2 11/18] fm10k: implement reset_notify\n\thandler for PCIe FLR events", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "When a function level PCI reset is triggered using sysfs, it calls the\ndriver's .reset_notify error handler. Implement a handler based on the\nnow split fm10k_prepare_for_reset and fm10k_handle_reset functions, so\nthat we fully reset the driver when the PCI function level reset occurs.\nThis also ensures the reset is handled in a clean way by first disabling\nall the driver bits first and then restoring them after the function\nreset. Previously the stack simply performed a blind function reset and\nour driver didn't take any part in the process.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 33 ++++++++++++++++++++++++++++\n 1 file changed, 33 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\nindex 716a5c852143..c60c3b0f89e9 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c\n@@ -2373,10 +2373,43 @@ static void fm10k_io_resume(struct pci_dev *pdev)\n \t\tnetif_device_attach(netdev);\n }\n \n+/**\n+ * fm10k_io_reset_notify - called when PCI function is reset\n+ * @pdev: Pointer to PCI device\n+ *\n+ * This callback is called when the PCI function is reset such as from\n+ * /sys/class/net/<enpX>/device/reset or similar. When prepare is true, it\n+ * means we should prepare for a function reset. If prepare is false, it means\n+ * the function reset just occurred.\n+ */\n+static void fm10k_io_reset_notify(struct pci_dev *pdev, bool prepare)\n+{\n+\tstruct fm10k_intfc *interface = pci_get_drvdata(pdev);\n+\tint err = 0;\n+\n+\tif (prepare) {\n+\t\t/* warn incase we have any active VF devices */\n+\t\tif (pci_num_vf(pdev))\n+\t\t\tdev_warn(&pdev->dev,\n+\t\t\t\t \"PCIe FLR may cause issues for any active VF devices\\n\");\n+\n+\t\tfm10k_prepare_suspend(interface);\n+\t} else {\n+\t\terr = fm10k_handle_resume(interface);\n+\t}\n+\n+\tif (err) {\n+\t\tdev_warn(&pdev->dev,\n+\t\t\t \"fm10k_io_reset_notify failed: %d\\n\", err);\n+\t\tnetif_device_detach(interface->netdev);\n+\t}\n+}\n+\n static const struct pci_error_handlers fm10k_err_handler = {\n \t.error_detected = fm10k_io_error_detected,\n \t.slot_reset = fm10k_io_slot_reset,\n \t.resume = fm10k_io_resume,\n+\t.reset_notify = fm10k_io_reset_notify,\n };\n \n static struct pci_driver fm10k_driver = {\n", "prefixes": [ "v2", "11/18" ] }