Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/631844/?format=api
{ "id": 631844, "url": "http://patchwork.ozlabs.org/api/patches/631844/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160607161455.4203.31219.stgit@ukketine.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160607161455.4203.31219.stgit@ukketine.jf.intel.com>", "list_archive_url": null, "date": "2016-06-07T16:14:55", "name": "i40e: Don't notify client(s) for DCB changes on all VSIs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "554f1b1a12439e842fe1ce781259a95b3bc36cc7", "submitter": { "id": 67830, "url": "http://patchwork.ozlabs.org/api/people/67830/?format=api", "name": "Usha Ketineni", "email": "usha.k.ketineni@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160607161455.4203.31219.stgit@ukketine.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/631844/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/631844/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rPRt140ZGz9t3h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 8 Jun 2016 09:02:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id CC8D730FE7;\n\tTue, 7 Jun 2016 23:02:30 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id lwq2DBp7wGUc; Tue, 7 Jun 2016 23:02:29 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id A585031020;\n\tTue, 7 Jun 2016 23:02:29 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 393291C127A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Jun 2016 23:02:29 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3379589C20\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Jun 2016 23:02:29 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wY0kJmlxBm0u for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Jun 2016 23:02:28 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 70CB789A90\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 7 Jun 2016 23:02:28 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 07 Jun 2016 16:02:27 -0700", "from ukketine.jf.intel.com ([134.134.173.52])\n\tby orsmga002.jf.intel.com with ESMTP; 07 Jun 2016 16:02:27 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,436,1459839600\"; d=\"scan'208\";a=\"993075582\"", "From": "Usha Ketineni <usha.k.ketineni@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 07 Jun 2016 09:14:55 -0700", "Message-ID": "<20160607161455.4203.31219.stgit@ukketine.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] i40e: Don't notify client(s) for DCB\n\tchanges on all VSIs", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Neerav Parikh <neerav.parikh@intel.com>\n\nWhen LLDP/DCBX change happens the i40e driver code flow tried to\nnotify the client(s) for each of the PF VSIs. This resulted into\nkernel panic on the first VSI that didn't have any netdev\nassociated to it.\n\nThe DCB change notification to the client(s) should be done only\nonce for the PF/LAN VSI where the client(s) instances have been\nadded to. Also, move the notification call after the PF driver has\nmade changes related to the updated DCB configuration.\n\nSigned-off-by: Neerav Parikh <neerav.parikh@intel.com>\nSigned-off-by: Usha Ketineni <usha.k.ketineni@intel.com>\nTested-by: Ronald J Bynoe <ronald.j.bynoe@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 5ea2200..8b54894 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -4958,7 +4958,6 @@ static void i40e_dcb_reconfigure(struct i40e_pf *pf)\n \t\t\tif (pf->vsi[v]->netdev)\n \t\t\t\ti40e_dcbnl_set_all(pf->vsi[v]);\n \t\t}\n-\t\ti40e_notify_client_of_l2_param_changes(pf->vsi[v]);\n \t}\n }\n \n@@ -5716,6 +5715,8 @@ static int i40e_handle_lldp_event(struct i40e_pf *pf,\n \t\ti40e_service_event_schedule(pf);\n \t} else {\n \t\ti40e_pf_unquiesce_all_vsi(pf);\n+\t\t/* Notify the client for the DCB changes */\n+\t\ti40e_notify_client_of_l2_param_changes(pf->vsi[pf->lan_vsi]);\n \t}\n \n exit:\n", "prefixes": [] }