Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/630030/?format=api
{ "id": 630030, "url": "http://patchwork.ozlabs.org/api/patches/630030/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1464987805-17754-1-git-send-email-andrew@lunn.ch/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1464987805-17754-1-git-send-email-andrew@lunn.ch>", "list_archive_url": null, "date": "2016-06-03T21:03:25", "name": "[PATCHv2,net-next] net: igb: Only dma sync frame length", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0c3a6e7dd38db9b3b09e0ba82e01422caa7e4aa2", "submitter": { "id": 13608, "url": "http://patchwork.ozlabs.org/api/people/13608/?format=api", "name": "Andrew Lunn", "email": "andrew@lunn.ch" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1464987805-17754-1-git-send-email-andrew@lunn.ch/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/630030/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/630030/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rLxR85Z4mz9t8P\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 4 Jun 2016 07:04:04 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C4DE395887;\n\tFri, 3 Jun 2016 21:04:02 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id P8SNdqvrqc+q; Fri, 3 Jun 2016 21:04:00 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CAD8995881;\n\tFri, 3 Jun 2016 21:04:00 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 170CA1C1E7B\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Jun 2016 21:03:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 11F5E8931C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Jun 2016 21:03:59 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ddy7vTmf7bBz for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Jun 2016 21:03:57 +0000 (UTC)", "from vps0.lunn.ch (vps0.lunn.ch [178.209.37.122])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 769D488F9C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 3 Jun 2016 21:03:57 +0000 (UTC)", "from andrew by vps0.lunn.ch with local (Exim 4.80)\n\t(envelope-from <andrew@lunn.ch>)\n\tid 1b8wFi-0004cs-II; Fri, 03 Jun 2016 23:03:34 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Andrew Lunn <andrew@lunn.ch>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>,\n\tDavid Miller <davem@davemloft.net>", "Date": "Fri, 3 Jun 2016 23:03:25 +0200", "Message-Id": "<1464987805-17754-1-git-send-email-andrew@lunn.ch>", "X-Mailer": "git-send-email 1.7.10.4", "Cc": "netdev <netdev@vger.kernel.org>, intel-wired-lan@lists.osuosl.org,\n\tAndrew Lunn <andrew@lunn.ch>", "Subject": "[Intel-wired-lan] [PATCHv2 net-next] net: igb: Only dma sync frame\n\tlength", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "On some platforms, syncing a buffer for DMA is expensive. Rather than\nsync the whole 2K receive buffer, only synchronise the length of the\nframe, which will typically be the MTU, or a much smaller TCP ACK.\n\nFor an IMX6Q, this gives around 6% increased TCP receive performance,\nwhich is cache operations bound and reduces CPU load for TCP transmit.\n\nSigned-off-by: Andrew Lunn <andrew@lunn.ch>\n---\nv2:\nChristmas tree the local variables\nPass size into igb_add_rx_frag() rather than repeating the endiness swap.\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 0a289dda604a..8fa9e6e8c3b0 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -6856,12 +6856,12 @@ static bool igb_can_reuse_rx_page(struct igb_rx_buffer *rx_buffer,\n **/\n static bool igb_add_rx_frag(struct igb_ring *rx_ring,\n \t\t\t struct igb_rx_buffer *rx_buffer,\n+\t\t\t unsigned int size,\n \t\t\t union e1000_adv_rx_desc *rx_desc,\n \t\t\t struct sk_buff *skb)\n {\n \tstruct page *page = rx_buffer->page;\n \tunsigned char *va = page_address(page) + rx_buffer->page_offset;\n-\tunsigned int size = le16_to_cpu(rx_desc->wb.upper.length);\n #if (PAGE_SIZE < 8192)\n \tunsigned int truesize = IGB_RX_BUFSZ;\n #else\n@@ -6913,6 +6913,7 @@ static struct sk_buff *igb_fetch_rx_buffer(struct igb_ring *rx_ring,\n \t\t\t\t\t union e1000_adv_rx_desc *rx_desc,\n \t\t\t\t\t struct sk_buff *skb)\n {\n+\tunsigned int size = le16_to_cpu(rx_desc->wb.upper.length);\n \tstruct igb_rx_buffer *rx_buffer;\n \tstruct page *page;\n \n@@ -6948,11 +6949,11 @@ static struct sk_buff *igb_fetch_rx_buffer(struct igb_ring *rx_ring,\n \tdma_sync_single_range_for_cpu(rx_ring->dev,\n \t\t\t\t rx_buffer->dma,\n \t\t\t\t rx_buffer->page_offset,\n-\t\t\t\t IGB_RX_BUFSZ,\n+\t\t\t\t size,\n \t\t\t\t DMA_FROM_DEVICE);\n \n \t/* pull page into skb */\n-\tif (igb_add_rx_frag(rx_ring, rx_buffer, rx_desc, skb)) {\n+\tif (igb_add_rx_frag(rx_ring, rx_buffer, size, rx_desc, skb)) {\n \t\t/* hand second half of page back to the ring */\n \t\tigb_reuse_rx_page(rx_ring, rx_buffer);\n \t} else {\n", "prefixes": [ "PATCHv2", "net-next" ] }