Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/628796/?format=api
{ "id": 628796, "url": "http://patchwork.ozlabs.org/api/patches/628796/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160601154009.GA31043@Karyakshetra/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160601154009.GA31043@Karyakshetra>", "list_archive_url": null, "date": "2016-06-01T15:40:09", "name": "net: ethernet: intel: fm10k: Remove create_workqueue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "06940d54d171df93e362f7bf749d5c493ad16019", "submitter": { "id": 69089, "url": "http://patchwork.ozlabs.org/api/people/69089/?format=api", "name": "Bhaktipriya Shridhar", "email": "bhaktipriya96@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160601154009.GA31043@Karyakshetra/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/628796/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/628796/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3rKcwF5XwHz9t3p\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 2 Jun 2016 03:36:13 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 0AC9030817;\n\tWed, 1 Jun 2016 17:36:12 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id j9iTmQXhqx7J; Wed, 1 Jun 2016 17:36:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id E445E30515;\n\tWed, 1 Jun 2016 17:36:10 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 8F6E01C0D74\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Jun 2016 15:40:13 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 85E06306D0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Jun 2016 15:40:13 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Selojnc1GqQS for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Jun 2016 15:40:13 +0000 (UTC)", "from mail-pf0-f195.google.com (mail-pf0-f195.google.com\n\t[209.85.192.195])\n\tby silver.osuosl.org (Postfix) with ESMTPS id F0542305EC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 1 Jun 2016 15:40:12 +0000 (UTC)", "by mail-pf0-f195.google.com with SMTP id f144so4316747pfa.2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 01 Jun 2016 08:40:12 -0700 (PDT)", "from Karyakshetra ([2401:fa00:c:fd01:b045:535b:c99b:42b9])\n\tby smtp.gmail.com with ESMTPSA id\n\tc82sm49079809pfd.42.2016.06.01.08.40.11\n\t(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 01 Jun 2016 08:40:11 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=MVp9/+KL;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=date:from:to:cc:subject:message-id:mime-version:content-disposition\n\t:user-agent; bh=NkUcrUfeKfnHN+s80vA3mfJZaBXuPCh+NC0ke3n92KY=;\n\tb=MVp9/+KLQ1/djYsYxODh3bp0PJViGNiluztXiRnFYbeJBwdeNkevS9OmmvMGKuhZ7s\n\tfqGQ+lEuUV6plVeR3Fa2skNsUJse5n/Pj8+0wr9bn6yCkQxIywYlQq5vXZX2SzVRdvC8\n\tcq9h7tp6uoj/jJ27/V3XQ4p1YnKZHiw8sOVbF41mVNLTn9NkWOsN0Ff5Bcequf8X19Lr\n\tayaxuNjpDgG5XsUNsmofXE5CZ6VBJM1cVwqrE85x3yo/boLP7yKt0Au3SEBov4MCLP6Q\n\tXmjXYw6CMCV8nLiYWAoKYWylOBxsC5zk70/4LHII/r7ZyX6bHH0JMg3Wo5jVp0Y/s4dz\n\tB9fw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version\n\t:content-disposition:user-agent;\n\tbh=NkUcrUfeKfnHN+s80vA3mfJZaBXuPCh+NC0ke3n92KY=;\n\tb=JfZb5fW1h0LLm7LUjdtSyoLDqlV51OpFera75+V3iQ9AeTfYCwBax6VuP3BDo5uBjw\n\tJnrwd1JTu4Fe35Jw2yzLu99G2yTy6mjKvUBcj2sgDB54BDrRkqV9Fq/GrRk9rfFP2dSf\n\ttHz3pddD5XxIPuuJi2yNu5I9IlwBSxoQkLlsbwpS0bU+Pkw6Q9pXh9mqV6/0NDwO3kyc\n\tPl9TIceRNY26f/COsPbt0I7LRAwGGZFMSN+XnQcmMRdXDWo6XozVwDnC8HiLUAdh8dx9\n\tUy1Jnsa4pDlFXZl/IeUNuEplUOPM2INr8DPjCUqjAgjyZ0vOg5DMIn31bJ/FlEc/jFAd\n\tY7Wg==", "X-Gm-Message-State": "ALyK8tLSWlfYhTVxLzD4GJntcBIXzIsN+9KT7l3uis5q/EnAIzVIxVg15++V+lDmFMZmEA==", "X-Received": "by 10.98.103.220 with SMTP id t89mr9665388pfj.125.1464795612579; \n\tWed, 01 Jun 2016 08:40:12 -0700 (PDT)", "Date": "Wed, 1 Jun 2016 21:10:09 +0530", "From": "Bhaktipriya Shridhar <bhaktipriya96@gmail.com>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Message-ID": "<20160601154009.GA31043@Karyakshetra>", "MIME-Version": "1.0", "Content-Disposition": "inline", "User-Agent": "Mutt/1.5.23 (2014-03-12)", "X-Mailman-Approved-At": "Wed, 01 Jun 2016 17:36:09 +0000", "Cc": "Tejun Heo <tj@kernel.org>, netdev@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] net: ethernet: intel: fm10k: Remove\n\tcreate_workqueue", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "alloc_workqueue replaces deprecated create_workqueue().\n\nA dedicated workqueue has been used since the workitem (viz\nfm10k_service_task, which manages and runs other subtasks) is involved in\nnormal device operation and requires forward progress under memory\npressure.\n\ncreate_workqueue has been replaced with alloc_workqueue with max_active\nas 0 since there is no need for throttling the number of active work\nitems.\n\nSince network devices may be used in memory reclaim path,\nWQ_MEM_RECLAIM has been set to guarantee forward progress.\n\nflush_workqueue is unnecessary since destroy_workqueue() itself calls\ndrain_workqueue() which flushes repeatedly till the workqueue\nbecomes empty. Hence the call to flush_workqueue() has been dropped.\n\nSigned-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k_main.c | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)\n\n--\n2.1.4", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_main.c b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\nindex 0e166e9..add9166 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k_main.c\n@@ -56,7 +56,7 @@ static int __init fm10k_init_module(void)\n \tpr_info(\"%s\\n\", fm10k_copyright);\n\n \t/* create driver workqueue */\n-\tfm10k_workqueue = create_workqueue(\"fm10k\");\n+\tfm10k_workqueue = alloc_workqueue(\"fm10k\", WQ_MEM_RECLAIM, 0);\n\n \tfm10k_dbg_init();\n\n@@ -77,7 +77,6 @@ static void __exit fm10k_exit_module(void)\n \tfm10k_dbg_exit();\n\n \t/* destroy driver workqueue */\n-\tflush_workqueue(fm10k_workqueue);\n \tdestroy_workqueue(fm10k_workqueue);\n }\n module_exit(fm10k_exit_module);\n", "prefixes": [] }