Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/623285/?format=api
{ "id": 623285, "url": "http://patchwork.ozlabs.org/api/patches/623285/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463517693-10333-1-git-send-email-xypron.glpk@gmx.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1463517693-10333-1-git-send-email-xypron.glpk@gmx.de>", "list_archive_url": null, "date": "2016-05-17T20:41:33", "name": "[1/1] net: i40e: avoid null pointer dereference", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "494e72bf4265e8bb3632accfa69b66c983435674", "submitter": { "id": 61270, "url": "http://patchwork.ozlabs.org/api/people/61270/?format=api", "name": "Heinrich Schuchardt", "email": "xypron.glpk@gmx.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463517693-10333-1-git-send-email-xypron.glpk@gmx.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/623285/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/623285/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3r8VkR189Dz9t6B\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 18 May 2016 07:26:07 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 9DA6996090;\n\tTue, 17 May 2016 21:26:05 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id a7CFaDLZaRYz; Tue, 17 May 2016 21:26:01 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E0F5F9604B;\n\tTue, 17 May 2016 21:26:01 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 7DDD41C163A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 May 2016 20:41:53 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 75F2D9623F\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 May 2016 20:41:53 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id c2Llus5vxRAv for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 May 2016 20:41:52 +0000 (UTC)", "from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id C390696247\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 May 2016 20:41:51 +0000 (UTC)", "from LT001.lan ([62.143.92.134]) by mail.gmx.com (mrgmx102) with\n\tESMTPSA (Nemesis) id 0McPvw-1bKRDa0W7E-00HjSM;\n\tTue, 17 May 2016 22:41:42 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Heinrich Schuchardt <xypron.glpk@gmx.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Tue, 17 May 2016 22:41:33 +0200", "Message-Id": "<1463517693-10333-1-git-send-email-xypron.glpk@gmx.de>", "X-Mailer": "git-send-email 2.1.4", "X-Provags-ID": "V03:K0:R9yydt6gAimVi90K05uSRj8onRI48l8+tnwKF61FWI0Q2rK4wTB\n\tsrwEfO9DMDs9wcEun2hZwXqB1+50hNiaKwkSqZg0FKIIyFCY/7Y1948+ixnA/ZG2qda1Vhh\n\tr8OLTshYNiMAxODq4QHtOUF+dvPBWoBoXc2hmOVOTixlE7Z1hkA6+1X0kiGEKgaX/2Xn0Ak\n\tYjw4MSJ9FKiMuPAMokBrA==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:lGYZfZw/jAc=:Ab3VVyRZhb6Uls7tRBRb/U\n\tjcPGplbOsnfAO+4rkhqcppXWhwQfUdUAzqXmAb5ssJUYq1e+KvtzH9D7T/P5vd6TzE8lp/MxW\n\t8XfGgGcOWa/Wqjz7GV1CyXNGfcYCeFz996qXSv9D2uz7u/TGqWJNPMoZve4T125MtKde+EYR3\n\ttz1DDjPgsXJNvtmXznwX27u8CfgN0T4FGgREJ/oLCn3h7eDCYsxI0EoSLnY1fsGfQU5JmJib+\n\tkMP0CmhYqiVdUwWBv9QP+9ccjL5leSmNWZr3UQfa3Odkx3i6r7X6WokUc8V4ZG9AAGgBH7y8a\n\t2eMw9Ue+Iz+S/brPEmNFTY7WH8Vf0flvmdhFfy/qS8APvevY23u6ZtldSDFoNtHCvLaT5KAAh\n\tU/owFetPSkAP+TLhV70Iu5A+FfbdZhzA1cOpqVUi+LS3KRnTWkqIjHROKGU4kBK3d9tRrRVgr\n\tOwSSQBJcCu3wBesCNAcdtpzJGasV3TJC8AV8miKwEXMJMZ0/WLuhR6BqRO7HpruwdsygAo40O\n\t8efB+jvM8DihHWq/QmTHnUOFfNxeuB1PyJfi2ZuteI45ySq2zmFOkgkHlNaARguEFZi+JQf9y\n\tQ2jlfHqEMv+ELmK8EFHsbZSiD175zpv6mkLqZKtOnYoh9LEGolKU7fAFuz5kC1OR/ptJHXSB/\n\tyYiqql4WqUWmc+NYhCGrTpVaxkubqZJWA9QVocQtNz/Y7jj5f++Mt3RNhxAuXYpUeLpjgg6Gc\n\tFMhmmVGm9pp9I+OTpxuXZvhrvBCi3p9gojcTxIq831GyrmQ6sid3B8Erl9k=", "X-Mailman-Approved-At": "Tue, 17 May 2016 21:26:01 +0000", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org, Heinrich Schuchardt <xypron.glpk@gmx.de>", "Subject": "[Intel-wired-lan] [PATCH 1/1] net: i40e: avoid null pointer\n\tdereference", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "In function i40e_debug_aq parameter desc is assumed to be\npossibly NULL. Do not dereference it before checking the\nvalue.\n\nFixes: f905dd62be88 (\"i40e/i40evf: add max buf len to aq debug print helper\")\nSigned-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>\n---\n drivers/net/ethernet/intel/i40e/i40e_common.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/intel/i40e/i40e_common.c\nindex 422b41d..d5cb570 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_common.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_common.c\n@@ -297,13 +297,15 @@ void i40e_debug_aq(struct i40e_hw *hw, enum i40e_debug_mask mask, void *desc,\n \t\t void *buffer, u16 buf_len)\n {\n \tstruct i40e_aq_desc *aq_desc = (struct i40e_aq_desc *)desc;\n-\tu16 len = le16_to_cpu(aq_desc->datalen);\n+\tu16 len;\n \tu8 *buf = (u8 *)buffer;\n \tu16 i = 0;\n \n \tif ((!(mask & hw->debug_mask)) || (desc == NULL))\n \t\treturn;\n \n+\tlen = le16_to_cpu(aq_desc->datalen);\n+\n \ti40e_debug(hw, mask,\n \t\t \"AQ CMD: opcode 0x%04X, flags 0x%04X, datalen 0x%04X, retval 0x%04X\\n\",\n \t\t le16_to_cpu(aq_desc->opcode),\n", "prefixes": [ "1/1" ] }