Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/623238/?format=api
{ "id": 623238, "url": "http://patchwork.ozlabs.org/api/patches/623238/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463511831-13684-1-git-send-email-jarod@redhat.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1463511831-13684-1-git-send-email-jarod@redhat.com>", "list_archive_url": null, "date": "2016-05-17T19:03:51", "name": "[RFC,net] e1000e: keep vlan interfaces functional after rxvlan off", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e1a051f5a221c4f78c94516c1d57d390cb15f25a", "submitter": { "id": 1153, "url": "http://patchwork.ozlabs.org/api/people/1153/?format=api", "name": "Jarod Wilson", "email": "jarod@redhat.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463511831-13684-1-git-send-email-jarod@redhat.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/623238/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/623238/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3r8RZm2K5hz9t7x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 18 May 2016 05:04:16 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D27A19578A;\n\tTue, 17 May 2016 19:04:14 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 3MxBzsHkwZUO; Tue, 17 May 2016 19:04:14 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 3B74A9571F;\n\tTue, 17 May 2016 19:04:14 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 95E971C1E89\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 May 2016 19:04:12 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8E49A30F4C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 May 2016 19:04:12 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id waHpWtQ6769O for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 May 2016 19:04:07 +0000 (UTC)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby silver.osuosl.org (Postfix) with ESMTPS id D46442F6CC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 17 May 2016 19:04:07 +0000 (UTC)", "from int-mx11.intmail.prod.int.phx2.redhat.com\n\t(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id BBE778EFEB;\n\tTue, 17 May 2016 19:04:06 +0000 (UTC)", "from hp-dl360pgen8-07.khw.lab.eng.bos.redhat.com\n\t(hp-dl360pgen8-07.khw.lab.eng.bos.redhat.com [10.16.184.47])\n\tby int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u4HJ45dc024974; Tue, 17 May 2016 15:04:06 -0400" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": [ "domain auto-whitelisted by SQLgrey-1.7.6", "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.27]); Tue, 17 May 2016 19:04:06 +0000 (UTC)" ], "From": "Jarod Wilson <jarod@redhat.com>", "To": "linux-kernel@vger.kernel.org", "Date": "Tue, 17 May 2016 15:03:51 -0400", "Message-Id": "<1463511831-13684-1-git-send-email-jarod@redhat.com>", "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.24", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org", "Subject": "[Intel-wired-lan] [RFC PATCH net] e1000e: keep vlan interfaces\n\tfunctional after rxvlan off", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "I've got a bug report about an e1000e interface, where a vlan interface is\nset up on top of it:\n\n$ ip link add link ens1f0 name ens1f0.99 type vlan id 99\n$ ip link set ens1f0 up\n$ ip link set ens1f0.99 up\n$ ip addr add 192.168.99.92 dev ens1f0.99\n\nAt this point, I can ping another host on vlan 99, ip 192.168.99.91.\nHowever, if I do the following:\n\n$ ethtool -K ens1f0 rxvlan off\n\nThen no traffic passes on ens1f0.99. It comes back if I toggle rxvlan on\nagain. I'm not sure if this is actually intended behavior, or if there's a\nlack of software vlan stripping fallback, or what, but things continue to\nwork if I simply don't call e1000e_vlan_strip_disable() if there are\nactive vlans (plagiarizing a function from the e1000 driver here) on the\ninterface.\n\nAlso slipped a related-ish fix to the kerneldoc text for\ne1000e_vlan_strip_disable here...\n\nCC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\nCC: intel-wired-lan@lists.osuosl.org\nCC: netdev@vger.kernel.org\nSigned-off-by: Jarod Wilson <jarod@redhat.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 15 +++++++++++++--\n 1 file changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 75e6089..73f7452 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -154,6 +154,16 @@ void __ew32(struct e1000_hw *hw, unsigned long reg, u32 val)\n \twritel(val, hw->hw_addr + reg);\n }\n \n+static bool e1000e_vlan_used(struct e1000_adapter *adapter)\n+{\n+\tu16 vid;\n+\n+\tfor_each_set_bit(vid, adapter->active_vlans, VLAN_N_VID)\n+\t\treturn true;\n+\n+\treturn false;\n+}\n+\n /**\n * e1000_regdump - register printout routine\n * @hw: pointer to the HW structure\n@@ -2789,7 +2799,7 @@ static void e1000e_vlan_filter_enable(struct e1000_adapter *adapter)\n }\n \n /**\n- * e1000e_vlan_strip_enable - helper to disable HW VLAN stripping\n+ * e1000e_vlan_strip_disable - helper to disable HW VLAN stripping\n * @adapter: board private structure to initialize\n **/\n static void e1000e_vlan_strip_disable(struct e1000_adapter *adapter)\n@@ -3443,7 +3453,8 @@ static void e1000e_set_rx_mode(struct net_device *netdev)\n \n \tew32(RCTL, rctl);\n \n-\tif (netdev->features & NETIF_F_HW_VLAN_CTAG_RX)\n+\tif (netdev->features & NETIF_F_HW_VLAN_CTAG_RX ||\n+\t e1000e_vlan_used(adapter))\n \t\te1000e_vlan_strip_enable(adapter);\n \telse\n \t\te1000e_vlan_strip_disable(adapter);\n", "prefixes": [ "RFC", "net" ] }