Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/622734/?format=api
{ "id": 622734, "url": "http://patchwork.ozlabs.org/api/patches/622734/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463427653-8148-1-git-send-email-tushar.n.dave@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1463427653-8148-1-git-send-email-tushar.n.dave@oracle.com>", "list_archive_url": null, "date": "2016-05-16T19:40:53", "name": "i40e: Fix errors resulted while turning off TSO", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "1a94387cd50b29cee802ae5025817d84fbab1cff", "submitter": { "id": 68023, "url": "http://patchwork.ozlabs.org/api/people/68023/?format=api", "name": "Tushar Dave", "email": "tushar.n.dave@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463427653-8148-1-git-send-email-tushar.n.dave@oracle.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/622734/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/622734/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3r7rWL01v5z9sf9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 May 2016 05:44:13 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 4D057885E1;\n\tMon, 16 May 2016 19:44:12 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5nKReqFDlp8e; Mon, 16 May 2016 19:44:11 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 95673860FB;\n\tMon, 16 May 2016 19:44:11 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1AB0E1C150C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 19:44:11 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 11F6192448\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 19:44:11 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6IXqqnyKE2pe for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 19:44:09 +0000 (UTC)", "from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 4EE7B923F6\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 19:44:09 +0000 (UTC)", "from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71])\n\tby userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id u4GJi7Kw026718\n\t(version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tMon, 16 May 2016 19:44:07 GMT", "from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75])\n\tby userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u4GJi6Ex012244\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tMon, 16 May 2016 19:44:07 GMT", "from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23])\n\tby userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id\n\tu4GJi6ik028341; Mon, 16 May 2016 19:44:06 GMT", "from tndave-linux.us.oracle.com (/10.154.127.160)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Mon, 16 May 2016 12:44:05 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Tushar Dave <tushar.n.dave@oracle.com>", "To": "intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com,\n\tshannon.nelson@intel.com, jeffrey.t.kirsher@intel.com,\n\tnetdev@vger.kernel.org, carolyn.wyborny@intel.com,\n\tdonald.c.skidmore@intel.com, mitch.a.williams@intel.com,\n\tbruce.w.allan@intel.com, john.ronciak@intel.com", "Date": "Mon, 16 May 2016 12:40:53 -0700", "Message-Id": "<1463427653-8148-1-git-send-email-tushar.n.dave@oracle.com>", "X-Mailer": "git-send-email 1.9.1", "X-Source-IP": "userv0021.oracle.com [156.151.31.71]", "Cc": "sowmini.varadhan@oracle.com, Tushar Dave <tushar.n.dave@oracle.com>", "Subject": "[Intel-wired-lan] [PATCH] i40e: Fix errors resulted while turning\n\toff TSO", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "On systems with 128 CPUs, turning off TSO results in errors,\n\ni40e 0000:03:00.0: failed to get tracking for 1 vectors for VSI 400, err=-12\ni40e 0000:03:00.0: Couldn't create FDir VSI\ni40e 0000:03:00.0: i40e_ptp_init: PTP not supported on eth0\ni40e 0000:03:00.0: couldn't add VEB, err I40E_ERR_ADMIN_QUEUE_ERROR aq_err I40E_AQ_RC_ENOENT\ni40e 0000:03:00.0: rebuild of switch failed: -1, will try to set up simple PF connection\ni40e 0000:03:00.0 eth0: adding 00:10:e0:8a:24:b6 vid=0\n\nEnabling FD_SB without checking availability of MSI-X vector is the\nroot cause. This change adds necessary check.\n\nSigned-off-by: Tushar Dave <tushar.n.dave@oracle.com>\n---\n drivers/net/ethernet/intel/i40e/i40e.h | 1 +\n drivers/net/ethernet/intel/i40e/i40e_main.c | 8 ++++++--\n 2 files changed, 7 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex 68f2204..80dcb5c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -270,6 +270,7 @@ struct i40e_pf {\n #endif /* I40E_FCOE */\n \tu16 num_lan_qps; /* num lan queues this PF has set up */\n \tu16 num_lan_msix; /* num queue vectors for the base PF vsi */\n+\tu16 num_fdsb_msix; /* num queue vectors for sideband Fdir */\n \tint queues_left; /* queues left unclaimed */\n \tu16 alloc_rss_size; /* allocated RSS queues */\n \tu16 rss_size_max; /* HW defined max RSS queues */\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 8f3b53e..9248863 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -7170,7 +7170,7 @@ static int i40e_set_num_rings_in_vsi(struct i40e_vsi *vsi)\n \t\tvsi->alloc_queue_pairs = 1;\n \t\tvsi->num_desc = ALIGN(I40E_FDIR_RING_COUNT,\n \t\t\t\t I40E_REQ_DESCRIPTOR_MULTIPLE);\n-\t\tvsi->num_q_vectors = 1;\n+\t\tvsi->num_q_vectors = pf->num_fdsb_msix;\n \t\tbreak;\n \n \tcase I40E_VSI_VMDQ2:\n@@ -7558,9 +7558,11 @@ static int i40e_init_msix(struct i40e_pf *pf)\n \t/* reserve one vector for sideband flow director */\n \tif (pf->flags & I40E_FLAG_FD_SB_ENABLED) {\n \t\tif (vectors_left) {\n+\t\t\tpf->num_fdsb_msix = 1;\n \t\t\tv_budget++;\n \t\t\tvectors_left--;\n \t\t} else {\n+\t\t\tpf->num_fdsb_msix = 0;\n \t\t\tpf->flags &= ~I40E_FLAG_FD_SB_ENABLED;\n \t\t}\n \t}\n@@ -8443,7 +8445,9 @@ bool i40e_set_ntuple(struct i40e_pf *pf, netdev_features_t features)\n \t\t/* Enable filters and mark for reset */\n \t\tif (!(pf->flags & I40E_FLAG_FD_SB_ENABLED))\n \t\t\tneed_reset = true;\n-\t\tpf->flags |= I40E_FLAG_FD_SB_ENABLED;\n+\t\t/* enable FD_SB only if there is MSI-X vector */\n+\t\tif (pf->num_fdsb_msix > 0)\n+\t\t\tpf->flags |= I40E_FLAG_FD_SB_ENABLED;\n \t} else {\n \t\t/* turn off filters, mark for reset and clear SW filter list */\n \t\tif (pf->flags & I40E_FLAG_FD_SB_ENABLED) {\n", "prefixes": [] }