Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/622710/?format=api
{ "id": 622710, "url": "http://patchwork.ozlabs.org/api/patches/622710/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-15-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1463419605-30746-15-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-05-16T17:26:44", "name": "[next,S37,14/15] i40e: add VSI info to macaddr messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d13f74627eb53ddaf1e8f711123cbdb0faa65b54", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-15-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/622710/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/622710/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3r7pn16tvWz9t87\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 May 2016 04:25:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 048CE9645D;\n\tMon, 16 May 2016 18:25:57 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6Q7nKcbFzcu5; Mon, 16 May 2016 18:25:49 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 806DB96464;\n\tMon, 16 May 2016 18:25:40 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 68F221BFC8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:38 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 63BEE91E41\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:38 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id flq+k62Qcv59 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id DBE3691F9E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 16 May 2016 11:25:38 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.117])\n\tby fmsmga004.fm.intel.com with ESMTP; 16 May 2016 11:25:37 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,627,1459839600\"; d=\"scan'208\";a=\"104841090\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 16 May 2016 10:26:44 -0700", "Message-Id": "<1463419605-30746-15-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S37 14/15] i40e: add VSI info to\n\tmacaddr messages", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Shannon Nelson <shannon.nelson@intel.com>\n\nSince the macaddr add and delete happens asynchronously, error\nmessages don't easily get associated to the actual request. Here\nwe add a bit of information to the error messages to help\ndetermine the source of the error.\n\nSigned-off-by: Shannon Nelson <shannon.nelson@intel.com>\nChange-ID: Id2d6df5287141c3579677d72d8bd21122823d79f\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 31 ++++++++++++++++++++---------\n 1 file changed, 22 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 16197f9..5b9a64f 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1842,6 +1842,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \tstruct i40e_hw *hw = &vsi->back->hw;\n \tbool promisc_forced_on = false;\n \tbool add_happened = false;\n+\tchar vsi_name[16] = \"PF\";\n \tint filter_list_len = 0;\n \tu32 changed_flags = 0;\n \ti40e_status aq_ret = 0;\n@@ -1869,6 +1870,11 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \tINIT_LIST_HEAD(&tmp_del_list);\n \tINIT_LIST_HEAD(&tmp_add_list);\n \n+\tif (vsi->type == I40E_VSI_SRIOV)\n+\t\tsnprintf(vsi_name, sizeof(vsi_name) - 1, \"VF %d\", vsi->vf_id);\n+\telse if (vsi->type != I40E_VSI_MAIN)\n+\t\tsnprintf(vsi_name, sizeof(vsi_name) - 1, \"vsi %d\", vsi->seid);\n+\n \tif (vsi->flags & I40E_VSI_FLAG_FILTER_CHANGED) {\n \t\tvsi->flags &= ~I40E_VSI_FLAG_FILTER_CHANGED;\n \n@@ -1963,8 +1969,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\tif (aq_ret && aq_err != I40E_AQ_RC_ENOENT) {\n \t\t\t\t\tretval = -EIO;\n \t\t\t\t\tdev_err(&pf->pdev->dev,\n-\t\t\t\t\t\t\"ignoring delete macvlan error, err %s, aq_err %s while flushing a full buffer\\n\",\n-\n+\t\t\t\t\t\t \"ignoring delete macvlan error on %s, err %s, aq_err %s while flushing a full buffer\\n\",\n+\t\t\t\t\t\t vsi_name,\n \t\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n \t\t\t\t\t\t i40e_aq_str(hw, aq_err));\n \t\t\t\t}\n@@ -1984,7 +1990,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \n \t\t\tif (aq_ret && aq_err != I40E_AQ_RC_ENOENT)\n \t\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t\t \"ignoring delete macvlan error, err %s aq_err %s\\n\",\n+\t\t\t\t\t \"ignoring delete macvlan error on %s, err %s aq_err %s\\n\",\n+\t\t\t\t\t vsi_name,\n \t\t\t\t\t i40e_stat_str(hw, aq_ret),\n \t\t\t\t\t i40e_aq_str(hw, aq_err));\n \t\t}\n@@ -2061,7 +2068,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\tif (add_happened && aq_ret && aq_err != I40E_AQ_RC_EINVAL) {\n \t\t\tretval = i40e_aq_rc_to_posix(aq_ret, aq_err);\n \t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t \"add filter failed, err %s aq_err %s\\n\",\n+\t\t\t\t \"add filter failed on %s, err %s aq_err %s\\n\",\n+\t\t\t\t vsi_name,\n \t\t\t\t i40e_stat_str(hw, aq_ret),\n \t\t\t\t i40e_aq_str(hw, aq_err));\n \t\t\tif ((hw->aq.asq_last_status == I40E_AQ_RC_ENOSPC) &&\n@@ -2070,7 +2078,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\tpromisc_forced_on = true;\n \t\t\t\tset_bit(__I40E_FILTER_OVERFLOW_PROMISC,\n \t\t\t\t\t&vsi->state);\n-\t\t\t\tdev_info(&pf->pdev->dev, \"promiscuous mode forced on\\n\");\n+\t\t\t\tdev_info(&pf->pdev->dev, \"promiscuous mode forced on %s\\n\",\n+\t\t\t\t\t vsi_name);\n \t\t\t}\n \t\t}\n \t}\n@@ -2094,7 +2103,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\tretval = i40e_aq_rc_to_posix(aq_ret,\n \t\t\t\t\t\t hw->aq.asq_last_status);\n \t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t \"set multi promisc failed, err %s aq_err %s\\n\",\n+\t\t\t\t \"set multi promisc failed on %s, err %s aq_err %s\\n\",\n+\t\t\t\t vsi_name,\n \t\t\t\t i40e_stat_str(hw, aq_ret),\n \t\t\t\t i40e_aq_str(hw, hw->aq.asq_last_status));\n \t\t}\n@@ -2129,7 +2139,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\t\tretval = i40e_aq_rc_to_posix(aq_ret,\n \t\t\t\t\t\t\thw->aq.asq_last_status);\n \t\t\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t\t\t \"Set default VSI failed, err %s, aq_err %s\\n\",\n+\t\t\t\t\t\t \"Set default VSI failed on %s, err %s, aq_err %s\\n\",\n+\t\t\t\t\t\t vsi_name,\n \t\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n \t\t\t\t\t\t i40e_aq_str(hw,\n \t\t\t\t\t\t hw->aq.asq_last_status));\n@@ -2146,7 +2157,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\ti40e_aq_rc_to_posix(aq_ret,\n \t\t\t\t\t\t hw->aq.asq_last_status);\n \t\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t\t \"set unicast promisc failed, err %s, aq_err %s\\n\",\n+\t\t\t\t\t \"set unicast promisc failed on %s, err %s, aq_err %s\\n\",\n+\t\t\t\t\t vsi_name,\n \t\t\t\t\t i40e_stat_str(hw, aq_ret),\n \t\t\t\t\t i40e_aq_str(hw,\n \t\t\t\t\t\t hw->aq.asq_last_status));\n@@ -2160,7 +2172,8 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\ti40e_aq_rc_to_posix(aq_ret,\n \t\t\t\t\t\t hw->aq.asq_last_status);\n \t\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t\t \"set multicast promisc failed, err %s, aq_err %s\\n\",\n+\t\t\t\t\t \"set multicast promisc failed on %s, err %s, aq_err %s\\n\",\n+\t\t\t\t\t vsi_name,\n \t\t\t\t\t i40e_stat_str(hw, aq_ret),\n \t\t\t\t\t i40e_aq_str(hw,\n \t\t\t\t\t\t hw->aq.asq_last_status));\n", "prefixes": [ "next", "S37", "14/15" ] }