Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/622709/?format=api
{ "id": 622709, "url": "http://patchwork.ozlabs.org/api/patches/622709/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-14-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1463419605-30746-14-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-05-16T17:26:43", "name": "[next,S37,13/15] i40e: set default VSI without a reset", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b05f8c477da78ce7f5ccba822ffd2f498a7b8f46", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-14-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/622709/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/622709/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3r7pn04Q8Dz9t7n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 May 2016 04:25:56 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id B65A79645C;\n\tMon, 16 May 2016 18:25:55 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id fO565Qy+bJfz; Mon, 16 May 2016 18:25:54 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 19797963F2;\n\tMon, 16 May 2016 18:25:47 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 2D3951BFC8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 13CB791E41\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:40 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Z4Ip+yz9DdNg for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id AD37C91EC9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 16 May 2016 11:25:38 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.117])\n\tby fmsmga004.fm.intel.com with ESMTP; 16 May 2016 11:25:37 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,627,1459839600\"; d=\"scan'208\";a=\"104841087\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 16 May 2016 10:26:43 -0700", "Message-Id": "<1463419605-30746-14-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S37 13/15] i40e: set default VSI\n\twithout a reset", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nRemove the need for a reset when the device enters limited promiscuous\nmode. This was causing heartburn for people who were using VFs and\nbridging, since this would require all of the VFs to undergo a reset\neach time the PF changed its promiscuity.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I0a83495c5e4d68112bbc7a7a076d20fa8dd3b61c\n---\nTesting Hints : Make sure default (limited) promiscuous mode works correctly \nwith bridging, and that no resets happen when entering and leaving promiscuous \nmode.\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 26 ++++++++++++++++++++++----\n 1 file changed, 22 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex b749b46..16197f9 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -2115,7 +2115,25 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t */\n \t\t\tif (pf->cur_promisc != cur_promisc) {\n \t\t\t\tpf->cur_promisc = cur_promisc;\n-\t\t\t\tset_bit(__I40E_PF_RESET_REQUESTED, &pf->state);\n+\t\t\t\tif (cur_promisc)\n+\t\t\t\t\taq_ret =\n+\t\t\t\t\t i40e_aq_set_default_vsi(hw,\n+\t\t\t\t\t\t\t\t vsi->seid,\n+\t\t\t\t\t\t\t\t NULL);\n+\t\t\t\telse\n+\t\t\t\t\taq_ret =\n+\t\t\t\t\t i40e_aq_clear_default_vsi(hw,\n+\t\t\t\t\t\t\t\t vsi->seid,\n+\t\t\t\t\t\t\t\t NULL);\n+\t\t\t\tif (aq_ret) {\n+\t\t\t\t\tretval = i40e_aq_rc_to_posix(aq_ret,\n+\t\t\t\t\t\t\thw->aq.asq_last_status);\n+\t\t\t\t\tdev_info(&pf->pdev->dev,\n+\t\t\t\t\t\t \"Set default VSI failed, err %s, aq_err %s\\n\",\n+\t\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t\t\t i40e_aq_str(hw,\n+\t\t\t\t\t\t hw->aq.asq_last_status));\n+\t\t\t\t}\n \t\t\t}\n \t\t} else {\n \t\t\taq_ret = i40e_aq_set_vsi_unicast_promiscuous(\n@@ -10127,14 +10145,14 @@ void i40e_veb_release(struct i40e_veb *veb)\n static int i40e_add_veb(struct i40e_veb *veb, struct i40e_vsi *vsi)\n {\n \tstruct i40e_pf *pf = veb->pf;\n-\tbool is_default = veb->pf->cur_promisc;\n \tbool enable_stats = !!(pf->flags & I40E_FLAG_VEB_STATS_ENABLED);\n \tint ret;\n \n-\t/* get a VEB from the hardware */\n \tret = i40e_aq_add_veb(&pf->hw, veb->uplink_seid, vsi->seid,\n-\t\t\t veb->enabled_tc, is_default,\n+\t\t\t veb->enabled_tc, false,\n \t\t\t &veb->seid, enable_stats, NULL);\n+\n+\t/* get a VEB from the hardware */\n \tif (ret) {\n \t\tdev_info(&pf->pdev->dev,\n \t\t\t \"couldn't add VEB, err %s aq_err %s\\n\",\n", "prefixes": [ "next", "S37", "13/15" ] }