Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/622702/?format=api
{ "id": 622702, "url": "http://patchwork.ozlabs.org/api/patches/622702/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-8-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1463419605-30746-8-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-05-16T17:26:37", "name": "[next,S37,07/15] i40e: Clean up MSIX irqs before suspend", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f433cf1aabcb9c80340104fabbd77b8d5ef9f1ba", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-8-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/622702/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/622702/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3r7pmn0W6nz9t7x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 May 2016 04:25:45 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 61AA795C71;\n\tMon, 16 May 2016 18:25:44 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id kwR3qXwHd3q3; Mon, 16 May 2016 18:25:43 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id C3DC89643B;\n\tMon, 16 May 2016 18:25:39 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id CE72E1BFC8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id C618191F9E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id CYizPMzuIaw3 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:36 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 869CE91F36\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:36 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 16 May 2016 11:25:36 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.117])\n\tby fmsmga004.fm.intel.com with ESMTP; 16 May 2016 11:25:36 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,627,1459839600\"; d=\"scan'208\";a=\"104841064\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 16 May 2016 10:26:37 -0700", "Message-Id": "<1463419605-30746-8-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S37 07/15] i40e: Clean up MSIX irqs\n\tbefore suspend", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Greg Rose <gregory.v.rose@intel.com>\n\nThe i40e_suspend() function calls another function that preps the device\nfor the power save and resume by freeing all the tx/rx resources and\ninterrupts but that function does not free the \"other\" causes interrupt\nvector and irq. It also fails to call synchronize_irq() before freeing\nthe irq vectors. This sometimes may result in some AER errors on those\nsystems with that PCIe error reporting feature enabled.\n\nCall synchronize_irq() before freeing irq vectors and explicitly free\nthe other causes interrupt resources and shut down that MSIX interrupt.\n\nSigned-off-by: Greg Rose <gregory.v.rose@intel.com>\nChange-ID: Ib88e4536756518a352446da0232189716618ad81\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 3439e9f..d71b6bc 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -3955,6 +3955,7 @@ static void i40e_vsi_free_irq(struct i40e_vsi *vsi)\n \t\t\t/* clear the affinity_mask in the IRQ descriptor */\n \t\t\tirq_set_affinity_hint(pf->msix_entries[vector].vector,\n \t\t\t\t\t NULL);\n+\t\t\tsynchronize_irq(pf->msix_entries[vector].vector);\n \t\t\tfree_irq(pf->msix_entries[vector].vector,\n \t\t\t\t vsi->q_vectors[i]);\n \n@@ -11535,6 +11536,8 @@ static int i40e_suspend(struct pci_dev *pdev, pm_message_t state)\n \twr32(hw, I40E_PFPM_APM, (pf->wol_en ? I40E_PFPM_APM_APME_MASK : 0));\n \twr32(hw, I40E_PFPM_WUFC, (pf->wol_en ? I40E_PFPM_WUFC_MAG_MASK : 0));\n \n+\ti40e_stop_misc_vector(pf);\n+\n \tpci_wake_from_d3(pdev, pf->wol_en);\n \tpci_set_power_state(pdev, PCI_D3hot);\n \n", "prefixes": [ "next", "S37", "07/15" ] }