Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/622700/?format=api
{ "id": 622700, "url": "http://patchwork.ozlabs.org/api/patches/622700/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-7-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1463419605-30746-7-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-05-16T17:26:36", "name": "[next,S37,06/15] i40evf: don't overflow buffer", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c7c2ce1292e7121dd7ac4b1c805f4517e1f0f63a", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-7-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/622700/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/622700/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3r7pmh3tcCz9t7x\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 May 2016 04:25:40 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D76E49644C;\n\tMon, 16 May 2016 18:25:39 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id InyWDdF9qrWB; Mon, 16 May 2016 18:25:38 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 0C1BA960C8;\n\tMon, 16 May 2016 18:25:38 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1D2971BFC8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 16EDA91FA0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ynXK+4J15b1K for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:36 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 6A47191EC9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:36 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 16 May 2016 11:25:36 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.117])\n\tby fmsmga004.fm.intel.com with ESMTP; 16 May 2016 11:25:36 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,627,1459839600\"; d=\"scan'208\";a=\"104841060\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 16 May 2016 10:26:36 -0700", "Message-Id": "<1463419605-30746-7-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S37 06/15] i40evf: don't overflow\n\tbuffer", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nIf the user adds an obscene amount of MAC addresses, the driver will run\ninto the situation where it has too many address requests to fit into a\nsingle PF message. The driver checks for this case, and calculates the\nmaximum number of messages that it can send. Then it completely ignores\nthis count and overflows the buffer.\n\nFix this by checking the address count and bailing out of the loop at\nthe appropriate time.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: If8dcbb04602c75941dc0cd8309065e1de9ca791c\n---\nTesting Hints : Add a thousand filters as quickly as possible.\n\n drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\nindex f134456..d76c221 100644\n--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c\n@@ -434,6 +434,8 @@ void i40evf_add_ether_addrs(struct i40evf_adapter *adapter)\n \t\t\tether_addr_copy(veal->list[i].addr, f->macaddr);\n \t\t\ti++;\n \t\t\tf->add = false;\n+\t\t\tif (i == count)\n+\t\t\t\tbreak;\n \t\t}\n \t}\n \tif (!more)\n@@ -497,6 +499,8 @@ void i40evf_del_ether_addrs(struct i40evf_adapter *adapter)\n \t\t\ti++;\n \t\t\tlist_del(&f->list);\n \t\t\tkfree(f);\n+\t\t\tif (i == count)\n+\t\t\t\tbreak;\n \t\t}\n \t}\n \tif (!more)\n@@ -560,6 +564,8 @@ void i40evf_add_vlans(struct i40evf_adapter *adapter)\n \t\t\tvvfl->vlan_id[i] = f->vlan;\n \t\t\ti++;\n \t\t\tf->add = false;\n+\t\t\tif (i == count)\n+\t\t\t\tbreak;\n \t\t}\n \t}\n \tif (!more)\n@@ -623,6 +629,8 @@ void i40evf_del_vlans(struct i40evf_adapter *adapter)\n \t\t\ti++;\n \t\t\tlist_del(&f->list);\n \t\t\tkfree(f);\n+\t\t\tif (i == count)\n+\t\t\t\tbreak;\n \t\t}\n \t}\n \tif (!more)\n", "prefixes": [ "next", "S37", "06/15" ] }