Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/622699/?format=api
{ "id": 622699, "url": "http://patchwork.ozlabs.org/api/patches/622699/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-3-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1463419605-30746-3-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-05-16T17:26:32", "name": "[next,S37,02/15] i40e: add hw struct local variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "09debbfc001cd0ce09f4037d8d94d0cb2ef8f1af", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1463419605-30746-3-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/622699/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/622699/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3r7pmh1Cp1z9t7n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tTue, 17 May 2016 04:25:40 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5B7AE96405;\n\tMon, 16 May 2016 18:25:39 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id u6v79bNufyFy; Mon, 16 May 2016 18:25:38 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D683C96053;\n\tMon, 16 May 2016 18:25:37 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id E464D1BFC8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:36 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id E01F131483\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:36 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id pD-GX6AByl84 for <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:35 +0000 (UTC)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby silver.osuosl.org (Postfix) with ESMTP id A8FDE33E2A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tMon, 16 May 2016 18:25:35 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga103.fm.intel.com with ESMTP; 16 May 2016 11:25:35 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.117])\n\tby fmsmga004.fm.intel.com with ESMTP; 16 May 2016 11:25:35 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.26,627,1459839600\"; d=\"scan'208\";a=\"104841041\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Mon, 16 May 2016 10:26:32 -0700", "Message-Id": "<1463419605-30746-3-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1463419605-30746-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S37 02/15] i40e: add hw struct local\n\tvariable", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nThis function uses the i40e_hw struct all over the place, so why doesn't\nit keep a pointer to the struct? Add this pointer as a local variable\nand use it consistently throughout the function.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I10eb688fe40909433fcb8ac7ac891cef67445d72\n---\nTesting Hints : No functionality change, just code simplification.\n\n drivers/net/ethernet/intel/i40e/i40e_main.c | 79 +++++++++++++++--------------\n 1 file changed, 41 insertions(+), 38 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex d091c76..ad2191c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -1845,6 +1845,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n {\n \tstruct list_head tmp_del_list, tmp_add_list;\n \tstruct i40e_mac_filter *f, *ftmp, *fclone;\n+\tstruct i40e_hw *hw = &vsi->back->hw;\n \tbool promisc_forced_on = false;\n \tbool add_happened = false;\n \tint filter_list_len = 0;\n@@ -1925,7 +1926,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \tif (!list_empty(&tmp_del_list)) {\n \t\tint del_list_size;\n \n-\t\tfilter_list_len = pf->hw.aq.asq_buf_size /\n+\t\tfilter_list_len = hw->aq.asq_buf_size /\n \t\t\t sizeof(struct i40e_aqc_remove_macvlan_element_data);\n \t\tdel_list_size = filter_list_len *\n \t\t\t sizeof(struct i40e_aqc_remove_macvlan_element_data);\n@@ -1957,12 +1958,11 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \n \t\t\t/* flush a full buffer */\n \t\t\tif (num_del == filter_list_len) {\n-\t\t\t\taq_ret = i40e_aq_remove_macvlan(&pf->hw,\n-\t\t\t\t\t\t\t\tvsi->seid,\n-\t\t\t\t\t\t\t\tdel_list,\n-\t\t\t\t\t\t\t\tnum_del,\n-\t\t\t\t\t\t\t\tNULL);\n-\t\t\t\taq_err = pf->hw.aq.asq_last_status;\n+\t\t\t\taq_ret =\n+\t\t\t\t\ti40e_aq_remove_macvlan(hw, vsi->seid,\n+\t\t\t\t\t\t\t del_list,\n+\t\t\t\t\t\t\t num_del, NULL);\n+\t\t\t\taq_err = hw->aq.asq_last_status;\n \t\t\t\tnum_del = 0;\n \t\t\t\tmemset(del_list, 0, del_list_size);\n \n@@ -1970,8 +1970,9 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\t\tretval = -EIO;\n \t\t\t\t\tdev_err(&pf->pdev->dev,\n \t\t\t\t\t\t\"ignoring delete macvlan error, err %s, aq_err %s while flushing a full buffer\\n\",\n-\t\t\t\t\t\ti40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\t\t\ti40e_aq_str(&pf->hw, aq_err));\n+\n+\t\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t\t\t i40e_aq_str(hw, aq_err));\n \t\t\t\t}\n \t\t\t}\n \t\t\t/* Release memory for MAC filter entries which were\n@@ -1982,17 +1983,16 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t}\n \n \t\tif (num_del) {\n-\t\t\taq_ret = i40e_aq_remove_macvlan(&pf->hw, vsi->seid,\n-\t\t\t\t\t\t\tdel_list, num_del,\n-\t\t\t\t\t\t\tNULL);\n-\t\t\taq_err = pf->hw.aq.asq_last_status;\n+\t\t\taq_ret = i40e_aq_remove_macvlan(hw, vsi->seid, del_list,\n+\t\t\t\t\t\t\tnum_del, NULL);\n+\t\t\taq_err = hw->aq.asq_last_status;\n \t\t\tnum_del = 0;\n \n \t\t\tif (aq_ret && aq_err != I40E_AQ_RC_ENOENT)\n \t\t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t\t \"ignoring delete macvlan error, err %s aq_err %s\\n\",\n-\t\t\t\t\t i40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\t\t i40e_aq_str(&pf->hw, aq_err));\n+\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t\t i40e_aq_str(hw, aq_err));\n \t\t}\n \n \t\tkfree(del_list);\n@@ -2003,7 +2003,7 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\tint add_list_size;\n \n \t\t/* do all the adds now */\n-\t\tfilter_list_len = pf->hw.aq.asq_buf_size /\n+\t\tfilter_list_len = hw->aq.asq_buf_size /\n \t\t\t sizeof(struct i40e_aqc_add_macvlan_element_data),\n \t\tadd_list_size = filter_list_len *\n \t\t\t sizeof(struct i40e_aqc_add_macvlan_element_data);\n@@ -2038,10 +2038,10 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \n \t\t\t/* flush a full buffer */\n \t\t\tif (num_add == filter_list_len) {\n-\t\t\t\taq_ret = i40e_aq_add_macvlan(&pf->hw, vsi->seid,\n+\t\t\t\taq_ret = i40e_aq_add_macvlan(hw, vsi->seid,\n \t\t\t\t\t\t\t add_list, num_add,\n \t\t\t\t\t\t\t NULL);\n-\t\t\t\taq_err = pf->hw.aq.asq_last_status;\n+\t\t\t\taq_err = hw->aq.asq_last_status;\n \t\t\t\tnum_add = 0;\n \n \t\t\t\tif (aq_ret)\n@@ -2056,9 +2056,9 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t}\n \n \t\tif (num_add) {\n-\t\t\taq_ret = i40e_aq_add_macvlan(&pf->hw, vsi->seid,\n+\t\t\taq_ret = i40e_aq_add_macvlan(hw, vsi->seid,\n \t\t\t\t\t\t add_list, num_add, NULL);\n-\t\t\taq_err = pf->hw.aq.asq_last_status;\n+\t\t\taq_err = hw->aq.asq_last_status;\n \t\t\tnum_add = 0;\n \t\t}\n \t\tkfree(add_list);\n@@ -2068,9 +2068,9 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\tretval = i40e_aq_rc_to_posix(aq_ret, aq_err);\n \t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"add filter failed, err %s aq_err %s\\n\",\n-\t\t\t\t i40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\t i40e_aq_str(&pf->hw, aq_err));\n-\t\t\tif ((pf->hw.aq.asq_last_status == I40E_AQ_RC_ENOSPC) &&\n+\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t i40e_aq_str(hw, aq_err));\n+\t\t\tif ((hw->aq.asq_last_status == I40E_AQ_RC_ENOSPC) &&\n \t\t\t !test_bit(__I40E_FILTER_OVERFLOW_PROMISC,\n \t\t\t\t &vsi->state)) {\n \t\t\t\tpromisc_forced_on = true;\n@@ -2098,12 +2098,11 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\t\t\t\t NULL);\n \t\tif (aq_ret) {\n \t\t\tretval = i40e_aq_rc_to_posix(aq_ret,\n-\t\t\t\t\t\t pf->hw.aq.asq_last_status);\n+\t\t\t\t\t\t hw->aq.asq_last_status);\n \t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"set multi promisc failed, err %s aq_err %s\\n\",\n-\t\t\t\t i40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\t i40e_aq_str(&pf->hw,\n-\t\t\t\t\t pf->hw.aq.asq_last_status));\n+\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t i40e_aq_str(hw, hw->aq.asq_last_status));\n \t\t}\n \t}\n \tif ((changed_flags & IFF_PROMISC) || promisc_forced_on) {\n@@ -2126,29 +2125,33 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t}\n \t\t} else {\n \t\t\taq_ret = i40e_aq_set_vsi_unicast_promiscuous(\n-\t\t\t\t\t\t\t &vsi->back->hw,\n+\t\t\t\t\t\t\t hw,\n \t\t\t\t\t\t\t vsi->seid,\n \t\t\t\t\t\t\t cur_promisc, NULL,\n \t\t\t\t\t\t\t true);\n \t\t\tif (aq_ret) {\n \t\t\t\tretval =\n \t\t\t\ti40e_aq_rc_to_posix(aq_ret,\n-\t\t\t\t\t\t pf->hw.aq.asq_last_status);\n+\t\t\t\t\t\t hw->aq.asq_last_status);\n \t\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t\t \"set unicast promisc failed, err %d, aq_err %d\\n\",\n-\t\t\t\t\t aq_ret, pf->hw.aq.asq_last_status);\n+\t\t\t\t\t \"set unicast promisc failed, err %s, aq_err %s\\n\",\n+\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t\t i40e_aq_str(hw,\n+\t\t\t\t\t\t hw->aq.asq_last_status));\n \t\t\t}\n \t\t\taq_ret = i40e_aq_set_vsi_multicast_promiscuous(\n-\t\t\t\t\t\t\t &vsi->back->hw,\n+\t\t\t\t\t\t\t hw,\n \t\t\t\t\t\t\t vsi->seid,\n \t\t\t\t\t\t\t cur_promisc, NULL);\n \t\t\tif (aq_ret) {\n \t\t\t\tretval =\n \t\t\t\ti40e_aq_rc_to_posix(aq_ret,\n-\t\t\t\t\t\t pf->hw.aq.asq_last_status);\n+\t\t\t\t\t\t hw->aq.asq_last_status);\n \t\t\t\tdev_info(&pf->pdev->dev,\n-\t\t\t\t\t \"set multicast promisc failed, err %d, aq_err %d\\n\",\n-\t\t\t\t\t aq_ret, pf->hw.aq.asq_last_status);\n+\t\t\t\t\t \"set multicast promisc failed, err %s, aq_err %s\\n\",\n+\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t\t i40e_aq_str(hw,\n+\t\t\t\t\t\t hw->aq.asq_last_status));\n \t\t\t}\n \t\t}\n \t\taq_ret = i40e_aq_set_vsi_broadcast(&vsi->back->hw,\n@@ -2159,9 +2162,9 @@ int i40e_sync_vsi_filters(struct i40e_vsi *vsi)\n \t\t\t\t\t\t pf->hw.aq.asq_last_status);\n \t\t\tdev_info(&pf->pdev->dev,\n \t\t\t\t \"set brdcast promisc failed, err %s, aq_err %s\\n\",\n-\t\t\t\t i40e_stat_str(&pf->hw, aq_ret),\n-\t\t\t\t i40e_aq_str(&pf->hw,\n-\t\t\t\t\t pf->hw.aq.asq_last_status));\n+\t\t\t\t\t i40e_stat_str(hw, aq_ret),\n+\t\t\t\t\t i40e_aq_str(hw,\n+\t\t\t\t\t\t hw->aq.asq_last_status));\n \t\t}\n \t}\n out:\n", "prefixes": [ "next", "S37", "02/15" ] }