Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/621745/?format=api
{ "id": 621745, "url": "http://patchwork.ozlabs.org/api/patches/621745/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/c74ebf3e68d0207e95f71086693916fe99f10658.1463075515.git.lucien.xin@gmail.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<c74ebf3e68d0207e95f71086693916fe99f10658.1463075515.git.lucien.xin@gmail.com>", "list_archive_url": null, "date": "2016-05-12T17:51:55", "name": "[net] driver: ixgbevf: ixgbevf_write/read_posted_mbx should use IXGBE_ERR_MBX to initialize ret_val", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c6ead3caba87b97daf52b530b9331f44aaf59ae4", "submitter": { "id": 61073, "url": "http://patchwork.ozlabs.org/api/people/61073/?format=api", "name": "Xin Long", "email": "lucien.xin@gmail.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/c74ebf3e68d0207e95f71086693916fe99f10658.1463075515.git.lucien.xin@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/621745/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/621745/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3r5Prq11lvz9t3n\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 13 May 2016 06:35:54 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 039548808F;\n\tThu, 12 May 2016 20:35:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9kGuTBe0AVWw; Thu, 12 May 2016 20:35:51 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id A82FC87D53;\n\tThu, 12 May 2016 20:35:51 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id 986ED1C1641\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 May 2016 17:51:59 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 91D048D4F1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 May 2016 17:51:59 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id YKkH03B9XIWw for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 May 2016 17:51:59 +0000 (UTC)", "from mail-pa0-f67.google.com (mail-pa0-f67.google.com\n\t[209.85.220.67])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id F03548BD5D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 May 2016 17:51:58 +0000 (UTC)", "by mail-pa0-f67.google.com with SMTP id yl2so6659782pac.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 12 May 2016 10:51:58 -0700 (PDT)", "from localhost (138.128.208.20.16clouds.com. [138.128.208.20])\n\tby smtp.gmail.com with ESMTPSA id\n\tn10sm21379805pax.18.2016.05.12.10.51.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 12 May 2016 10:51:57 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=S9GXq0+i;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id;\n\tbh=pZ7aXC67Fz2IxxdJMSyJjxrlH0ad70lCrYys6StbIQo=;\n\tb=S9GXq0+igSvzIASVoNSx0PfM6HqkngFXT/j92B+SliZqj5aa3bv8HjoZDjjWfcV9Xc\n\tMEzV+ImHeGnJW8dxibtzauMqrKNEaFPohO4MtdPybG3XISe4BwdgqKShVhI4GycKQxgu\n\t24gc10dxhCBxOccMBCK+l74RmS0EVTL21FdU6i8q44KoX4BqLEk1zT0lND0JmO9ENlht\n\tsmzvSBdkv877tpZ08CYB9/goJZRvalMWMvAuGiWUDaSq4ZpGsdrSGmpTiiOjEchwYi9X\n\tbCEmrId+sAgWFsmLy//u4K5oVYeAO/D1PW++BCqL13rVAYaQA4Z7UjDnTeT/ZJMjafcp\n\tze/w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=pZ7aXC67Fz2IxxdJMSyJjxrlH0ad70lCrYys6StbIQo=;\n\tb=ds7tlEcU+OutD4CHm5+QjeMil6QCnMVtvub+eR0CgHtEQoun0sAqma40pJCFAw72Da\n\t+z0yOEuDPCOlfJYWsGdFZKTfIqO+KYnXs6E7YgEpzkyRLLa8v+XqukuoL8g5F8X6dWb3\n\ttKER5LRIpdXzy4iVxPGlZamKq3cHgrT+n8gb682KaoQP5H6Drxz51YFEafph0Uj8lcNc\n\tFoeuiBFw4HDMztBVI/a6hvBaZBqcV4bwCzEBJ7LUm18r+V9kP3OlrUxAuzuC4PDOFsz/\n\tvWc4J2AsIaJRVo9jPkUHj54Eomzss7UgVZS1EAKXlCN3rtudrC75WCglaHSvLZqHCwan\n\tC6qQ==", "X-Gm-Message-State": "AOPr4FW9YCmV4BwZi35fK7W6Gkqn8cn/M7G+e886rF7DsQ3Mpr5htloyGD4k9eILcqum/g==", "X-Received": "by 10.66.141.103 with SMTP id rn7mr15776117pab.70.1463075518688; \n\tThu, 12 May 2016 10:51:58 -0700 (PDT)", "From": "Xin Long <lucien.xin@gmail.com>", "To": "network dev <netdev@vger.kernel.org>,\n\tintel-wired-lan@lists.osuosl.org", "Date": "Fri, 13 May 2016 01:51:55 +0800", "Message-Id": "<c74ebf3e68d0207e95f71086693916fe99f10658.1463075515.git.lucien.xin@gmail.com>", "X-Mailer": "git-send-email 2.1.0", "X-Mailman-Approved-At": "Thu, 12 May 2016 20:35:50 +0000", "Cc": "davem@davemloft.net", "Subject": "[Intel-wired-lan] [PATCH net] driver: ixgbevf:\n\tixgbevf_write/read_posted_mbx should use IXGBE_ERR_MBX to\n\tinitialize ret_val", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Now ixgbevf_write/read_posted_mbx use -IXGBE_ERR_MBX as the initiative\nreturn value, but it's incorrect, cause in ixgbevf_vlan_rx_add_vid(),\nit use err == IXGBE_ERR_MBX, the err returned from mac.ops.set_vfta,\nand in ixgbevf_set_vfta_vf, it return from write/read_posted. so we\nshould initialize err with IXGBE_ERR_MBX, instead of -IXGBE_ERR_MBX.\n\nWith this fix, the other functions that called it also can work well,\ncause they only care about if err is 0 or not.\n\nSigned-off-by: Xin Long <lucien.xin@gmail.com>\n---\n drivers/net/ethernet/intel/ixgbevf/mbx.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/mbx.c b/drivers/net/ethernet/intel/ixgbevf/mbx.c\nindex dc68fea..567ed6d 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/mbx.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/mbx.c\n@@ -85,7 +85,7 @@ static s32 ixgbevf_poll_for_ack(struct ixgbe_hw *hw)\n static s32 ixgbevf_read_posted_mbx(struct ixgbe_hw *hw, u32 *msg, u16 size)\n {\n \tstruct ixgbe_mbx_info *mbx = &hw->mbx;\n-\ts32 ret_val = -IXGBE_ERR_MBX;\n+\ts32 ret_val = IXGBE_ERR_MBX;\n \n \tif (!mbx->ops.read)\n \t\tgoto out;\n@@ -111,7 +111,7 @@ out:\n static s32 ixgbevf_write_posted_mbx(struct ixgbe_hw *hw, u32 *msg, u16 size)\n {\n \tstruct ixgbe_mbx_info *mbx = &hw->mbx;\n-\ts32 ret_val = -IXGBE_ERR_MBX;\n+\ts32 ret_val = IXGBE_ERR_MBX;\n \n \t/* exit if either we can't write or there isn't a defined timeout */\n \tif (!mbx->ops.write || !mbx->timeout)\n", "prefixes": [ "net" ] }