Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/621318/?format=api
{ "id": 621318, "url": "http://patchwork.ozlabs.org/api/patches/621318/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160511231824.22542-6-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160511231824.22542-6-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-05-11T23:18:24", "name": "[net,v2,5/5] igb: call igb_ptp_suspend/igb_ptp_resume during suspend/resume cycle", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "c7be15191505cf9eece1563ea70285453cff9db8", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160511231824.22542-6-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/621318/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/621318/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3r4sVx22Qsz9t6Z\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 12 May 2016 09:18:33 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7F81187BE9;\n\tWed, 11 May 2016 23:18:32 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id laSOHNm53tsQ; Wed, 11 May 2016 23:18:31 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id DCFA0955FD;\n\tWed, 11 May 2016 23:18:31 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 9429D1C10FA\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 23:18:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 914B58810E\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 23:18:28 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 8ueS9lieZlMK for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 23:18:27 +0000 (UTC)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 70E38955B0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 23:18:27 +0000 (UTC)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 11 May 2016 16:18:27 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.173])\n\tby orsmga001.jf.intel.com with ESMTP; 11 May 2016 16:18:27 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,609,1455004800\"; d=\"scan'208\";a=\"951359146\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Wed, 11 May 2016 16:18:24 -0700", "Message-Id": "<20160511231824.22542-6-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.8.1.493.g7b22612", "In-Reply-To": "<20160511231824.22542-1-jacob.e.keller@intel.com>", "References": "<20160511231824.22542-1-jacob.e.keller@intel.com>", "Cc": "Vidya Sagar <sagar.tv@gmail.com>", "Subject": "[Intel-wired-lan] [net v2 5/5] igb: call\n\tigb_ptp_suspend/igb_ptp_resume during suspend/resume cycle", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Properly stop the extra workqueue items and ensure that we resume\ncleanly. This is better than using igb_ptp_init and igb_ptp_stop since\nthese functions destroy the PHC device, which will cause other problems\nif we do so.\n\nReported-By: Vidya Sagar <sagar.tv@gmail.com>\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/igb/igb_main.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c\nindex 21727692bef6..16b9eb9b94b5 100644\n--- a/drivers/net/ethernet/intel/igb/igb_main.c\n+++ b/drivers/net/ethernet/intel/igb/igb_main.c\n@@ -7527,6 +7527,8 @@ static int __igb_shutdown(struct pci_dev *pdev, bool *enable_wake,\n \tif (netif_running(netdev))\n \t\t__igb_close(netdev, true);\n \n+\tigb_ptp_suspend(adapter);\n+\n \tigb_clear_interrupt_scheme(adapter);\n \n #ifdef CONFIG_PM\n@@ -7637,7 +7639,7 @@ static int igb_resume(struct device *dev)\n \t\treturn -ENOMEM;\n \t}\n \n-\tigb_reset(adapter);\n+\tigb_ptp_resume(adapter);\n \n \t/* let the f/w know that the h/w is now under the control of the\n \t * driver.\n", "prefixes": [ "net", "v2", "5/5" ] }