Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/621254/?format=api
{ "id": 621254, "url": "http://patchwork.ozlabs.org/api/patches/621254/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160511202334.6128.46021.stgit@localhost.localdomain/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160511202334.6128.46021.stgit@localhost.localdomain>", "list_archive_url": null, "date": "2016-05-11T20:23:34", "name": "[next] ixgbe: Fix VLAN features error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "3e6a0a6fcfc602b4ab8c076e24cf0d1b8734fd65", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160511202334.6128.46021.stgit@localhost.localdomain/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/621254/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/621254/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3r4nd953Yhz9ssP\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 12 May 2016 06:23:41 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A42C131A2E;\n\tWed, 11 May 2016 20:23:40 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id d37XlzOqSaFp; Wed, 11 May 2016 20:23:38 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 9EC8C2D636;\n\tWed, 11 May 2016 20:23:38 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 4B19B1C0DE5\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 20:23:37 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 450D093648\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 20:23:37 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id w5Bx-p3L0eQp for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 20:23:36 +0000 (UTC)", "from mail-pa0-f41.google.com (mail-pa0-f41.google.com\n\t[209.85.220.41])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 30E5B85903\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 20:23:36 +0000 (UTC)", "by mail-pa0-f41.google.com with SMTP id r5so21892445pag.1\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 11 May 2016 13:23:36 -0700 (PDT)", "from localhost.localdomain\n\t(static-50-53-29-36.bvtn.or.frontiernet.net. [50.53.29.36])\n\tby smtp.gmail.com with ESMTPSA id\n\ta5sm14277442pat.19.2016.05.11.13.23.34\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 11 May 2016 13:23:35 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=Hdu5Sx0f; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=WA1GS+h8kAtF1svwNhc0/i9R6gyjHBIx4CYOa7sODM4=;\n\tb=Hdu5Sx0ff3wUTGzE9+M9NjnA0RRFbSiWSvSC85/xaPhLfKe+HeGgg1jTS54wFD+Tct\n\tJiva/Q7W/hLwRqda52Wv1+jDRVt6vgnMN81/VMK7c2N1UX/XPe1w9/G1quiDHi86qAqg\n\tiIb+OFxiuQJuhMf7OcR4Au42HTHeU4zx2IQPI=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=WA1GS+h8kAtF1svwNhc0/i9R6gyjHBIx4CYOa7sODM4=;\n\tb=BTQUxf7cFvDdcwDY+iJ/x8O6Bb5jM5TuPdtoqoOlweSDi0biqDZ9rsP5G3fg/uFuu2\n\t2VTfl3pQLz3Szm9JSpfcYLep66UMzPkUOLFxuVkO3AeixXEliNHDCWfCT2nWpmQOmhzs\n\tzDYzWaWJ6j6lNIL50oC4ht5+RXFimcE8ndQsMAENCvvk85XCzK4VjIMCy3hG74WvErV8\n\ta1xbay0NKv0VR4LJaw9a+zN0sunnsXDA14IwfQQzkAVWsNPzQWTwT4stW3dTg3JhqVGZ\n\tvhrOOMbBayf/kYiY4t/qaSKZcreecb69ksakgQGvsAe6vRfs3jauZgDTtC/TVvOqO7Tk\n\tvbmA==", "X-Gm-Message-State": "AOPr4FW7AAZB8JfKtwKMw1KVoByEZmd2k/WOGcUUwcirDpMS5h+DIAPq3X62c13ZIITeCwq8", "X-Received": "by 10.66.33.1 with SMTP id n1mr7895289pai.65.1462998215853;\n\tWed, 11 May 2016 13:23:35 -0700 (PDT)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "phillip.j.schmitt@intel.com, intel-wired-lan@lists.osuosl.org,\n\talexander.duyck@gmail.com", "Date": "Wed, 11 May 2016 13:23:34 -0700", "Message-ID": "<20160511202334.6128.46021.stgit@localhost.localdomain>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next PATCH] ixgbe: Fix VLAN features error", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "It looks like at some point I somehow transposed the location of setting\nthe VLAN features in netdev->features and the configuration of the\nvlan_features. As a result the driver is now generating a warning about\nvlan_features being setup incorrectly.\n\nThis patch corrects that by placing the update of netdev->features to\ninclude the VLAN features so that it is after the point where we write\nnetdev->features into netdev->vlan_features.\n\nFixes: b83e30104bd9 (\"ixgbe/ixgbevf: Add support for GSO partial\")\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 7bbf9b12bf38..9f3677c7e96f 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -9508,15 +9508,15 @@ skip_sriov:\n \tif (pci_using_dac)\n \t\tnetdev->features |= NETIF_F_HIGHDMA;\n \n+\tnetdev->vlan_features |= netdev->features | NETIF_F_TSO_MANGLEID;\n+\tnetdev->hw_enc_features |= netdev->vlan_features;\n+\tnetdev->mpls_features |= NETIF_F_HW_CSUM;\n+\n \t/* set this bit last since it cannot be part of vlan_features */\n \tnetdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER |\n \t\t\t NETIF_F_HW_VLAN_CTAG_RX |\n \t\t\t NETIF_F_HW_VLAN_CTAG_TX;\n \n-\tnetdev->vlan_features |= netdev->features | NETIF_F_TSO_MANGLEID;\n-\tnetdev->hw_enc_features |= netdev->vlan_features;\n-\tnetdev->mpls_features |= NETIF_F_HW_CSUM;\n-\n \tnetdev->priv_flags |= IFF_UNICAST_FLT;\n \tnetdev->priv_flags |= IFF_SUPP_NOFCS;\n \n", "prefixes": [ "next" ] }