Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/618189/?format=api
{ "id": 618189, "url": "http://patchwork.ozlabs.org/api/patches/618189/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1462313600-3123-6-git-send-email-bimmy.pujari@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1462313600-3123-6-git-send-email-bimmy.pujari@intel.com>", "list_archive_url": null, "date": "2016-05-03T22:13:13", "name": "[next,S36,05/12] i40e: lie to the VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "ccf06c2816622b6f141d302a5544bf6ca47525b5", "submitter": { "id": 68919, "url": "http://patchwork.ozlabs.org/api/people/68919/?format=api", "name": "Pujari, Bimmy", "email": "bimmy.pujari@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1462313600-3123-6-git-send-email-bimmy.pujari@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/618189/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/618189/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3qzxkr6CP2z9t6L\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 4 May 2016 09:11:48 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 1508887D92;\n\tTue, 3 May 2016 23:11:48 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id D-NOqI4gCamY; Tue, 3 May 2016 23:11:47 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 99C7082975;\n\tTue, 3 May 2016 23:11:47 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 38EF61C0E66\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 May 2016 23:11:41 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 346D9896D2\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 May 2016 23:11:41 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id TvBecO34m5Fj for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 May 2016 23:11:37 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id B202B895F9\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 3 May 2016 23:11:37 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP; 03 May 2016 16:11:20 -0700", "from bimmy.jf.intel.com (HELO bimmy.linux1.jf.intel.com)\n\t([134.134.2.117])\n\tby orsmga002.jf.intel.com with ESMTP; 03 May 2016 16:11:20 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,574,1455004800\"; d=\"scan'208\";a=\"968055127\"", "From": "Bimmy Pujari <bimmy.pujari@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Tue, 3 May 2016 15:13:13 -0700", "Message-Id": "<1462313600-3123-6-git-send-email-bimmy.pujari@intel.com>", "X-Mailer": "git-send-email 2.4.11", "In-Reply-To": "<1462313600-3123-1-git-send-email-bimmy.pujari@intel.com>", "References": "<1462313600-3123-1-git-send-email-bimmy.pujari@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S36 05/12] i40e: lie to the VF", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Mitch Williams <mitch.a.williams@intel.com>\n\nIf an untrusted VF attempts to configure promiscuous mode, log a message\npointing out its naughty behavior. But then, instead of returning an\nerror to the offender, just lie to it and say everything's OK. It will\ncontinue on its way, thinking it's in promiscuous mode, but receiving no\npackets except its own.\n\nSigned-off-by: Mitch Williams <mitch.a.williams@intel.com>\nChange-ID: I63369215b1720f3c531eedfc06af86ff8c0e3dc8\n---\nTesting Hints : Configure promiscuous mode on a non-trusted VF and\nobserve the results. Make sure trusted VFs still work.\n\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 10 +++++++---\n 1 file changed, 7 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 8ab029d..333945c 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1474,12 +1474,16 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \n \tvsi = i40e_find_vsi_from_id(pf, info->vsi_id);\n \tif (!test_bit(I40E_VF_STAT_ACTIVE, &vf->vf_states) ||\n-\t !test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps) ||\n \t !i40e_vc_isvalid_vsi_id(vf, info->vsi_id)) {\n+\t\taq_ret = I40E_ERR_PARAM;\n+\t\tgoto error_param;\n+\t}\n+\tif (!test_bit(I40E_VIRTCHNL_VF_CAP_PRIVILEGE, &vf->vf_caps)) {\n \t\tdev_err(&pf->pdev->dev,\n-\t\t\t\"VF %d doesn't meet requirements to enter promiscuous mode\\n\",\n+\t\t\t\"Unprivileged VF %d is attempting to configure promiscuous mode\\n\",\n \t\t\tvf->vf_id);\n-\t\taq_ret = I40E_ERR_PARAM;\n+\t\t/* Lie to the VF on purpose. */\n+\t\taq_ret = 0;\n \t\tgoto error_param;\n \t}\n \t/* Multicast promiscuous handling*/\n", "prefixes": [ "next", "S36", "05/12" ] }