Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 616988,
    "url": "http://patchwork.ozlabs.org/api/patches/616988/?format=api",
    "web_url": "http://patchwork.ozlabs.org/project/netdev/patch/20160429224315.12418.18131.stgit@ahduyck-xeon-server/",
    "project": {
        "id": 7,
        "url": "http://patchwork.ozlabs.org/api/projects/7/?format=api",
        "name": "Linux network development",
        "link_name": "netdev",
        "list_id": "netdev.vger.kernel.org",
        "list_email": "netdev@vger.kernel.org",
        "web_url": null,
        "scm_url": null,
        "webscm_url": null,
        "list_archive_url": "",
        "list_archive_url_format": "",
        "commit_url_format": ""
    },
    "msgid": "<20160429224315.12418.18131.stgit@ahduyck-xeon-server>",
    "list_archive_url": null,
    "date": "2016-04-29T22:43:15",
    "name": "[net-next,v2,2/9] gso: Only allow GSO_PARTIAL if we can checksum the inner protocol",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "e756f81f70652c19dc20e7ba977126a73e5a7c62",
    "submitter": {
        "id": 67293,
        "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api",
        "name": "Alexander Duyck",
        "email": "aduyck@mirantis.com"
    },
    "delegate": {
        "id": 34,
        "url": "http://patchwork.ozlabs.org/api/users/34/?format=api",
        "username": "davem",
        "first_name": "David",
        "last_name": "Miller",
        "email": "davem@davemloft.net"
    },
    "mbox": "http://patchwork.ozlabs.org/project/netdev/patch/20160429224315.12418.18131.stgit@ahduyck-xeon-server/mbox/",
    "series": [],
    "comments": "http://patchwork.ozlabs.org/api/patches/616988/comments/",
    "check": "pending",
    "checks": "http://patchwork.ozlabs.org/api/patches/616988/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<netdev-owner@vger.kernel.org>",
        "X-Original-To": "patchwork-incoming@ozlabs.org",
        "Delivered-To": "patchwork-incoming@ozlabs.org",
        "Received": [
            "from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3qxTJ13k0jz9t7Z\n\tfor <patchwork-incoming@ozlabs.org>;\n\tSat, 30 Apr 2016 08:43:29 +1000 (AEST)",
            "(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752829AbcD2WnS (ORCPT <rfc822;patchwork-incoming@ozlabs.org>);\n\tFri, 29 Apr 2016 18:43:18 -0400",
            "from mail-pf0-f172.google.com ([209.85.192.172]:35807 \"EHLO\n\tmail-pf0-f172.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752111AbcD2WnR (ORCPT\n\t<rfc822;netdev@vger.kernel.org>); Fri, 29 Apr 2016 18:43:17 -0400",
            "by mail-pf0-f172.google.com with SMTP id 77so21111588pfv.2\n\tfor <netdev@vger.kernel.org>; Fri, 29 Apr 2016 15:43:16 -0700 (PDT)",
            "from [192.168.1.143] (static-50-53-29-36.bvtn.or.frontiernet.net.\n\t[50.53.29.36]) by smtp.gmail.com with ESMTPSA id\n\tm12sm26066045pfi.5.2016.04.29.15.43.15\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 29 Apr 2016 15:43:15 -0700 (PDT)"
        ],
        "Authentication-Results": "ozlabs.org; dkim=pass (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=W4/UMxAD; dkim-atps=neutral",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=mirantis.com; s=google;\n\th=subject:from:to:date:message-id:in-reply-to:references:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=W7XdH2M8+aZVRwQmu5V+8+yhl7hbUAiQ8wiphyiKSe4=;\n\tb=W4/UMxAD1yNYoLx9meiuP0Ega3ImuWqada4ZLTg1gYS7pQtfpJqd6HeDEWIRB8PVz4\n\tbuZMEun05UGn/Y+E3XoKXQeRoeygUo4581X8sefCqDDY29qGSmaTuCyIavFogoxzD0qY\n\tScVy1eRKHV6hvvNJw8S0ScCyaA611vcssLJgY=",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:date:message-id:in-reply-to\n\t:references:user-agent:mime-version:content-transfer-encoding;\n\tbh=W7XdH2M8+aZVRwQmu5V+8+yhl7hbUAiQ8wiphyiKSe4=;\n\tb=NDkMt5SLnI/Hf0dBO5VfI9yVjPkUmGqMbZYM7UYJG0ew6yJYI99d5WKbjBqdxDFFYG\n\tlPopC2PVS//OJf2RtN0x5eOtJtVCfo0ZzIkWOF29QgP2UQQ8vcm5DrrcKkgVB0HxsrVu\n\txv/UQM2QsZqnMC0RJx0odmpLYFAUrTcxFdIgkthUqY9Cf+9xDyW5oNR3GpsrylbEzmVa\n\tdYY7CLdO0vsrQrUBKzU58D9cYbLf+m/ijVJSm5g8eTQbX0xXwMlQN4hW/05TBXSMc212\n\t0oOFc9Dv5uGFLJv0DNi0/qmWp2ZdBA4FVaEjV2oexjnFkQ7aJQD5RqupS2RUJzEh99il\n\tgRrQ==",
        "X-Gm-Message-State": "AOPr4FXU1uXh8uXHWQki7scQyJjaINGUbOirtQXEsdDASj4SlrNrkkJe8AI0WHhatHdCHjYu",
        "X-Received": "by 10.98.21.136 with SMTP id 130mr32694305pfv.51.1461969796296; \n\tFri, 29 Apr 2016 15:43:16 -0700 (PDT)",
        "Subject": "[net-next PATCH v2 2/9] gso: Only allow GSO_PARTIAL if we can\n\tchecksum the inner protocol",
        "From": "Alexander Duyck <aduyck@mirantis.com>",
        "To": "talal@mellanox.com, netdev@vger.kernel.org,\n\tmichael.chan@broadcom.com, davem@davemloft.net, galp@mellanox.com,\n\togerlitz@mellanox.com, eranbe@mellanox.com",
        "Date": "Fri, 29 Apr 2016 15:43:15 -0700",
        "Message-ID": "<20160429224315.12418.18131.stgit@ahduyck-xeon-server>",
        "In-Reply-To": "<20160429222735.12418.61229.stgit@ahduyck-xeon-server>",
        "References": "<20160429222735.12418.61229.stgit@ahduyck-xeon-server>",
        "User-Agent": "StGit/0.17.1-dirty",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain; charset=\"utf-8\"",
        "Content-Transfer-Encoding": "7bit",
        "Sender": "netdev-owner@vger.kernel.org",
        "Precedence": "bulk",
        "List-ID": "<netdev.vger.kernel.org>",
        "X-Mailing-List": "netdev@vger.kernel.org"
    },
    "content": "This patch addresses a possible issue that can occur if we get into any odd\ncorner cases where we support TSO for a given protocol but not the checksum\nor scatter-gather offload.  There are few drivers floating around that\nsetup their tunnels this way and by enforcing the checksum piece we can\navoid mangling any frames.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n net/core/skbuff.c |    6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/net/core/skbuff.c b/net/core/skbuff.c\nindex 7a1d48983f81..954741873877 100644\n--- a/net/core/skbuff.c\n+++ b/net/core/skbuff.c\n@@ -3080,8 +3080,7 @@ struct sk_buff *skb_segment(struct sk_buff *head_skb,\n \tunsigned int headroom;\n \tunsigned int len = head_skb->len;\n \t__be16 proto;\n-\tbool csum;\n-\tint sg = !!(features & NETIF_F_SG);\n+\tbool csum, sg;\n \tint nfrags = skb_shinfo(head_skb)->nr_frags;\n \tint err = -ENOMEM;\n \tint i = 0;\n@@ -3093,13 +3092,14 @@ struct sk_buff *skb_segment(struct sk_buff *head_skb,\n \tif (unlikely(!proto))\n \t\treturn ERR_PTR(-EINVAL);\n \n+\tsg = !!(features & NETIF_F_SG);\n \tcsum = !!can_checksum_protocol(features, proto);\n \n \t/* GSO partial only requires that we trim off any excess that\n \t * doesn't fit into an MSS sized block, so take care of that\n \t * now.\n \t */\n-\tif (features & NETIF_F_GSO_PARTIAL) {\n+\tif (sg && csum && (features & NETIF_F_GSO_PARTIAL)) {\n \t\tpartial_segs = len / mss;\n \t\tmss *= partial_segs;\n \t}\n",
    "prefixes": [
        "net-next",
        "v2",
        "2/9"
    ]
}