Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/616925/?format=api
{ "id": 616925, "url": "http://patchwork.ozlabs.org/api/patches/616925/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1461951855-2038011-1-git-send-email-arnd@arndb.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1461951855-2038011-1-git-send-email-arnd@arndb.de>", "list_archive_url": null, "date": "2016-04-29T17:44:05", "name": "i40e: fix misleading indentation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d2872d8215d834f858233c583c89d26ee7c47f16", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1461951855-2038011-1-git-send-email-arnd@arndb.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/616925/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/616925/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qxLgK6LnKz9t3p\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 30 Apr 2016 03:44:45 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D3D2E91E69;\n\tFri, 29 Apr 2016 17:44:44 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id wtg2J3Mo2a9l; Fri, 29 Apr 2016 17:44:44 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 349E591E6A;\n\tFri, 29 Apr 2016 17:44:44 +0000 (UTC)", "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ash.osuosl.org (Postfix) with ESMTP id C18891C0FD0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Apr 2016 17:44:42 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id B9B3691E75\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Apr 2016 17:44:42 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 2+lAMpvp-9nF for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Apr 2016 17:44:41 +0000 (UTC)", "from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75])\n\tby whitealder.osuosl.org (Postfix) with ESMTPS id 3B36591E69\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 29 Apr 2016 17:44:40 +0000 (UTC)", "from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de\n\t(mreue102) with ESMTPA (Nemesis) id 0MHYCK-1azUFZ0yGy-003Ink;\n\tFri, 29 Apr 2016 19:44:25 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Fri, 29 Apr 2016 19:44:05 +0200", "Message-Id": "<1461951855-2038011-1-git-send-email-arnd@arndb.de>", "X-Mailer": "git-send-email 2.7.0", "X-Provags-ID": "V03:K0:ibwgAax0uK5taTbKV/Gu3F65Ti1fty5Nt0J8Zp4c7qr2S9f20Vb\n\tOJWXwJL5wVt9yJQ1AEwcbl5J5CcXSXtTjKm6MqUgcyOM/a39pFJVMchAhAAZG+pknbYXJBd\n\t9nLob+WgwucGxs6sjksigjuEigchtq4cTXV92ujN5EylavFpZGp2SGyq7yjxyZERyKXeMtc\n\tEcgZlulFSygadO6Nj/1FA==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:OkHH82tMlO0=:QYSSc4q8Y3+7H+VH3m0a0s\n\th35fwJcYvHAKMDF/uAtCuepRteoIaBbljWi9AcnANb1cfwOngniTLoe2sU7Ux2mOUieFkD+G/\n\tp8nj0zByHagk9XhRFt5nToPU7xEGh0H/TrVw6lfn5CHxZnui/+LB1BTxT0Xe+o4lnX9rPKaws\n\tDidWrsE9YHL3ks3HR5NEu4udbMsAk/yYGqklQ2+OGq/rJAskscxu9LCHLK1QLKeiKwVMOxV9N\n\tVRxFDaOVcry2RRhsOLUvKZR35NIu7aSAFKb4JL7aNbXMoDEG19ai8/YGoXGjkzMMixI1lMPGN\n\tNP1/aXStgxrNJc18CiHHxvv13J8uki4l+W1m1nVRBp2vSyD9Y2dLr99Sa7qvOqkNqdWMZRAka\n\tOuWo+VCLDl+1Ob9E+1xcKp+Z8STnu0OnBO/G2ry6M8I7qZejmjk5btsXz3IYjftPKcSVSQeKA\n\t7PnsNyQdExHNTj42ohZnhF0VX+f4VOLz0lN9qXdlH7FzH4ys6gmf51BF3/OL8jlLqRIpJTJqt\n\tI+L68hDAHQgLgCmvI2dKmKyAAjoLVvmN6licvnhU51C6gKoMY9nQGdPeG0AxjvBPbzsEqtMX1\n\tRvFS+6U3aD4pRGrbsGwJ/eIMfN9xq+ef8wuJP2AtuM8IleozKYyLp8qmhLQ75fJ6uEuGPvO2s\n\tgPpVGVGKztPbLHZzeEUocOF4wKP4GVbT9H56647C2q0h6O3PgmFEcnijO/AiiM0ZUf8E=", "Cc": "Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] i40e: fix misleading indentation", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Newly added code in i40e_vc_config_promiscuous_mode_msg() is indented\nin a way that gcc rightly complains about:\n\ndrivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function 'i40e_vc_config_promiscuous_mode_msg':\ndrivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1543:4: error: this 'if' clause does not guard... [-Werror=misleading-indentation]\n if (f->vlan >= 0 && f->vlan <= I40E_MAX_VLANID)\n ^~\ndrivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1550:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'\n aq_err = pf->hw.aq.asq_last_status;\n\nFrom the context, it looks like the aq_err assignment was meant to be\ninside of the conditional expression, so I'm adding the appropriate\ncurly braces now.\n\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\nFixes: 5676a8b9cd9a (\"i40e: Add VF promiscuous mode driver support\")\n---\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex c226c2dad247..30f9cc404707 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -1540,7 +1540,7 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \t} else if (i40e_getnum_vf_vsi_vlan_filters(vsi)) {\n \t\tlist_for_each_entry(f, &vsi->mac_filter_list, list) {\n \t\t\taq_ret = 0;\n-\t\t\tif (f->vlan >= 0 && f->vlan <= I40E_MAX_VLANID)\n+\t\t\tif (f->vlan >= 0 && f->vlan <= I40E_MAX_VLANID) {\n \t\t\t\taq_ret =\n \t\t\t\ti40e_aq_set_vsi_uc_promisc_on_vlan(hw,\n \t\t\t\t\t\t\t\t vsi->seid,\n@@ -1548,6 +1548,7 @@ static int i40e_vc_config_promiscuous_mode_msg(struct i40e_vf *vf,\n \t\t\t\t\t\t\t\t f->vlan,\n \t\t\t\t\t\t\t\t NULL);\n \t\t\t\taq_err = pf->hw.aq.asq_last_status;\n+\t\t\t}\n \t\t\tif (aq_ret)\n \t\t\t\tdev_err(&pf->pdev->dev,\n \t\t\t\t\t\"Could not add VLAN %d to Unicast promiscuous domain err %s aq_err %s\\n\",\n", "prefixes": [] }