Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/615393/?format=api
{ "id": 615393, "url": "http://patchwork.ozlabs.org/api/patches/615393/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/4C5EDC162D52824D9E7FB1446983F3EE962AF43C@ORSMSX116.amr.corp.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<4C5EDC162D52824D9E7FB1446983F3EE962AF43C@ORSMSX116.amr.corp.intel.com>", "list_archive_url": null, "date": "2016-04-26T23:29:29", "name": "ixgbevf: Remove unused parameter", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "27e405baba62424fb63ac031b7ec9bf5fad9a8e8", "submitter": { "id": 68875, "url": "http://patchwork.ozlabs.org/api/people/68875/?format=api", "name": "Tony Nguyen", "email": "anthony.l.nguyen@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/4C5EDC162D52824D9E7FB1446983F3EE962AF43C@ORSMSX116.amr.corp.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/615393/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/615393/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qvfSf2P4qz9t7b\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 27 Apr 2016 09:29:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 4A1E68AC3B;\n\tTue, 26 Apr 2016 23:29:36 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AifQolCNXpPD; Tue, 26 Apr 2016 23:29:34 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id D2E368A2B2;\n\tTue, 26 Apr 2016 23:29:34 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3E35F1C1FEC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 26 Apr 2016 23:29:34 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 39CB786188\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 26 Apr 2016 23:29:34 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id SovCzGO7gFc0 for <intel-wired-lan@lists.osuosl.org>;\n\tTue, 26 Apr 2016 23:29:33 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 6959C86E6A\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tTue, 26 Apr 2016 23:29:33 +0000 (UTC)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga104.fm.intel.com with ESMTP; 26 Apr 2016 16:29:32 -0700", "from orsmsx104.amr.corp.intel.com ([10.22.225.131])\n\tby orsmga002.jf.intel.com with ESMTP; 26 Apr 2016 16:29:30 -0700", "from orsmsx112.amr.corp.intel.com (10.22.240.13) by\n\tORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP\n\tServer (TLS) id 14.3.248.2; Tue, 26 Apr 2016 16:29:30 -0700", "from orsmsx116.amr.corp.intel.com ([169.254.7.175]) by\n\tORSMSX112.amr.corp.intel.com ([169.254.3.229]) with mapi id\n\t14.03.0248.002; Tue, 26 Apr 2016 16:29:29 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,538,1455004800\"; d=\"scan'208\";a=\"963387259\"", "From": "\"Nguyen, Anthony L\" <anthony.l.nguyen@intel.com>", "To": "\"intel-wired-lan@lists.osuosl.org\" <intel-wired-lan@lists.osuosl.org>", "Thread-Topic": "[PATCH] ixgbevf: Remove unused parameter", "Thread-Index": "AdGgEx8TVEqYheARRque6pz7UPiTlw==", "Date": "Tue, 26 Apr 2016 23:29:29 +0000", "Message-ID": "<4C5EDC162D52824D9E7FB1446983F3EE962AF43C@ORSMSX116.amr.corp.intel.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-titus-metadata-40": "eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODFmNTdmODMtNzk3OC00MzdjLTljMjctNGU1YTIzZDU2MGVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImcweEFUaENFZTRnOCt3UTRSS1FEUjd0YVJuTUtTMTFEazJBSktVNDJcL3BJPSJ9", "x-ctpclassification": "CTP_IC", "x-originating-ip": "[10.22.254.140]", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbevf: Remove unused parameter", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "ixgbevf_update_xcast_mode() is not using the netdev parameter; removing it since it's unnecessary.\n\nSigned-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-\n drivers/net/ethernet/intel/ixgbevf/vf.c | 4 +---\n drivers/net/ethernet/intel/ixgbevf/vf.h | 2 +-\n 3 files changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 007cbe0..bcbadac 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -1908,7 +1908,7 @@ static void ixgbevf_set_rx_mode(struct net_device *netdev)\n \n \tspin_lock_bh(&adapter->mbx_lock);\n \n-\thw->mac.ops.update_xcast_mode(hw, netdev, xcast_mode);\n+\thw->mac.ops.update_xcast_mode(hw, xcast_mode);\n \n \t/* reprogram multicast list */\n \thw->mac.ops.update_mc_addr_list(hw, netdev); diff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex 4d613a4..9511da0 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -475,13 +475,11 @@ static s32 ixgbevf_update_mc_addr_list_vf(struct ixgbe_hw *hw,\n /**\n * ixgbevf_update_xcast_mode - Update Multicast mode\n * @hw: pointer to the HW structure\n- * @netdev: pointer to net device structure\n * @xcast_mode: new multicast mode\n *\n * Updates the Multicast Mode of VF.\n **/\n-static s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw,\n-\t\t\t\t struct net_device *netdev, int xcast_mode)\n+static s32 ixgbevf_update_xcast_mode(struct ixgbe_hw *hw, int \n+xcast_mode)\n {\n \tstruct ixgbe_mbx_info *mbx = &hw->mbx;\n \tu32 msgbuf[2];\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/vf.h b/drivers/net/ethernet/intel/ixgbevf/vf.h\nindex ef9f773..a407c15 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.h\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.h\n@@ -63,7 +63,7 @@ struct ixgbe_mac_operations {\n \ts32 (*set_uc_addr)(struct ixgbe_hw *, u32, u8 *);\n \ts32 (*init_rx_addrs)(struct ixgbe_hw *);\n \ts32 (*update_mc_addr_list)(struct ixgbe_hw *, struct net_device *);\n-\ts32 (*update_xcast_mode)(struct ixgbe_hw *, struct net_device *, int);\n+\ts32 (*update_xcast_mode)(struct ixgbe_hw *, int);\n \ts32 (*enable_mc)(struct ixgbe_hw *);\n \ts32 (*disable_mc)(struct ixgbe_hw *);\n \ts32 (*clear_vfta)(struct ixgbe_hw *);\n", "prefixes": [] }