Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/613857/?format=api
{ "id": 613857, "url": "http://patchwork.ozlabs.org/api/patches/613857/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/1461358223-18312-6-git-send-email-s.martin49@gmail.com/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1461358223-18312-6-git-send-email-s.martin49@gmail.com>", "list_archive_url": null, "date": "2016-04-22T20:50:17", "name": "[v9,05/11] core: add {TARGET, STAGING}_SANITIZE_RPATH_HOOK to TARGET_FINALIZE_HOOKS", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "dc93a108c5893fe7a07e54c040d7b8813313f877", "submitter": { "id": 12868, "url": "http://patchwork.ozlabs.org/api/people/12868/?format=api", "name": "Samuel Martin", "email": "s.martin49@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/1461358223-18312-6-git-send-email-s.martin49@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/613857/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/613857/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3qs77R0fyfz9sCk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Apr 2016 06:50:59 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 45095966B3;\n\tFri, 22 Apr 2016 20:50:58 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 1iRFwTl6Svna; Fri, 22 Apr 2016 20:50:56 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id BD77B96679;\n\tFri, 22 Apr 2016 20:50:48 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 187061C1750\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:43 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 14ABEC0644\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:43 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id bEdW6lUHSzwq for <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:41 +0000 (UTC)", "from mail-wm0-f66.google.com (mail-wm0-f66.google.com\n\t[74.125.82.66])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id DE3F5C002F\n\tfor <buildroot@buildroot.org>; Fri, 22 Apr 2016 20:50:40 +0000 (UTC)", "by mail-wm0-f66.google.com with SMTP id e201so6947206wme.2\n\tfor <buildroot@buildroot.org>; Fri, 22 Apr 2016 13:50:40 -0700 (PDT)", "from bobook.localdomain (ivr94-4-82-229-165-48.fbx.proxad.net.\n\t[82.229.165.48]) by smtp.gmail.com with ESMTPSA id\n\tiv1sm9826507wjb.34.2016.04.22.13.50.37\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 22 Apr 2016 13:50:38 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=jJW/IuS6;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=N+5dngi/IqSt6VJne6sAOlXhw+tHweiMpNEphHEt7oA=;\n\tb=jJW/IuS6lcwbZ2yyxoKpXF8NsAU3skka8SqGcUk9rILeWC+3eff3Ba41gHSxcMUxrJ\n\tzgEzUDCMiqz22ol3VxTFdAwPGOUej0StUaDYNALbz3Vg5ZJNY5XhAxgsiUZi/KSmuBti\n\t/+upUOthsrJbrlYSljletMsRK3oeAxbrIg/IBEESn4K+YSxCLJDQbzCQdV0OA5HLlbPB\n\tS8vCkd6vqxuBa18Zp0jtB7ZLJsaB2hnWe073cRAla16K/y3EBEiGSbFH0fQ31PfekJWb\n\tR19C9IHTvoEY4T8qtwQiuO3Rtskh0GIYYdGkPnnoud+0sc7JIja6MOUGE7jEPUmNAfbf\n\tMthw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=N+5dngi/IqSt6VJne6sAOlXhw+tHweiMpNEphHEt7oA=;\n\tb=LK5Mw2M31/ZODr1KjGO4jLXnkDk86/BF0PVzaNX/xmkwJS/SNSGay1+Arv0KPX5U+M\n\txG3R0BgOWzVG7Yj6IM2kfb5aA3lq+BpvWM6lbGjw3hyW4BbQ/mLRjj81CQYRfuXmV0m6\n\tLbkmK5aEh98Y5iraba6opyuK9gCslWSfAh2afaN5PLhizvpfUdynesW4s0MK2Av81p7o\n\tWYhj/n1cCSNSLxL/A3pZeppEIjdeK1zasFfEvilKIjnhDpX/ycOdwKJ6UWaxcG8M865r\n\tnuJg0cp3bMZPr2hQnsDbr3HElwmaVa63GRlDC8pfViuX8g5vLD1+8/+8Cx/EhUNFOYzm\n\tHpTQ==", "X-Gm-Message-State": "AOPr4FW1kvWvrVEG5OPaJxV6dQQCnVHFqMs0UYriqVRdQxP00Tbv4UCGd1fpuXCOfkPRmQ==", "X-Received": "by 10.194.227.1 with SMTP id rw1mr21721255wjc.62.1461358239524; \n\tFri, 22 Apr 2016 13:50:39 -0700 (PDT)", "From": "Samuel Martin <s.martin49@gmail.com>", "To": "buildroot@buildroot.org", "Date": "Fri, 22 Apr 2016 22:50:17 +0200", "Message-Id": "<1461358223-18312-6-git-send-email-s.martin49@gmail.com>", "X-Mailer": "git-send-email 2.8.0", "In-Reply-To": "<1461358223-18312-1-git-send-email-s.martin49@gmail.com>", "References": "<1461358223-18312-1-git-send-email-s.martin49@gmail.com>", "Subject": "[Buildroot] [PATCH v9 05/11] core: add {TARGET,\n\tSTAGING}_SANITIZE_RPATH_HOOK to TARGET_FINALIZE_HOOKS", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "This patch introduces the TARGET_SANITIZE_RPATH_HOOK and\nSTAGING_SANITIZE_RPATH_HOOK hooks fixing the ELF files' RPATH of\nbinaries from, respectively, the TARGET_DIR and the STAGING_DIR\nlocations.\n\nIt is a fair assumption that all target package has been built before\nreaching the target-finalize target; hence the execution of these hooks\nas TARGET_FINALIZE_HOOKS.\n\nAfter running these hooks, the RPATH from any target ELF files from both\nthe target and the staging locations won't contain any occurrence of the\nsysroot or some build locations.\n\nSigned-off-by: Samuel Martin <s.martin49@gmail.com>\n\n---\nchanges v8->v9:\n- none\n\nchanges v7->v8:\n- none\n\nchanges v6->v7:\n- remove the DEBUG env. var. specific handling in Makefile\n\nchanges v5->v6:\n- update for the new script version\n- add debug mode support\n\nchanges v4->v5:\n- target hook now sanitizes the rpath (Baruch)\n- add verbose support\n- update comment\n\nchanges v3->v4:\n- rebase\n- add comment\n\nchanges v2->v3:\n- move hook in Makefile (Baruch)\n---\n Makefile | 18 ++++++++++++++++++\n 1 file changed, 18 insertions(+)", "diff": "diff --git a/Makefile b/Makefile\nindex 0c9bb98..e92826f 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -651,6 +651,24 @@ endef\n TARGET_FINALIZE_HOOKS += PURGE_LOCALES\n endif\n \n+# Function sanitizing target/staging ELF files' RPATH.\n+# i.e. it removes paths pointing to the staging or build location from the ELF\n+# files' RPATH.\n+define TARGET_SANITIZE_RPATH_HOOK\n+\tPATCHELF=$(HOST_DIR)/usr/bin/patchelf \\\n+\tREADELF=$(TARGET_READELF) \\\n+\t$(TOPDIR)/support/scripts/fix-rpath target $(TARGET_DIR)\n+endef\n+\n+define STAGING_SANITIZE_RPATH_HOOK\n+\tPATCHELF=$(HOST_DIR)/usr/bin/patchelf \\\n+\tREADELF=$(TARGET_READELF) \\\n+\t$(TOPDIR)/support/scripts/fix-rpath staging $(STAGING_DIR)\n+endef\n+\n+TARGET_FINALIZE_HOOKS += TARGET_SANITIZE_RPATH_HOOK \\\n+ STAGING_SANITIZE_RPATH_HOOK\n+\n $(TARGETS_ROOTFS): target-finalize\n \n target-finalize: $(PACKAGES)\n", "prefixes": [ "v9", "05/11" ] }