Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/613856/?format=api
{ "id": 613856, "url": "http://patchwork.ozlabs.org/api/patches/613856/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/1461358223-18312-5-git-send-email-s.martin49@gmail.com/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1461358223-18312-5-git-send-email-s.martin49@gmail.com>", "list_archive_url": null, "date": "2016-04-22T20:50:16", "name": "[v9,04/11] core: sanitize HOST_DIR at the very end of the build", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "1398a31707611585eefdd837b7e1528c97a57e33", "submitter": { "id": 12868, "url": "http://patchwork.ozlabs.org/api/people/12868/?format=api", "name": "Samuel Martin", "email": "s.martin49@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/1461358223-18312-5-git-send-email-s.martin49@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/613856/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/613856/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3qs77M3p03z9sCk\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Apr 2016 06:50:55 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id CBE9B96675;\n\tFri, 22 Apr 2016 20:50:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id AJN+sN25GDCX; Fri, 22 Apr 2016 20:50:52 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 04B929667E;\n\tFri, 22 Apr 2016 20:50:46 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1868E1C1750\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:40 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 15D6233884\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:40 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9oV8V+AfW16U for <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:39 +0000 (UTC)", "from mail-wm0-f68.google.com (mail-wm0-f68.google.com\n\t[74.125.82.68])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 28BB93387F\n\tfor <buildroot@buildroot.org>; Fri, 22 Apr 2016 20:50:39 +0000 (UTC)", "by mail-wm0-f68.google.com with SMTP id n3so7846399wmn.1\n\tfor <buildroot@buildroot.org>; Fri, 22 Apr 2016 13:50:39 -0700 (PDT)", "from bobook.localdomain (ivr94-4-82-229-165-48.fbx.proxad.net.\n\t[82.229.165.48]) by smtp.gmail.com with ESMTPSA id\n\tiv1sm9826507wjb.34.2016.04.22.13.50.36\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 22 Apr 2016 13:50:36 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=TvxuINkU;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=AHox3ZRKjIzA+rKOI+LJGyqrcbn/SDHeNpPBEZF7f9k=;\n\tb=TvxuINkUw1NSVfklVSRa44034/JI+EkA06nyzIPh+vU0YTcsbo04yu6jVfn0PWUdZv\n\txNX41M6MvmtvZh6JLM/CNYfRTczLqzdkBRi91hQLhlEd6zNEYau+PAd9kIbKrM9s1RXJ\n\txfuDLCJcic4BHhCPtyYn2i+14UsO3JBScdJmGtFuwFPByc94zHdvnKma/r9tx2VSl0tX\n\tbSz5gt6QiHHgd0koibwNQa3+lGKcXt47hOCZax6b14zxTJHPHrd+vSRZ8FS9VvUB7xF4\n\t43yhgisg7j/0x6wKLUuZZr9TsXePuhJWxX0xGAJWAWoaGYavmacB7vxa+K8UlwCPy/P7\n\tfcnQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=AHox3ZRKjIzA+rKOI+LJGyqrcbn/SDHeNpPBEZF7f9k=;\n\tb=jVdQKOjxb181cDTQoF4EMcAlNvXXnoxDy16DvjVAcQi0NVQkdJgKvK7DUXSR/xtZ8+\n\twkKaujOkQ9YYEz5/lCQc0RZt9x03ek+/BmZErWt0xD4BH2VeDfsVjkfhsreSKqHz3uE1\n\tl4C0Ij1yJPGvkhGceM+8vj2uocXplDy459cNmoUoabCTnfe1KFM52rJzMNdrkqRcTlVV\n\trY+EAVLzGUUAl7hrUH4qXqR/mp050b5vTplszWxU+ufGa/KujURGB0C9lseHAsNQ6EKy\n\tHSOaXRA0dmJCOCQkwXisFFn9wCwFBIkhXmXtYTZo1dUo/n/tmavSBs9uFWAi8m3aS7KM\n\t4+Qw==", "X-Gm-Message-State": "AOPr4FU0zN5A9P5isfEre20rBFr3tei+BUsVNu5ITyFKvJpy7aA6arKxw0HZbYHsO5vQyA==", "X-Received": "by 10.28.12.149 with SMTP id 143mr5444230wmm.51.1461358237780;\n\tFri, 22 Apr 2016 13:50:37 -0700 (PDT)", "From": "Samuel Martin <s.martin49@gmail.com>", "To": "buildroot@buildroot.org", "Date": "Fri, 22 Apr 2016 22:50:16 +0200", "Message-Id": "<1461358223-18312-5-git-send-email-s.martin49@gmail.com>", "X-Mailer": "git-send-email 2.8.0", "In-Reply-To": "<1461358223-18312-1-git-send-email-s.martin49@gmail.com>", "References": "<1461358223-18312-1-git-send-email-s.martin49@gmail.com>", "Subject": "[Buildroot] [PATCH v9 04/11] core: sanitize HOST_DIR at the very\n\tend of the build", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "This patch adds host-patchelf to the list of package to build, and use\nit in the SANITIZE_RPATH_HOST helper.\n\nThis SANITIZE_RPATH_HOST helper is executed in the world target, which\nensure:\n- to be built after the target-post-image target (because of the\n dependency);\n- to always be built since it is the only dependency of the all (and\n default) target.\n\nThe SANITIZE_RPATH_HOST helper fixes the ELF files' RPATH from the\nHOST_DIR location (excluding the sysroot).\n\nAfter running this helper is run, the RPATH from any host ELF files is\nrelative to the binary location itself.\n\nNotes:\n- we avoid to fix RPATH in the sysroot.\n- we do not try to fix RPATH in the external toolchain installation\n location as they may have been built in a way, this is already\n correct; furthermore, attempting to fix RPATH in those programs may\n result in breaking them.\n- the whole host directory is processed because a number of\n host-package install programs that could be useful in places\n different from $(HOST_DIR)/{bin,sbin,usr/bin,usr/sbin}.\n- the shared libraries are also processed in case they have a 'main'\n function.\n\nAs a step toward a fully relocatable SDK, this change allows to get the\ntoolchain relocatable, but not yet the whole SDK.\n\nSigned-off-by: Samuel Martin <s.martin49@gmail.com>\n\n---\nchanges v8->v9:\n- remove irrelevant comment (ThomasP)\n- move the helper call to the world target instead of as a\n target-finalize hooks (ThomasP)\n\nchanges v7->v8:\n- none\n\nchanges v6->v7:\n- remove the DEBUG env. var. specific handling in Makefile, now just\n place the variable in the Buildroot environment, to enable debug logs.\n This is documented in a follow-up patch of this series.\n\nchanges v5->v6:\n- update for the new script version\n- add debug mode support\n\nchanges v4->v5:\n- add verbose support\n\nchanges v3->v4:\n- add host-patchelf to PACKAGES instead of target-finalize (Baruch)\n- add comment\n\nchanges v2->v3:\n- move hook in Makefile (Baruch)\n---\n Makefile | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/Makefile b/Makefile\nindex a05b9e1..0c9bb98 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -526,7 +526,20 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(BR2_CONFIG)\n \n prepare: $(BUILD_DIR)/buildroot-config/auto.conf\n \n+# RPATH fixing\n+# - The host hook sets RPATH in host ELF binaries, using relative paths to the\n+# library locations.\n+PACKAGES += host-patchelf\n+\n+define SANITIZE_RPATH_HOST\n+\tPATCHELF=$(HOST_DIR)/usr/bin/patchelf \\\n+\tREADELF=readelf \\\n+\t$(TOPDIR)/support/scripts/fix-rpath host $(HOST_DIR)\n+endef\n+\n world: target-post-image\n+\t@$(call MESSAGE,\"Rendering the SDK relocatable\")\n+\t$(SANITIZE_RPATH_HOST)\n \n .PHONY: all world toolchain dirs clean distclean source outputmakefile \\\n \tlegal-info legal-info-prepare legal-info-clean printvars help \\\n", "prefixes": [ "v9", "04/11" ] }