Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/613853/?format=api
{ "id": 613853, "url": "http://patchwork.ozlabs.org/api/patches/613853/?format=api", "web_url": "http://patchwork.ozlabs.org/project/buildroot/patch/1461358223-18312-2-git-send-email-s.martin49@gmail.com/", "project": { "id": 27, "url": "http://patchwork.ozlabs.org/api/projects/27/?format=api", "name": "Buildroot development", "link_name": "buildroot", "list_id": "buildroot.buildroot.org", "list_email": "buildroot@buildroot.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1461358223-18312-2-git-send-email-s.martin49@gmail.com>", "list_archive_url": null, "date": "2016-04-22T20:50:13", "name": "[v9,01/11] core: split variables definition related to in/out-of-tree build from O itself", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d91c90387c77b97d330dfe0fe3a68514cf929cdd", "submitter": { "id": 12868, "url": "http://patchwork.ozlabs.org/api/people/12868/?format=api", "name": "Samuel Martin", "email": "s.martin49@gmail.com" }, "delegate": null, "mbox": "http://patchwork.ozlabs.org/project/buildroot/patch/1461358223-18312-2-git-send-email-s.martin49@gmail.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/613853/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/613853/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<buildroot-bounces@busybox.net>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "buildroot@lists.busybox.net" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "buildroot@osuosl.org" ], "Received": [ "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ozlabs.org (Postfix) with ESMTP id 3qs7712f0sz9sCj\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSat, 23 Apr 2016 06:50:37 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8319D9664F;\n\tFri, 22 Apr 2016 20:50:36 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id obOyn0vBQs4b; Fri, 22 Apr 2016 20:50:36 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D67A39665C;\n\tFri, 22 Apr 2016 20:50:35 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id E8B091C1750\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:32 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id E558B9664D\n\tfor <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:32 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 30MCjZFve-1X for <buildroot@lists.busybox.net>;\n\tFri, 22 Apr 2016 20:50:32 +0000 (UTC)", "from mail-wm0-f67.google.com (mail-wm0-f67.google.com\n\t[74.125.82.67])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 342179658C\n\tfor <buildroot@buildroot.org>; Fri, 22 Apr 2016 20:50:32 +0000 (UTC)", "by mail-wm0-f67.google.com with SMTP id r12so7001821wme.0\n\tfor <buildroot@buildroot.org>; Fri, 22 Apr 2016 13:50:32 -0700 (PDT)", "from bobook.localdomain (ivr94-4-82-229-165-48.fbx.proxad.net.\n\t[82.229.165.48]) by smtp.gmail.com with ESMTPSA id\n\tiv1sm9826507wjb.34.2016.04.22.13.50.29\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 22 Apr 2016 13:50:29 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com header.b=zAzRdua4;\n\tdkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=MjiHKjgIYx5c7VkJiwbNqbdoluz/C8Z067d9bV7YHqw=;\n\tb=zAzRdua4o1q3AyjhVwthdiqtPZV5SL2AMA/qRpmqdHWskE4HipJXQ3f1zm7Mrr36+O\n\t38QqhDxuRO0cdxn+1HnTLVICpFxxoeWvfkQrcNlwwmXkRq/A+arM8IOXpWEYhlAzVsSR\n\tcZrVfFyAgX8ry8BrcVpylcPiAq0SYxJxFTc6xV4OodDsrAbd7aJmIUC3oMiE6pufNWfl\n\t5vCTWxm2IeMzc6tGETqzsd7T0qjPnYCq7YjXT95HMDGQxExRKwYja5ftDuIP8Tju0DqN\n\tByXQxPn2/z81oTt+A9AdDIoUQqfMJEGZx9CnSLrJgTqM1YCSJ8jv33ERkbdsGg71xbSr\n\tbXpw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=MjiHKjgIYx5c7VkJiwbNqbdoluz/C8Z067d9bV7YHqw=;\n\tb=DIqU/CH3AHSt3AwfgWCRgaMYuQVYAvgc7Bx9tOAkkWBmphL1itGZhAaKWJa1wP1Pw3\n\tnOChoJq7mRefO+V2wTwiggUQocVQfiikMZTB80OA6T/5njbF9160xzIfcHZvYWZpEdJk\n\tDh259uDGR9wIaggwpoXk659z330yEZLg0AdMNC4BDszW5uUVI6BKCQJYyl38GnF/+rAF\n\tpJILFR1bhQVCfGsuUD7UOCgjBLa5SsxY+vlBq2+lTSwVdHFeyDkLUBZKhYH89mDjS0ah\n\t57QW+G1p4AivwysBpHzBSRufGDw9CdFVFHmJCOWaDmiEFwWKgJVqFfLRw4IidtX0k6CJ\n\tW0Ng==", "X-Gm-Message-State": "AOPr4FWQcPfQQfSSPA6xkAvtXJnpV5twmkBPKaBAd2Hcw6BAFkcM0cxFNRvgt0ncBH5zaQ==", "X-Received": "by 10.28.53.193 with SMTP id c184mr6080044wma.93.1461358230914; \n\tFri, 22 Apr 2016 13:50:30 -0700 (PDT)", "From": "Samuel Martin <s.martin49@gmail.com>", "To": "buildroot@buildroot.org", "Date": "Fri, 22 Apr 2016 22:50:13 +0200", "Message-Id": "<1461358223-18312-2-git-send-email-s.martin49@gmail.com>", "X-Mailer": "git-send-email 2.8.0", "In-Reply-To": "<1461358223-18312-1-git-send-email-s.martin49@gmail.com>", "References": "<1461358223-18312-1-git-send-email-s.martin49@gmail.com>", "Subject": "[Buildroot] [PATCH v9 01/11] core: split variables definition\n\trelated to in/out-of-tree build from O itself", "X-BeenThere": "buildroot@busybox.net", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Discussion and development of buildroot <buildroot.busybox.net>", "List-Unsubscribe": "<http://lists.busybox.net/mailman/options/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=unsubscribe>", "List-Archive": "<http://lists.busybox.net/pipermail/buildroot/>", "List-Post": "<mailto:buildroot@busybox.net>", "List-Help": "<mailto:buildroot-request@busybox.net?subject=help>", "List-Subscribe": "<http://lists.busybox.net/mailman/listinfo/buildroot>,\n\t<mailto:buildroot-request@busybox.net?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "buildroot-bounces@busybox.net", "Sender": "\"buildroot\" <buildroot-bounces@busybox.net>" }, "content": "This change uncorrolates the CONFIG_DIR and NEED_WRAPPER definition from\nthe presence of the O variable in the command line.\n\nNow, the condition used to set these variables is the value of O itself.\n\nThis change is a preparatory work since the O definition will need to\nbe moved around when we will make Buildroot run with absolute canonical\npaths for both its root directory and the output location.\nThis will be addressed in a follow-up patch.\n\nSigned-off-by: Samuel Martin <s.martin49@gmail.com>\n\n---\nchanges v8->v9:\n- none\n\nchanges v7->v8:\n- new patch\n---\n Makefile | 14 +++++++++++---\n 1 file changed, 11 insertions(+), 3 deletions(-)", "diff": "diff --git a/Makefile b/Makefile\nindex 0e4beb2..3d86c9b 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -110,10 +110,11 @@ comma := ,\n empty :=\n space := $(empty) $(empty)\n \n+# Set O variable if not already done on the command line;\n+# or avoid confusing packages that can use the O=<dir> syntax for out-of-tree\n+# build by preventing it from being forwarded to sub-make calls.\n ifneq (\"$(origin O)\", \"command line\")\n O := output\n-CONFIG_DIR := $(TOPDIR)\n-NEED_WRAPPER =\n else\n # other packages might also support Linux-style out of tree builds\n # with the O=<dir> syntax (E.G. BusyBox does). As make automatically\n@@ -126,9 +127,16 @@ MAKEOVERRIDES =\n # Unfortunately some packages don't look at origin (E.G. uClibc 0.9.31+)\n # To really make O go away, we have to override it.\n override O := $(O)\n-CONFIG_DIR := $(O)\n # we need to pass O= everywhere we call back into the toplevel makefile\n EXTRAMAKEARGS = O=$(O)\n+endif\n+\n+# Set variables related to in-tree or out-of-tree build.\n+ifeq ($(O),output)\n+CONFIG_DIR := $(TOPDIR)\n+NEED_WRAPPER =\n+else\n+CONFIG_DIR := $(O)\n NEED_WRAPPER = y\n endif\n \n", "prefixes": [ "v9", "01/11" ] }