Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/613338/?format=api
{ "id": 613338, "url": "http://patchwork.ozlabs.org/api/patches/613338/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1461279409-248697-1-git-send-email-babu.moger@oracle.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1461279409-248697-1-git-send-email-babu.moger@oracle.com>", "list_archive_url": null, "date": "2016-04-21T22:56:49", "name": "[v2] ixgbevf: Change the relaxed order settings in VF driver for sparc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "b5e01bda66e9fc951ec058f2c37a1be9e96134a6", "submitter": { "id": 67585, "url": "http://patchwork.ozlabs.org/api/people/67585/?format=api", "name": "Babu Moger", "email": "babu.moger@oracle.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1461279409-248697-1-git-send-email-babu.moger@oracle.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/613338/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/613338/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 3qrYzR39MXz9t4h\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Apr 2016 08:57:07 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 46BAAC051F;\n\tThu, 21 Apr 2016 22:57:06 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id q0xtHv_h5OBD; Thu, 21 Apr 2016 22:57:05 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A5529C051D;\n\tThu, 21 Apr 2016 22:57:05 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 64C5B1BFC8C\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 22:57:04 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5EA2B30346\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 22:57:04 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 9Kp9l25QZNis for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 22:57:03 +0000 (UTC)", "from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])\n\tby silver.osuosl.org (Postfix) with ESMTPS id 4080E31523\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 22:57:03 +0000 (UTC)", "from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74])\n\tby aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with\n\tESMTP id u3LMuxaQ011462\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256\n\tverify=OK); Thu, 21 Apr 2016 22:57:00 GMT", "from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235])\n\tby userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id\n\tu3LMuwX1031844\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);\n\tThu, 21 Apr 2016 22:56:59 GMT", "from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20])\n\tby aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id\n\tu3LMuvEc004787; Thu, 21 Apr 2016 22:56:58 GMT", "from ca-qasparc20.us.oracle.com (/10.147.24.73)\n\tby default (Oracle Beehive Gateway v4.0)\n\twith ESMTP ; Thu, 21 Apr 2016 15:56:57 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "From": "Babu Moger <babu.moger@oracle.com>", "To": "jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,\n\tshannon.nelson@intel.com, carolyn.wyborny@intel.com,\n\tdonald.c.skidmore@intel.com, bruce.w.allan@intel.com,\n\tjohn.ronciak@intel.com, mitch.a.williams@intel.com", "Date": "Thu, 21 Apr 2016 15:56:49 -0700", "Message-Id": "<1461279409-248697-1-git-send-email-babu.moger@oracle.com>", "X-Mailer": "git-send-email 1.7.1", "X-Source-IP": "userv0022.oracle.com [156.151.31.74]", "Cc": "netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org, babu.moger@oracle.com,\n\tsowmini.varadhan@oracle.com", "Subject": "[Intel-wired-lan] [PATCH v2] ixgbevf: Change the relaxed order\n\tsettings in VF driver for sparc", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "We noticed performance issues with VF interface on sparc compared\nto PF. Setting the RX to IXGBE_DCA_RXCTRL_DATA_WRO_EN brings it\non far with PF. Also this matches to the default sparc setting in\nPF driver.\n\nSigned-off-by: Babu Moger <babu.moger@oracle.com>\nAcked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>\n---\nv2:\n Alexander had concerns about this negativily affecting other architectures.\n Added CONFIG_SPARC check so this should not affect other architectures.\n\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 6 ++++++\n 1 files changed, 6 insertions(+), 0 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex 0ea14c0..3596e0b 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -1748,9 +1748,15 @@ static void ixgbevf_configure_rx_ring(struct ixgbevf_adapter *adapter,\n \tIXGBE_WRITE_REG(hw, IXGBE_VFRDLEN(reg_idx),\n \t\t\tring->count * sizeof(union ixgbe_adv_rx_desc));\n \n+#ifndef CONFIG_SPARC\n \t/* enable relaxed ordering */\n \tIXGBE_WRITE_REG(hw, IXGBE_VFDCA_RXCTRL(reg_idx),\n \t\t\tIXGBE_DCA_RXCTRL_DESC_RRO_EN);\n+#else\n+\tIXGBE_WRITE_REG(hw, IXGBE_VFDCA_RXCTRL(reg_idx),\n+\t\t\tIXGBE_DCA_RXCTRL_DESC_RRO_EN |\n+\t\t\tIXGBE_DCA_RXCTRL_DATA_WRO_EN);\n+#endif\n \n \t/* reset head and tail pointers */\n \tIXGBE_WRITE_REG(hw, IXGBE_VFRDH(reg_idx), 0);\n", "prefixes": [ "v2" ] }