Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/613283/?format=api
{ "id": 613283, "url": "http://patchwork.ozlabs.org/api/patches/613283/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160421184035.14573.50191.stgit@ixgbe-dev.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160421184035.14573.50191.stgit@ixgbe-dev.jf.intel.com>", "list_archive_url": null, "date": "2016-04-21T18:40:35", "name": "ixgbe: Revise populating few registers and macro definitions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9270970e7e0bfdecdb75c785101b943b07fa9e0b", "submitter": { "id": 68833, "url": "http://patchwork.ozlabs.org/api/people/68833/?format=api", "name": "Preethi Banala", "email": "preethi.banala@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160421184035.14573.50191.stgit@ixgbe-dev.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/613283/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/613283/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3qrSb90WN0z9t3c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Apr 2016 04:54:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D1A1530954;\n\tThu, 21 Apr 2016 18:54:11 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id dxfQsWXztkNM; Thu, 21 Apr 2016 18:54:08 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 713C2234C6;\n\tThu, 21 Apr 2016 18:54:08 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 698DA1C1064\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:54:07 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 64E4E958D8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:54:07 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id eZPbIwvt0iXA for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:54:06 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 37B03958D0\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:54:06 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga102.jf.intel.com with ESMTP; 21 Apr 2016 11:54:05 -0700", "from ixgbe-dev.jf.intel.com ([134.134.170.149])\n\tby orsmga003.jf.intel.com with ESMTP; 21 Apr 2016 11:54:05 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,513,1455004800\"; d=\"scan'208\";a=\"789571690\"", "From": "Preethi Banala <preethi.banala@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 21 Apr 2016 11:40:35 -0700", "Message-ID": "<20160421184035.14573.50191.stgit@ixgbe-dev.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Revise populating few registers\n\tand macro definitions", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Revise populating few registers in ixgbe_get_regs() and macro\ndefinitions.\nBefore applying patch:\n$ du -k objs/drivers/net/ethernet/intel/ixgbe/ixgbe.ko\n8572 objs/drivers/net/ethernet/intel/ixgbe/ixgbe.ko\nAfter applying patch:\n$ du -k objs/drivers/net/ethernet/intel/ixgbe/ixgbe.ko\n8568 objs/drivers/net/ethernet/intel/ixgbe/ixgbe.ko\n\nSigned-off-by: Preethi Banala <preethi.banala@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 18 ++++++------------\n drivers/net/ethernet/intel/ixgbe/ixgbe_type.h | 10 ++--------\n 2 files changed, 8 insertions(+), 20 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex b59e3057f291..f1d2fc1f0272 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -535,10 +535,8 @@ static void ixgbe_get_regs(struct net_device *netdev,\n \n \t/* Flow Control */\n \tregs_buff[30] = IXGBE_READ_REG(hw, IXGBE_PFCTOP);\n-\tregs_buff[31] = IXGBE_READ_REG(hw, IXGBE_FCTTV(0));\n-\tregs_buff[32] = IXGBE_READ_REG(hw, IXGBE_FCTTV(1));\n-\tregs_buff[33] = IXGBE_READ_REG(hw, IXGBE_FCTTV(2));\n-\tregs_buff[34] = IXGBE_READ_REG(hw, IXGBE_FCTTV(3));\n+\tfor (i = 0; i < 4; i++)\n+\t\tregs_buff[31 + i] = IXGBE_READ_REG(hw, IXGBE_FCTTV(i));\n \tfor (i = 0; i < 8; i++) {\n \t\tswitch (hw->mac.type) {\n \t\tcase ixgbe_mac_82598EB:\n@@ -808,15 +806,11 @@ static void ixgbe_get_regs(struct net_device *netdev,\n \t\tregs_buff[1096 + i] = IXGBE_READ_REG(hw, IXGBE_TIC_DW(i));\n \tregs_buff[1100] = IXGBE_READ_REG(hw, IXGBE_TDPROBE);\n \tregs_buff[1101] = IXGBE_READ_REG(hw, IXGBE_TXBUFCTRL);\n-\tregs_buff[1102] = IXGBE_READ_REG(hw, IXGBE_TXBUFDATA0);\n-\tregs_buff[1103] = IXGBE_READ_REG(hw, IXGBE_TXBUFDATA1);\n-\tregs_buff[1104] = IXGBE_READ_REG(hw, IXGBE_TXBUFDATA2);\n-\tregs_buff[1105] = IXGBE_READ_REG(hw, IXGBE_TXBUFDATA3);\n+\tfor (i = 0; i < 4; i++)\n+\t\tregs_buff[1102 + i] = IXGBE_READ_REG(hw, IXGBE_TXBUFDATA(i));\n \tregs_buff[1106] = IXGBE_READ_REG(hw, IXGBE_RXBUFCTRL);\n-\tregs_buff[1107] = IXGBE_READ_REG(hw, IXGBE_RXBUFDATA0);\n-\tregs_buff[1108] = IXGBE_READ_REG(hw, IXGBE_RXBUFDATA1);\n-\tregs_buff[1109] = IXGBE_READ_REG(hw, IXGBE_RXBUFDATA2);\n-\tregs_buff[1110] = IXGBE_READ_REG(hw, IXGBE_RXBUFDATA3);\n+\tfor (i = 0; i < 4; i++)\n+\t\tregs_buff[1107 + i] = IXGBE_READ_REG(hw, IXGBE_RXBUFDATA(i));\n \tfor (i = 0; i < 8; i++)\n \t\tregs_buff[1111 + i] = IXGBE_READ_REG(hw, IXGBE_PCIE_DIAG(i));\n \tregs_buff[1119] = IXGBE_READ_REG(hw, IXGBE_RFVAL);\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\nindex 97f0127ec03e..fecf594566f7 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h\n@@ -1056,15 +1056,9 @@ struct ixgbe_thermal_sensor_data {\n #define IXGBE_TIC_DW2(_i) (0x082B0 + ((_i) * 4))\n #define IXGBE_TDPROBE 0x07F20\n #define IXGBE_TXBUFCTRL 0x0C600\n-#define IXGBE_TXBUFDATA0 0x0C610\n-#define IXGBE_TXBUFDATA1 0x0C614\n-#define IXGBE_TXBUFDATA2 0x0C618\n-#define IXGBE_TXBUFDATA3 0x0C61C\n+#define IXGBE_TXBUFDATA(_i) (0x0C610 + ((_i) * 4)) /* 4 of these (0-3) */\n #define IXGBE_RXBUFCTRL 0x03600\n-#define IXGBE_RXBUFDATA0 0x03610\n-#define IXGBE_RXBUFDATA1 0x03614\n-#define IXGBE_RXBUFDATA2 0x03618\n-#define IXGBE_RXBUFDATA3 0x0361C\n+#define IXGBE_RXBUFDATA(_i) (0x03610 + ((_i) * 4)) /* 4 of these (0-3) */\n #define IXGBE_PCIE_DIAG(_i) (0x11090 + ((_i) * 4)) /* 8 of these */\n #define IXGBE_RFVAL 0x050A4\n #define IXGBE_MDFTC1 0x042B8\n", "prefixes": [] }