Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/613282/?format=api
{ "id": 613282, "url": "http://patchwork.ozlabs.org/api/patches/613282/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160421184024.14525.87965.stgit@ixgbe-dev.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160421184024.14525.87965.stgit@ixgbe-dev.jf.intel.com>", "list_archive_url": null, "date": "2016-04-21T18:40:24", "name": "ixgbe: Return 64 bit stats values", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cc50f1e71136bd300e1ab0f5f0f12a38ccd476e1", "submitter": { "id": 68833, "url": "http://patchwork.ozlabs.org/api/people/68833/?format=api", "name": "Preethi Banala", "email": "preethi.banala@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160421184024.14525.87965.stgit@ixgbe-dev.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/613282/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/613282/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3qrSZw2Rzvz9t3c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Apr 2016 04:54:00 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 50792305F3;\n\tThu, 21 Apr 2016 18:53:59 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id mdcfrRaSTIwh; Thu, 21 Apr 2016 18:53:58 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id EC6C1234C6;\n\tThu, 21 Apr 2016 18:53:57 +0000 (UTC)", "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id 37E7A1C1064\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:53:56 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3072CC0669\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:53:56 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 09GQs8q4eJJC for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:53:55 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 49808C0660\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:53:55 +0000 (UTC)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP; 21 Apr 2016 11:53:55 -0700", "from ixgbe-dev.jf.intel.com ([134.134.170.149])\n\tby fmsmga004.fm.intel.com with ESMTP; 21 Apr 2016 11:53:55 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,513,1455004800\"; d=\"scan'208\";a=\"89512631\"", "From": "Preethi Banala <preethi.banala@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 21 Apr 2016 11:40:24 -0700", "Message-ID": "<20160421184024.14525.87965.stgit@ixgbe-dev.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: Return 64 bit stats values", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The code was ignoring higher 32 bits of stats registers. This patch\ncorrectly fills out 64 bit value in two 32 bit words.\n\nSigned-off-by: Preethi Banala <preethi.banala@intel.com>\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\nindex 5d009f04e37f..b59e3057f291 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c\n@@ -722,8 +722,10 @@ static void ixgbe_get_regs(struct net_device *netdev,\n \tregs_buff[939] = IXGBE_GET_STAT(adapter, bprc);\n \tregs_buff[940] = IXGBE_GET_STAT(adapter, mprc);\n \tregs_buff[941] = IXGBE_GET_STAT(adapter, gptc);\n-\tregs_buff[942] = IXGBE_GET_STAT(adapter, gorc);\n-\tregs_buff[944] = IXGBE_GET_STAT(adapter, gotc);\n+\tregs_buff[942] = (u32)IXGBE_GET_STAT(adapter, gorc);\n+\tregs_buff[943] = (u32)(IXGBE_GET_STAT(adapter, gorc) >> 32);\n+\tregs_buff[944] = (u32)IXGBE_GET_STAT(adapter, gotc);\n+\tregs_buff[945] = (u32)(IXGBE_GET_STAT(adapter, gotc) >> 32);\n \tfor (i = 0; i < 8; i++)\n \t\tregs_buff[946 + i] = IXGBE_GET_STAT(adapter, rnbc[i]);\n \tregs_buff[954] = IXGBE_GET_STAT(adapter, ruc);\n@@ -733,7 +735,8 @@ static void ixgbe_get_regs(struct net_device *netdev,\n \tregs_buff[958] = IXGBE_GET_STAT(adapter, mngprc);\n \tregs_buff[959] = IXGBE_GET_STAT(adapter, mngpdc);\n \tregs_buff[960] = IXGBE_GET_STAT(adapter, mngptc);\n-\tregs_buff[961] = IXGBE_GET_STAT(adapter, tor);\n+\tregs_buff[961] = (u32)IXGBE_GET_STAT(adapter, tor);\n+\tregs_buff[962] = (u32)(IXGBE_GET_STAT(adapter, tor) >> 32);\n \tregs_buff[963] = IXGBE_GET_STAT(adapter, tpr);\n \tregs_buff[964] = IXGBE_GET_STAT(adapter, tpt);\n \tregs_buff[965] = IXGBE_GET_STAT(adapter, ptc64);\n", "prefixes": [] }