Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/613275/?format=api
{ "id": 613275, "url": "http://patchwork.ozlabs.org/api/patches/613275/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160421182856.13330.56812.stgit@ixgbe-dev.jf.intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160421182856.13330.56812.stgit@ixgbe-dev.jf.intel.com>", "list_archive_url": null, "date": "2016-04-21T18:28:57", "name": "[3/3] ethtool/ixgbe: Reduce format string storage", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "20caf3d254a77a620889707026d990de158f61e8", "submitter": { "id": 68833, "url": "http://patchwork.ozlabs.org/api/people/68833/?format=api", "name": "Preethi Banala", "email": "preethi.banala@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160421182856.13330.56812.stgit@ixgbe-dev.jf.intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/613275/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/613275/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3qrSKh4rRzz9t3c\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 22 Apr 2016 04:42:32 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id AB9E83387A;\n\tThu, 21 Apr 2016 18:42:31 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id c8fTWu+-7oft; Thu, 21 Apr 2016 18:42:30 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 8789D30F84;\n\tThu, 21 Apr 2016 18:42:30 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id A3D7A1C1064\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:42:28 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id A02973386D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:42:28 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rw137XjXiS77 for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:42:27 +0000 (UTC)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby silver.osuosl.org (Postfix) with ESMTP id D4D0A30F84\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 21 Apr 2016 18:42:27 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga104.fm.intel.com with ESMTP; 21 Apr 2016 11:42:27 -0700", "from ixgbe-dev.jf.intel.com ([134.134.170.149])\n\tby fmsmga002.fm.intel.com with ESMTP; 21 Apr 2016 11:42:27 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,513,1455004800\"; d=\"scan'208\";a=\"963726112\"", "From": "Preethi Banala <preethi.banala@intel.com>", "To": "intel-wired-lan@lists.osuosl.org", "Date": "Thu, 21 Apr 2016 11:28:57 -0700", "Message-ID": "<20160421182856.13330.56812.stgit@ixgbe-dev.jf.intel.com>", "In-Reply-To": "<20160421182545.13330.59497.stgit@ixgbe-dev.jf.intel.com>", "References": "<20160421182545.13330.59497.stgit@ixgbe-dev.jf.intel.com>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [PATCH 3/3] ethtool/ixgbe: Reduce format string\n\tstorage", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "Reduce format string storage using for loop.\n\nSigned-off-by: Preethi Banala <preethi.banala@intel.com>\n---\n ixgbe.c | 57 ++++++++++++---------------------------------------------\n 1 file changed, 12 insertions(+), 45 deletions(-)", "diff": "diff --git a/ixgbe.c b/ixgbe.c\nindex 4f5af779f763..ff0e769cb7a8 100644\n--- a/ixgbe.c\n+++ b/ixgbe.c\n@@ -1193,21 +1193,10 @@ ixgbe_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)\n \t\t\"0x07F08: TDHMPN (Tx Desc Handler Mem Page Num) 0x%08X\\n\",\n \t\tregs_buff[1095]);\n \n-\tfprintf(stdout,\n-\t\t\"0x07F10: TIC_DW0 (Tx Desc Hand. Mem Read Data 0) 0x%08X\\n\",\n-\t\tregs_buff[1096]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x07F14: TIC_DW1 (Tx Desc Hand. Mem Read Data 1) 0x%08X\\n\",\n-\t\tregs_buff[1097]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x07F18: TIC_DW2 (Tx Desc Hand. Mem Read Data 2) 0x%08X\\n\",\n-\t\tregs_buff[1098]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x07F1C: TIC_DW3 (Tx Desc Hand. Mem Read Data 3) 0x%08X\\n\",\n-\t\tregs_buff[1099]);\n+\tfor (i = 0; i < 4; i++)\n+\t\tfprintf(stdout,\n+\t\t\t\"0x%05X: TIC_DW%d (Tx Desc Hand. Mem Read Data %d) 0x%08X\\n\",\n+\t\t\t0x07F10 + (4 * i), i, i, regs_buff[1096 + i]);\n \n \tfprintf(stdout,\n \t\t\"0x07F20: TDPROBE (Tx Probe Mode Status) 0x%08X\\n\",\n@@ -1217,41 +1206,19 @@ ixgbe_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)\n \t\t\"0x0C600: TXBUFCTRL (TX Buffer Access Control) 0x%08X\\n\",\n \t\tregs_buff[1101]);\n \n-\tfprintf(stdout,\n-\t\t\"0x0C610: TXBUFDATA0 (TX Buffer DATA 0) 0x%08X\\n\",\n-\t\tregs_buff[1102]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x0C614: TXBUFDATA1 (TX Buffer DATA 1) 0x%08X\\n\",\n-\t\tregs_buff[1103]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x0C618: TXBUFDATA2 (TX Buffer DATA 2) 0x%08X\\n\",\n-\t\tregs_buff[1104]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x0C61C: TXBUFDATA3 (TX Buffer DATA 3) 0x%08X\\n\",\n-\t\tregs_buff[1105]);\n+\tfor (i = 0; i < 4; i++)\n+\t\tfprintf(stdout,\n+\t\t\t\"0x%05X: TXBUFDATA%d (TX Buffer DATA %d) 0x%08X\\n\",\n+\t\t\t0x0C610 + (4 * i), i, i, regs_buff[1102 + i]);\n \n \tfprintf(stdout,\n \t\t\"0x03600: RXBUFCTRL (RX Buffer Access Control) 0x%08X\\n\",\n \t\tregs_buff[1106]);\n \n-\tfprintf(stdout,\n-\t\t\"0x03610: RXBUFDATA0 (RX Buffer DATA 0) 0x%08X\\n\",\n-\t\tregs_buff[1107]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x03614: RXBUFDATA1 (RX Buffer DATA 1) 0x%08X\\n\",\n-\t\tregs_buff[1108]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x03618: RXBUFDATA2 (RX Buffer DATA 2) 0x%08X\\n\",\n-\t\tregs_buff[1109]);\n-\n-\tfprintf(stdout,\n-\t\t\"0x0361C: RXBUFDATA3 (RX Buffer DATA 3) 0x%08X\\n\",\n-\t\tregs_buff[1110]);\n+\tfor (i = 0; i < 4; i++)\n+\t\tfprintf(stdout,\n+\t\t\t\"0x%05X: RXBUFDATA%d (RX Buffer DATA %d) 0x%08X\\n\",\n+\t\t\t0x03610 + (4 * i), i, i, regs_buff[1107 + i]);\n \n \tfor (i = 0; i < 8; i++)\n \t\tfprintf(stdout,\n", "prefixes": [ "3/3" ] }