Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/611397/?format=api
{ "id": 611397, "url": "http://patchwork.ozlabs.org/api/patches/611397/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460838941-1251989-1-git-send-email-arnd@arndb.de/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1460838941-1251989-1-git-send-email-arnd@arndb.de>", "list_archive_url": null, "date": "2016-04-16T20:35:08", "name": "ixgbe: use msleep for long delays", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0bb4d781a34f19f7718c486a8e5c7e55df308337", "submitter": { "id": 30, "url": "http://patchwork.ozlabs.org/api/people/30/?format=api", "name": "Arnd Bergmann", "email": "arnd@arndb.de" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460838941-1251989-1-git-send-email-arnd@arndb.de/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/611397/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/611397/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ozlabs.org (Postfix) with ESMTP id 3qnR586yThz9t5C\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 17 Apr 2016 06:36:12 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 1B835C04B4;\n\tSat, 16 Apr 2016 20:36:11 +0000 (UTC)", "from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 5W2wWRubiyxN; Sat, 16 Apr 2016 20:36:10 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 8A585C04B5;\n\tSat, 16 Apr 2016 20:36:10 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 829121C1038\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 16 Apr 2016 20:36:09 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7839A96164\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 16 Apr 2016 20:36:09 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RptDcjSoPc6A for <intel-wired-lan@lists.osuosl.org>;\n\tSat, 16 Apr 2016 20:36:06 +0000 (UTC)", "from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 83EBD9614D\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tSat, 16 Apr 2016 20:36:04 +0000 (UTC)", "from wuerfel.lan. ([78.42.132.4]) by mrelayeu.kundenserver.de\n\t(mreue003) with ESMTPA (Nemesis) id 0MZysF-1bCEcn1CwR-00Lp4k;\n\tSat, 16 Apr 2016 22:35:46 +0200" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "From": "Arnd Bergmann <arnd@arndb.de>", "To": "Jeff Kirsher <jeffrey.t.kirsher@intel.com>", "Date": "Sat, 16 Apr 2016 22:35:08 +0200", "Message-Id": "<1460838941-1251989-1-git-send-email-arnd@arndb.de>", "X-Mailer": "git-send-email 2.7.0", "X-Provags-ID": "V03:K0:MEYvR4pKzOlLo8nRXk7LdLj8tvIXlSVuSEORCn8LMXI0+pT539G\n\tdlN7CxtOkxgKMVrJsRn7gef2Ix4mb4Avg4kDRssIkkxg+fUyGpZ0wzv5n0hRl8epDSBfmdf\n\tOmUSL4c/JQaQjtqhkbXLS/uwu1pLuOtsSYBfO7p6va7HUrLfv6Gum3RMiLd28phdSqpEkk+\n\tvQdmGV/ulL9qZ7g3kxybw==", "X-UI-Out-Filterresults": "notjunk:1; V01:K0:bVNQ2Sh9wnQ=:7n6kmxPizYGM3AKyESQmTq\n\tmXp5a2exExHg9glwheQH3kO9Bw/ra43WeY8OZQstII05cFh+cXU6UUNFDX7eSzC6UotWr2fcv\n\tlRb8yYyy3T3BOVzrLnTFzGP1NjFCpdBgXcxZoR1ys4LcY1ANnRp8ChdjiAvcJTMAzEhqS262q\n\tQDvgequM2aE4dpNeWDy8JgcYfNtqszufFRxfPK1OgC8LNPLHYm47RaAz2PUY7nhvFzMslfGYx\n\tIFiJ6XNsg0zHecQP8Z0LkrssWElK0Nw2r5uFKnmkPxHOMA12344XWkfj0VaUbXNeU7C+DSsrn\n\tO9FdPoPHGTh6XPQyyrfgSztYpEdVzxhllfvdbWzq99+89claS93CRPfBaSEuleCl1p1g7Wj6V\n\tFZMQufatWXUtn18xOO/iabGc9I4GTKg3dqUlHhRvhhowmTCtBp5IJnc4oUjnre4b3hR966kCX\n\tr4/m8Yxp1Q/U3UiKaRaXAMbhiT2xUZqj7crDXoN02Ce52jkvX7GeKNXBu3IA8On74TWs5IV0F\n\tX0+5OSegcJlJEptpKMtBF+lLxj2jEi7r840wYlBW9CKO3upVaUQSOUcG0+vYLkL2/Ya7x9eUR\n\tRcrsGIN6C9RA0sa/6ClWxNdW3xOyR74gul69UBaMETKK9BGai4oD3joUkug1vQVEnPuFrZ+qW\n\t5f/zVWsNnuvdT0OgRRLzCsK9HYwQXSlfjepC4NvGOECSGiY4YazjaxiOd9YbnZ2+cDO0=", "Cc": "Arnd Bergmann <arnd@arndb.de>, linux-kernel@vger.kernel.org,\n\tintel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org", "Subject": "[Intel-wired-lan] [PATCH] ixgbe: use msleep for long delays", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The newly added x550em_a support causes a link failure on ARM because of\nan overly long time passed into udelay():\n\nERROR: \"__bad_udelay\" [drivers/net/ethernet/intel/ixgbe/ixgbe.ko] undefined!\n\nThere are multiple variants of the ixgbe_acquire_swfw_sync_*() function,\nand the other ones all use msleep(), so we can safely assume that all\ncallers are allowed to sleep, which makes msleep() a better replacement\nthan mdelay().\n\nSigned-off-by: Arnd Bergmann <arnd@arndb.de>\nFixes: 49425dfc7451 (\"ixgbe: Add support for x550em_a 10G MAC type\")\n---\n drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\nindex c71e93ed4451..21c0fce47e15 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c\n@@ -2765,7 +2765,7 @@ static s32 ixgbe_acquire_swfw_sync_x550em_a(struct ixgbe_hw *hw, u32 mask)\n \t\t\tixgbe_release_swfw_sync_X540(hw, hmask);\n \t\tif (status != IXGBE_ERR_TOKEN_RETRY)\n \t\t\treturn status;\n-\t\tudelay(FW_PHY_TOKEN_DELAY * 1000);\n+\t\tmsleep(FW_PHY_TOKEN_DELAY);\n \t}\n \n \treturn status;\n", "prefixes": [] }