Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/610696/?format=api
{ "id": 610696, "url": "http://patchwork.ozlabs.org/api/patches/610696/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160415003715.11097.60482.stgit@ahduyck-xeon-server/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<20160415003715.11097.60482.stgit@ahduyck-xeon-server>", "list_archive_url": null, "date": "2016-04-15T00:37:15", "name": "[next-queue] ixgbevf: Move API negotiation function into mac_ops", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "c3880fdb84278e9effb15d42ba324dd435239d28", "submitter": { "id": 67293, "url": "http://patchwork.ozlabs.org/api/people/67293/?format=api", "name": "Alexander Duyck", "email": "aduyck@mirantis.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20160415003715.11097.60482.stgit@ahduyck-xeon-server/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/610696/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/610696/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\tby ozlabs.org (Postfix) with ESMTP id 3qmJXR6HCcz9ssM\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Apr 2016 10:37:27 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 0FAE5914F6;\n\tFri, 15 Apr 2016 00:37:27 +0000 (UTC)", "from whitealder.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id RYsT-sn0JV5P; Fri, 15 Apr 2016 00:37:26 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby whitealder.osuosl.org (Postfix) with ESMTP id 05B5791415;\n\tFri, 15 Apr 2016 00:37:26 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 3D6B21CEF48\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Apr 2016 00:37:25 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 7330096136\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Apr 2016 00:37:24 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ce2qQw9j2HhR for <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Apr 2016 00:37:21 +0000 (UTC)", "from mail-pf0-f176.google.com (mail-pf0-f176.google.com\n\t[209.85.192.176])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id CFA5295F59\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tFri, 15 Apr 2016 00:37:21 +0000 (UTC)", "by mail-pf0-f176.google.com with SMTP id e128so50911190pfe.3\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Apr 2016 17:37:21 -0700 (PDT)", "from [192.168.1.144] (static-50-53-29-36.bvtn.or.frontiernet.net.\n\t[50.53.29.36]) by smtp.gmail.com with ESMTPSA id\n\th85sm60422860pfj.52.2016.04.14.17.37.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 14 Apr 2016 17:37:20 -0700 (PDT)" ], "Authentication-Results": "ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=mirantis.com header.i=@mirantis.com\n\theader.b=RdWmk8Ok; dkim-atps=neutral", "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "from auto-whitelisted by SQLgrey-1.7.6", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=mirantis.com;\n\ts=google; \n\th=subject:from:to:date:message-id:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=7o0LL9+tZByt6Uh9Dj00EnJWBCnXk3Vp1cEaqzurUow=;\n\tb=RdWmk8OkDv9f2qk4DBfs+cRQqnVcrFc8rT0z0coM0VsCGfK+mTkrgLiky4rPVK+NHo\n\tf/mk3zoJPFkOt6h0a0wqBtIuywela9mRZ0qDSz/iSlCmswPj43LDJ9PwoK1pj+TrTdNj\n\tyZ2lQzUcZtZljJIT9p2o9kefd1CBLQKh9dTwg=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:subject:from:to:date:message-id:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=7o0LL9+tZByt6Uh9Dj00EnJWBCnXk3Vp1cEaqzurUow=;\n\tb=glCrb8ueguDnwpfQ1mkulNI6DOTBpE55X32o0ofMZZup5jy+rKPaoYei+YaKUvjGJN\n\twrLUOGTm97t5nxxX+T/da+XDiF8prmoO2mePSViM5HLSDc7hYGluLLwq7UB4HK7Np89s\n\tMzte9MwzOjQozH4fL2iAvaWznlgplvZiXC2Y7ZVHC51W/UPAOkE2o3Ircs8YEwyAh8AW\n\tVQ2CLH9rWgSuZkA+PJWCXyHkJKNJSoXEK+z1xp/J9zrh3KATymdhXkzVQdDonK3411MJ\n\t5GkBwX6GxtBRJIdql86EKHgmnGe65pVPrxF3yaBW+LUGea8bbEPGkmImsNmwTmzCH+pN\n\t2qBw==", "X-Gm-Message-State": "AOPr4FUsSK+gN5TK9HjSjfZiLrQw/UqUuAC0+HCLb2kWlk1/6WOiyoNwGlOZTHb4aVpa4yKn", "X-Received": "by 10.98.10.147 with SMTP id 19mr25490447pfk.87.1460680641530;\n\tThu, 14 Apr 2016 17:37:21 -0700 (PDT)", "From": "Alexander Duyck <aduyck@mirantis.com>", "To": "kys@microsoft.com, intel-wired-lan@lists.osuosl.org,\n\tjeffrey.t.kirsher@intel.com, alexander.duyck@gmail.com", "Date": "Thu, 14 Apr 2016 20:37:15 -0400", "Message-ID": "<20160415003715.11097.60482.stgit@ahduyck-xeon-server>", "User-Agent": "StGit/0.17.1-dirty", "MIME-Version": "1.0", "Subject": "[Intel-wired-lan] [next-queue PATCH] ixgbevf: Move API negotiation\n\tfunction into mac_ops", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "This patch moves API negotiation into mac_ops. The general idea here is\nthat with HyperV on the way we need to make certain that anything that will\nhave different versions between HyperV and a standard VF needs to be\nabstracted enough so that we can have a separate function between the two\nso we can avoid changes in one breaking something in the other.\n\nSigned-off-by: Alexander Duyck <aduyck@mirantis.com>\n---\n drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-\n drivers/net/ethernet/intel/ixgbevf/vf.c | 5 +++--\n drivers/net/ethernet/intel/ixgbevf/vf.h | 2 +-\n 3 files changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\nindex eb91922bcb19..319e25f29883 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c\n@@ -2056,7 +2056,7 @@ static void ixgbevf_negotiate_api(struct ixgbevf_adapter *adapter)\n \tspin_lock_bh(&adapter->mbx_lock);\n \n \twhile (api[idx] != ixgbe_mbox_api_unknown) {\n-\t\terr = ixgbevf_negotiate_api_version(hw, api[idx]);\n+\t\terr = hw->mac.ops.negotiate_api_version(hw, api[idx]);\n \t\tif (!err)\n \t\t\tbreak;\n \t\tidx++;\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/vf.c b/drivers/net/ethernet/intel/ixgbevf/vf.c\nindex 4d613a4f2a7f..987ad69d4918 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.c\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.c\n@@ -670,11 +670,11 @@ void ixgbevf_rlpml_set_vf(struct ixgbe_hw *hw, u16 max_size)\n }\n \n /**\n- * ixgbevf_negotiate_api_version - Negotiate supported API version\n+ * ixgbevf_negotiate_api_version_vf - Negotiate supported API version\n * @hw: pointer to the HW structure\n * @api: integer containing requested API version\n **/\n-int ixgbevf_negotiate_api_version(struct ixgbe_hw *hw, int api)\n+static int ixgbevf_negotiate_api_version_vf(struct ixgbe_hw *hw, int api)\n {\n \tint err;\n \tu32 msg[3];\n@@ -769,6 +769,7 @@ static const struct ixgbe_mac_operations ixgbevf_mac_ops = {\n \t.stop_adapter\t\t= ixgbevf_stop_hw_vf,\n \t.setup_link\t\t= ixgbevf_setup_mac_link_vf,\n \t.check_link\t\t= ixgbevf_check_mac_link_vf,\n+\t.negotiate_api_version\t= ixgbevf_negotiate_api_version_vf,\n \t.set_rar\t\t= ixgbevf_set_rar_vf,\n \t.update_mc_addr_list\t= ixgbevf_update_mc_addr_list_vf,\n \t.update_xcast_mode\t= ixgbevf_update_xcast_mode,\ndiff --git a/drivers/net/ethernet/intel/ixgbevf/vf.h b/drivers/net/ethernet/intel/ixgbevf/vf.h\nindex ef9f7736b4dc..8e623f9327ae 100644\n--- a/drivers/net/ethernet/intel/ixgbevf/vf.h\n+++ b/drivers/net/ethernet/intel/ixgbevf/vf.h\n@@ -51,6 +51,7 @@ struct ixgbe_mac_operations {\n \ts32 (*get_mac_addr)(struct ixgbe_hw *, u8 *);\n \ts32 (*stop_adapter)(struct ixgbe_hw *);\n \ts32 (*get_bus_info)(struct ixgbe_hw *);\n+\ts32 (*negotiate_api_version)(struct ixgbe_hw *hw, int api);\n \n \t/* Link */\n \ts32 (*setup_link)(struct ixgbe_hw *, ixgbe_link_speed, bool, bool);\n@@ -208,7 +209,6 @@ static inline u32 ixgbe_read_reg_array(struct ixgbe_hw *hw, u32 reg,\n #define IXGBE_READ_REG_ARRAY(h, r, o) ixgbe_read_reg_array(h, r, o)\n \n void ixgbevf_rlpml_set_vf(struct ixgbe_hw *hw, u16 max_size);\n-int ixgbevf_negotiate_api_version(struct ixgbe_hw *hw, int api);\n int ixgbevf_get_queues(struct ixgbe_hw *hw, unsigned int *num_tcs,\n \t\t unsigned int *default_tc);\n int ixgbevf_get_reta_locked(struct ixgbe_hw *hw, u32 *reta, int num_rx_queues);\n", "prefixes": [ "next-queue" ] }