Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/610640/?format=api
{ "id": 610640, "url": "http://patchwork.ozlabs.org/api/patches/610640/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460665047-24907-1-git-send-email-jacob.e.keller@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1460665047-24907-1-git-send-email-jacob.e.keller@intel.com>", "list_archive_url": null, "date": "2016-04-14T20:17:27", "name": "fm10k: don't use BIT() macro where the value isn't a bitmask", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "eecf45a4e1f83e3bf87cbc1c08f1b804a4586e64", "submitter": { "id": 9784, "url": "http://patchwork.ozlabs.org/api/people/9784/?format=api", "name": "Jacob Keller", "email": "jacob.e.keller@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460665047-24907-1-git-send-email-jacob.e.keller@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/610640/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/610640/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@lists.osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3qmBn140zKz9sCp\n\tfor <incoming@patchwork.ozlabs.org>;\n\tFri, 15 Apr 2016 06:17:57 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 79BAF322CB;\n\tThu, 14 Apr 2016 20:17:56 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id y-32sadSTkFO; Thu, 14 Apr 2016 20:17:55 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 5E6A631250;\n\tThu, 14 Apr 2016 20:17:55 +0000 (UTC)", "from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 581DF1C14AD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Apr 2016 20:17:54 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 5155A96108\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Apr 2016 20:17:54 +0000 (UTC)", "from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id oCeF0FQ5xgpl for <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Apr 2016 20:17:53 +0000 (UTC)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id D12A0960FD\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tThu, 14 Apr 2016 20:17:53 +0000 (UTC)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP; 14 Apr 2016 13:17:28 -0700", "from jekeller-desk.amr.corp.intel.com (HELO\n\tjekeller-desk.jekeller.internal) ([134.134.3.173])\n\tby orsmga003.jf.intel.com with ESMTP; 14 Apr 2016 13:17:29 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,485,1455004800\"; d=\"scan'208\";a=\"785086958\"", "From": "Jacob Keller <jacob.e.keller@intel.com>", "To": "Intel Wired LAN <intel-wired-lan@lists.osuosl.org>", "Date": "Thu, 14 Apr 2016 13:17:27 -0700", "Message-Id": "<1460665047-24907-1-git-send-email-jacob.e.keller@intel.com>", "X-Mailer": "git-send-email 2.8.1.102.ga49ec4a", "Subject": "[Intel-wired-lan] [PATCH] fm10k: don't use BIT() macro where the\n\tvalue isn't a bitmask", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "The FM10K_MAX_DATA_PER_TXD is really just using a bitshift as a power of\n2 operation in an efficient manner. We shouldn't represent this as a BIT()\nbecause that obscures the intention of the operation.\n\nSigned-off-by: Jacob Keller <jacob.e.keller@intel.com>\n---\n drivers/net/ethernet/intel/fm10k/fm10k.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ethernet/intel/fm10k/fm10k.h b/drivers/net/ethernet/intel/fm10k/fm10k.h\nindex fcf106e545c5..e98b86bf0ca1 100644\n--- a/drivers/net/ethernet/intel/fm10k/fm10k.h\n+++ b/drivers/net/ethernet/intel/fm10k/fm10k.h\n@@ -406,7 +406,7 @@ static inline u16 fm10k_desc_unused(struct fm10k_ring *ring)\n \t (&(((union fm10k_rx_desc *)((R)->desc))[i]))\n \n #define FM10K_MAX_TXD_PWR\t14\n-#define FM10K_MAX_DATA_PER_TXD\tBIT(FM10K_MAX_TXD_PWR)\n+#define FM10K_MAX_DATA_PER_TXD\t(1u << FM10K_MAX_TXD_PWR)\n \n /* Tx Descriptors needed, worst case */\n #define TXD_USE_COUNT(S)\tDIV_ROUND_UP((S), FM10K_MAX_DATA_PER_TXD)\n", "prefixes": [] }