Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/610122/?format=api
{ "id": 610122, "url": "http://patchwork.ozlabs.org/api/patches/610122/?format=api", "web_url": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460542112-20166-10-git-send-email-harshitha.ramamurthy@intel.com/", "project": { "id": 46, "url": "http://patchwork.ozlabs.org/api/projects/46/?format=api", "name": "Intel Wired Ethernet development", "link_name": "intel-wired-lan", "list_id": "intel-wired-lan.osuosl.org", "list_email": "intel-wired-lan@osuosl.org", "web_url": "", "scm_url": "", "webscm_url": "", "list_archive_url": "", "list_archive_url_format": "", "commit_url_format": "" }, "msgid": "<1460542112-20166-10-git-send-email-harshitha.ramamurthy@intel.com>", "list_archive_url": null, "date": "2016-04-13T10:08:29", "name": "[next,S34,09/12] i40e: Use consistent type for vf_id", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a9e8ed1768ad3d9215ae7314d3be79a4502aae8f", "submitter": { "id": 68642, "url": "http://patchwork.ozlabs.org/api/people/68642/?format=api", "name": "Harshitha Ramamurthy", "email": "harshitha.ramamurthy@intel.com" }, "delegate": { "id": 68, "url": "http://patchwork.ozlabs.org/api/users/68/?format=api", "username": "jtkirshe", "first_name": "Jeff", "last_name": "Kirsher", "email": "jeffrey.t.kirsher@intel.com" }, "mbox": "http://patchwork.ozlabs.org/project/intel-wired-lan/patch/1460542112-20166-10-git-send-email-harshitha.ramamurthy@intel.com/mbox/", "series": [], "comments": "http://patchwork.ozlabs.org/api/patches/610122/comments/", "check": "pending", "checks": "http://patchwork.ozlabs.org/api/patches/610122/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<intel-wired-lan-bounces@lists.osuosl.org>", "X-Original-To": [ "incoming@patchwork.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Delivered-To": [ "patchwork-incoming@bilbo.ozlabs.org", "intel-wired-lan@osuosl.org" ], "Received": [ "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ozlabs.org (Postfix) with ESMTP id 3qlX4w2L53z9sD9\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 14 Apr 2016 04:14:24 +1000 (AEST)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 94A1133A12;\n\tWed, 13 Apr 2016 18:14:23 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id es6Og4+kE7AS; Wed, 13 Apr 2016 18:14:19 +0000 (UTC)", "from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id AE82533A2E;\n\tWed, 13 Apr 2016 18:14:17 +0000 (UTC)", "from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\tby ash.osuosl.org (Postfix) with ESMTP id 472F81C10B8\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 13 Apr 2016 18:14:15 +0000 (UTC)", "from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 43CA433A2B\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 13 Apr 2016 18:14:15 +0000 (UTC)", "from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id rr2x7XRRYUQb for <intel-wired-lan@osuosl.org>;\n\tWed, 13 Apr 2016 18:14:12 +0000 (UTC)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby silver.osuosl.org (Postfix) with ESMTP id 17B7933A27\n\tfor <intel-wired-lan@osuosl.org>;\n\tWed, 13 Apr 2016 18:14:12 +0000 (UTC)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga102.jf.intel.com with ESMTP; 13 Apr 2016 11:14:12 -0700", "from harshitha-linux1.jf.intel.com ([10.166.45.81])\n\tby fmsmga002.fm.intel.com with ESMTP; 13 Apr 2016 11:14:12 -0700" ], "X-Virus-Scanned": [ "amavisd-new at osuosl.org", "amavisd-new at osuosl.org" ], "X-Greylist": "domain auto-whitelisted by SQLgrey-1.7.6", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.24,480,1455004800\"; d=\"scan'208\";a=\"957967609\"", "From": "Harshitha Ramamurthy <harshitha.ramamurthy@intel.com>", "To": "intel-wired-lan@osuosl.org", "Date": "Wed, 13 Apr 2016 03:08:29 -0700", "Message-Id": "<1460542112-20166-10-git-send-email-harshitha.ramamurthy@intel.com>", "X-Mailer": "git-send-email 2.4.3", "In-Reply-To": "<1460542112-20166-1-git-send-email-harshitha.ramamurthy@intel.com>", "References": "<1460542112-20166-1-git-send-email-harshitha.ramamurthy@intel.com>", "Subject": "[Intel-wired-lan] [next PATCH S34 09/12] i40e: Use consistent type\n\tfor vf_id", "X-BeenThere": "intel-wired-lan@lists.osuosl.org", "X-Mailman-Version": "2.1.18-1", "Precedence": "list", "List-Id": "Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.lists.osuosl.org>", "List-Unsubscribe": "<http://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=unsubscribe>", "List-Archive": "<http://lists.osuosl.org/pipermail/intel-wired-lan/>", "List-Post": "<mailto:intel-wired-lan@lists.osuosl.org>", "List-Help": "<mailto:intel-wired-lan-request@lists.osuosl.org?subject=help>", "List-Subscribe": "<http://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@lists.osuosl.org?subject=subscribe>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "intel-wired-lan-bounces@lists.osuosl.org", "Sender": "\"Intel-wired-lan\" <intel-wired-lan-bounces@lists.osuosl.org>" }, "content": "From: Jesse Brandeburg <jesse.brandeburg@intel.com>\n\nThe driver was all over the place using signed or unsigned types\nfor vf_id, when it should always be signed.\n\nThis fixes warnings of type unsafe comparisons from gcc with W=2.\n\nSigned-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>\nChange-Id: I2cb681f83d0f68ca124d2e4131e4ac0d9f8a6b22\n---\nTesting Hints : make sure virtchannel (VF) still\nworks to configure MAC addresses and such from the VF.\n\n drivers/net/ethernet/intel/i40e/i40e.h | 2 +-\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 13 +++++++------\n drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h | 4 ++--\n 3 files changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ethernet/intel/i40e/i40e.h b/drivers/net/ethernet/intel/i40e/i40e.h\nindex ceb848a..618a2a8 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e.h\n@@ -569,7 +569,7 @@ struct i40e_vsi {\n \tu16 num_queue_pairs; /* Used tx and rx pairs */\n \tu16 num_desc;\n \tenum i40e_vsi_type type; /* VSI type, e.g., LAN, FCoE, etc */\n-\tu16 vf_id;\t\t/* Virtual function ID for SRIOV VSIs */\n+\ts16 vf_id;\t\t/* Virtual function ID for SRIOV VSIs */\n \n \tstruct i40e_tc_configuration tc_config;\n \tstruct i40e_aqc_vsi_properties_data info;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\nindex 4f0214e..41be42d 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c\n@@ -48,7 +48,7 @@ static void i40e_vc_vf_broadcast(struct i40e_pf *pf,\n \tint i;\n \n \tfor (i = 0; i < pf->num_alloc_vfs; i++, vf++) {\n-\t\tint abs_vf_id = vf->vf_id + hw->func_caps.vf_base_id;\n+\t\tint abs_vf_id = vf->vf_id + (int)hw->func_caps.vf_base_id;\n \t\t/* Not all vfs are enabled so skip the ones that are not */\n \t\tif (!test_bit(I40E_VF_STAT_INIT, &vf->vf_states) &&\n \t\t !test_bit(I40E_VF_STAT_ACTIVE, &vf->vf_states))\n@@ -74,7 +74,7 @@ static void i40e_vc_notify_vf_link_state(struct i40e_vf *vf)\n \tstruct i40e_pf *pf = vf->pf;\n \tstruct i40e_hw *hw = &pf->hw;\n \tstruct i40e_link_status *ls = &pf->hw.phy.link_info;\n-\tint abs_vf_id = vf->vf_id + hw->func_caps.vf_base_id;\n+\tint abs_vf_id = vf->vf_id + (int)hw->func_caps.vf_base_id;\n \n \tpfe.event = I40E_VIRTCHNL_EVENT_LINK_CHANGE;\n \tpfe.severity = I40E_PF_EVENT_SEVERITY_INFO;\n@@ -141,7 +141,7 @@ void i40e_vc_notify_vf_reset(struct i40e_vf *vf)\n \t !test_bit(I40E_VF_STAT_ACTIVE, &vf->vf_states))\n \t\treturn;\n \n-\tabs_vf_id = vf->vf_id + vf->pf->hw.func_caps.vf_base_id;\n+\tabs_vf_id = vf->vf_id + (int)vf->pf->hw.func_caps.vf_base_id;\n \n \tpfe.event = I40E_VIRTCHNL_EVENT_RESET_IMPENDING;\n \tpfe.severity = I40E_PF_EVENT_SEVERITY_CERTAIN_DOOM;\n@@ -2516,11 +2516,11 @@ static int i40e_vc_validate_vf_msg(struct i40e_vf *vf, u32 v_opcode,\n * called from the common aeq/arq handler to\n * process request from VF\n **/\n-int i40e_vc_process_vf_msg(struct i40e_pf *pf, u16 vf_id, u32 v_opcode,\n+int i40e_vc_process_vf_msg(struct i40e_pf *pf, s16 vf_id, u32 v_opcode,\n \t\t\t u32 v_retval, u8 *msg, u16 msglen)\n {\n \tstruct i40e_hw *hw = &pf->hw;\n-\tunsigned int local_vf_id = vf_id - hw->func_caps.vf_base_id;\n+\tint local_vf_id = vf_id - (s16)hw->func_caps.vf_base_id;\n \tstruct i40e_vf *vf;\n \tint ret;\n \n@@ -2622,9 +2622,10 @@ int i40e_vc_process_vf_msg(struct i40e_pf *pf, u16 vf_id, u32 v_opcode,\n **/\n int i40e_vc_process_vflr_event(struct i40e_pf *pf)\n {\n-\tu32 reg, reg_idx, bit_idx, vf_id;\n \tstruct i40e_hw *hw = &pf->hw;\n+\tu32 reg, reg_idx, bit_idx;\n \tstruct i40e_vf *vf;\n+\tint vf_id;\n \n \tif (!test_bit(__I40E_VFLR_EVENT_PENDING, &pf->state))\n \t\treturn 0;\ndiff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\nindex bf54873..8751741 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\n+++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h\n@@ -77,7 +77,7 @@ struct i40e_vf {\n \tstruct i40e_pf *pf;\n \n \t/* VF id in the PF space */\n-\tu16 vf_id;\n+\ts16 vf_id;\n \t/* all VF vsis connect to the same parent */\n \tenum i40e_switch_element_types parent_type;\n \tstruct i40e_virtchnl_version_info vf_ver;\n@@ -121,7 +121,7 @@ struct i40e_vf {\n void i40e_free_vfs(struct i40e_pf *pf);\n int i40e_pci_sriov_configure(struct pci_dev *dev, int num_vfs);\n int i40e_alloc_vfs(struct i40e_pf *pf, u16 num_alloc_vfs);\n-int i40e_vc_process_vf_msg(struct i40e_pf *pf, u16 vf_id, u32 v_opcode,\n+int i40e_vc_process_vf_msg(struct i40e_pf *pf, s16 vf_id, u32 v_opcode,\n \t\t\t u32 v_retval, u8 *msg, u16 msglen);\n int i40e_vc_process_vflr_event(struct i40e_pf *pf);\n void i40e_reset_vf(struct i40e_vf *vf, bool flr);\n", "prefixes": [ "next", "S34", "09/12" ] }